You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Siying Dong (JIRA)" <ji...@apache.org> on 2011/07/01 01:05:28 UTC
[jira] [Created] (HIVE-2248) Comparison Operators convert number
types to common type instead of double if necessary
Comparison Operators convert number types to common type instead of double if necessary
---------------------------------------------------------------------------------------
Key: HIVE-2248
URL: https://issues.apache.org/jira/browse/HIVE-2248
Project: Hive
Issue Type: Bug
Reporter: Siying Dong
Assignee: Siying Dong
Now if the two sides of comparison is of different type, we always convert both to double and compare. It was a slight regression from the change in https://issues.apache.org/jira/browse/HIVE-1638. The old UDFOP<Comparison>, using GenericUDFBridge, always tried to find common type first.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2248) Comparison Operators convert number
types to common type instead of double if necessary
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058221#comment-13058221 ]
Hudson commented on HIVE-2248:
------------------------------
Integrated in Hive-trunk-h0.21 #803 (See [https://builds.apache.org/job/Hive-trunk-h0.21/803/])
HIVE-2248 Comparison Operators convert number types to common type instead of
double if necessary (Siying Dong via namit)
namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1141777
Files :
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseCompare.java
> Comparison Operators convert number types to common type instead of double if necessary
> ---------------------------------------------------------------------------------------
>
> Key: HIVE-2248
> URL: https://issues.apache.org/jira/browse/HIVE-2248
> Project: Hive
> Issue Type: Bug
> Reporter: Siying Dong
> Assignee: Siying Dong
> Attachments: HIVE-2248.1.patch
>
>
> Now if the two sides of comparison is of different type, we always convert both to double and compare. It was a slight regression from the change in https://issues.apache.org/jira/browse/HIVE-1638. The old UDFOP<Comparison>, using GenericUDFBridge, always tried to find common type first.
> The worse case is this: If you did "WHERE <BIGINT_COLUMN> = 0 ", we always convert the column and 0 to double and compare, which is wasteful, though it is usually a minor costs in the system. But it is easy to fix.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2248) Comparison Operators convert number
types to common type instead of double if necessary
Posted by "Siying Dong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siying Dong updated HIVE-2248:
------------------------------
Description:
Now if the two sides of comparison is of different type, we always convert both to double and compare. It was a slight regression from the change in https://issues.apache.org/jira/browse/HIVE-1638. The old UDFOP<Comparison>, using GenericUDFBridge, always tried to find common type first.
The worse case is this: If you did "WHERE <BIGINT_COLUMN> = 0 ", we always convert the column and 0 to double and compare, which is wasteful, though it is usually a minor costs in the system. But it is easy to fix.
was:Now if the two sides of comparison is of different type, we always convert both to double and compare. It was a slight regression from the change in https://issues.apache.org/jira/browse/HIVE-1638. The old UDFOP<Comparison>, using GenericUDFBridge, always tried to find common type first.
> Comparison Operators convert number types to common type instead of double if necessary
> ---------------------------------------------------------------------------------------
>
> Key: HIVE-2248
> URL: https://issues.apache.org/jira/browse/HIVE-2248
> Project: Hive
> Issue Type: Bug
> Reporter: Siying Dong
> Assignee: Siying Dong
>
> Now if the two sides of comparison is of different type, we always convert both to double and compare. It was a slight regression from the change in https://issues.apache.org/jira/browse/HIVE-1638. The old UDFOP<Comparison>, using GenericUDFBridge, always tried to find common type first.
> The worse case is this: If you did "WHERE <BIGINT_COLUMN> = 0 ", we always convert the column and 0 to double and compare, which is wasteful, though it is usually a minor costs in the system. But it is easy to fix.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2248) Comparison Operators convert number
types to common type instead of double if necessary
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-2248:
---------------------------------
Component/s: Query Processor
Fix Version/s: 0.8.0
> Comparison Operators convert number types to common type instead of double if necessary
> ---------------------------------------------------------------------------------------
>
> Key: HIVE-2248
> URL: https://issues.apache.org/jira/browse/HIVE-2248
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Siying Dong
> Assignee: Siying Dong
> Fix For: 0.8.0
>
> Attachments: HIVE-2248.1.patch
>
>
> Now if the two sides of comparison is of different type, we always convert both to double and compare. It was a slight regression from the change in https://issues.apache.org/jira/browse/HIVE-1638. The old UDFOP<Comparison>, using GenericUDFBridge, always tried to find common type first.
> The worse case is this: If you did "WHERE <BIGINT_COLUMN> = 0 ", we always convert the column and 0 to double and compare, which is wasteful, though it is usually a minor costs in the system. But it is easy to fix.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2248) Comparison Operators convert number
types to common type instead of double if necessary
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058127#comment-13058127 ]
Namit Jain commented on HIVE-2248:
----------------------------------
+1
> Comparison Operators convert number types to common type instead of double if necessary
> ---------------------------------------------------------------------------------------
>
> Key: HIVE-2248
> URL: https://issues.apache.org/jira/browse/HIVE-2248
> Project: Hive
> Issue Type: Bug
> Reporter: Siying Dong
> Assignee: Siying Dong
> Attachments: HIVE-2248.1.patch
>
>
> Now if the two sides of comparison is of different type, we always convert both to double and compare. It was a slight regression from the change in https://issues.apache.org/jira/browse/HIVE-1638. The old UDFOP<Comparison>, using GenericUDFBridge, always tried to find common type first.
> The worse case is this: If you did "WHERE <BIGINT_COLUMN> = 0 ", we always convert the column and 0 to double and compare, which is wasteful, though it is usually a minor costs in the system. But it is easy to fix.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2248) Comparison Operators convert number
types to common type instead of double if possible
Posted by "Siying Dong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siying Dong updated HIVE-2248:
------------------------------
Summary: Comparison Operators convert number types to common type instead of double if possible (was: Comparison Operators convert number types to common type instead of double if necessary)
> Comparison Operators convert number types to common type instead of double if possible
> --------------------------------------------------------------------------------------
>
> Key: HIVE-2248
> URL: https://issues.apache.org/jira/browse/HIVE-2248
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Siying Dong
> Assignee: Siying Dong
> Fix For: 0.8.0
>
> Attachments: HIVE-2248.1.patch
>
>
> Now if the two sides of comparison is of different type, we always convert both to double and compare. It was a slight regression from the change in https://issues.apache.org/jira/browse/HIVE-1638. The old UDFOP<Comparison>, using GenericUDFBridge, always tried to find common type first.
> The worse case is this: If you did "WHERE <BIGINT_COLUMN> = 0 ", we always convert the column and 0 to double and compare, which is wasteful, though it is usually a minor costs in the system. But it is easy to fix.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2248) Comparison Operators convert number
types to common type instead of double if necessary
Posted by "Siying Dong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siying Dong updated HIVE-2248:
------------------------------
Attachment: HIVE-2248.1.patch
> Comparison Operators convert number types to common type instead of double if necessary
> ---------------------------------------------------------------------------------------
>
> Key: HIVE-2248
> URL: https://issues.apache.org/jira/browse/HIVE-2248
> Project: Hive
> Issue Type: Bug
> Reporter: Siying Dong
> Assignee: Siying Dong
> Attachments: HIVE-2248.1.patch
>
>
> Now if the two sides of comparison is of different type, we always convert both to double and compare. It was a slight regression from the change in https://issues.apache.org/jira/browse/HIVE-1638. The old UDFOP<Comparison>, using GenericUDFBridge, always tried to find common type first.
> The worse case is this: If you did "WHERE <BIGINT_COLUMN> = 0 ", we always convert the column and 0 to double and compare, which is wasteful, though it is usually a minor costs in the system. But it is easy to fix.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2248) Comparison Operators convert number
types to common type instead of double if necessary
Posted by "Siying Dong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siying Dong updated HIVE-2248:
------------------------------
Status: Patch Available (was: Open)
> Comparison Operators convert number types to common type instead of double if necessary
> ---------------------------------------------------------------------------------------
>
> Key: HIVE-2248
> URL: https://issues.apache.org/jira/browse/HIVE-2248
> Project: Hive
> Issue Type: Bug
> Reporter: Siying Dong
> Assignee: Siying Dong
> Attachments: HIVE-2248.1.patch
>
>
> Now if the two sides of comparison is of different type, we always convert both to double and compare. It was a slight regression from the change in https://issues.apache.org/jira/browse/HIVE-1638. The old UDFOP<Comparison>, using GenericUDFBridge, always tried to find common type first.
> The worse case is this: If you did "WHERE <BIGINT_COLUMN> = 0 ", we always convert the column and 0 to double and compare, which is wasteful, though it is usually a minor costs in the system. But it is easy to fix.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2248) Comparison Operators convert number
types to common type instead of double if necessary
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-2248:
-----------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed. Thanks Siying
> Comparison Operators convert number types to common type instead of double if necessary
> ---------------------------------------------------------------------------------------
>
> Key: HIVE-2248
> URL: https://issues.apache.org/jira/browse/HIVE-2248
> Project: Hive
> Issue Type: Bug
> Reporter: Siying Dong
> Assignee: Siying Dong
> Attachments: HIVE-2248.1.patch
>
>
> Now if the two sides of comparison is of different type, we always convert both to double and compare. It was a slight regression from the change in https://issues.apache.org/jira/browse/HIVE-1638. The old UDFOP<Comparison>, using GenericUDFBridge, always tried to find common type first.
> The worse case is this: If you did "WHERE <BIGINT_COLUMN> = 0 ", we always convert the column and 0 to double and compare, which is wasteful, though it is usually a minor costs in the system. But it is easy to fix.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira