You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by kk...@apache.org on 2011/07/14 11:58:31 UTC
svn commit: r1146623 - in /tomcat/trunk: conf/catalina.properties
webapps/docs/changelog.xml
Author: kkolinko
Date: Thu Jul 14 09:58:31 2011
New Revision: 1146623
URL: http://svn.apache.org/viewvc?rev=1146623&view=rev
Log:
Corrected typo in the value of tomcat.util.scan.DefaultJarScanner.jarsToSkip property
Modified:
tomcat/trunk/conf/catalina.properties
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/conf/catalina.properties
URL: http://svn.apache.org/viewvc/tomcat/trunk/conf/catalina.properties?rev=1146623&r1=1146622&r2=1146623&view=diff
==============================================================================
--- tomcat/trunk/conf/catalina.properties (original)
+++ tomcat/trunk/conf/catalina.properties Thu Jul 14 09:58:31 2011
@@ -93,7 +93,7 @@ jasper.jar,jasper-el.jar,ecj-*.jar,\
tomcat-api.jar,tomcat-util.jar,tomcat-coyote.jar,tomcat-dbcp.jar,\
tomcat-i18n-en.jar,tomcat-i18n-es.jar,tomcat-i18n-fr.jar,tomcat-i18n-ja.jar,\
tomcat-juli-adapters.jar,catalina-jmx-remote.jar,catalina-ws.jar,\
-tomcat-jdbc.jar\
+tomcat-jdbc.jar,\
commons-beanutils*.jar,commons-codec*.jar,commons-collections*.jar,\
commons-dbcp*.jar,commons-digester*.jar,commons-fileupload*.jar,\
commons-httpclient*.jar,commons-io*.jar,commons-lang*.jar,commons-logging*.jar,\
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1146623&r1=1146622&r2=1146623&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu Jul 14 09:58:31 2011
@@ -53,6 +53,18 @@
They eventually become mixed with the numbered issues. (I.e., numbered
issues to not "pop up" wrt. others).
-->
+<section name="Tomcat 7.0.20 (markt)">
+ <subsection name="Catalina">
+ <changelog>
+ <fix>
+ Corrected missing comma in the value of <code>jarsToSkip</code>
+ property in <code>conf/catalina.properties</code> file, which
+ caused tomcat-jdbc.jar and commons-beanutils*.jar to be not
+ ignored when scanning jars for tag libraries. (kkolinko)
+ </fix>
+ </changelog>
+ </subsection>
+</section>
<section name="Tomcat 7.0.19 (markt)">
<subsection name="Catalina">
<changelog>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1146623 - in /tomcat/trunk: conf/catalina.properties webapps/docs/changelog.xml
Posted by Konstantin Kolinko <kn...@gmail.com>.
2011/7/19 Rainer Jung <ra...@kippdata.de>:
> On 14.07.2011 12:08, Konstantin Kolinko wrote:
>>
>> It would be nice to add a Test to our testsuite to test that any
>> ".jar" in this property value is followed by comma:
>> either by (optional spaces and comma) or by (end of line).
>
> I added some test cases in r1148245.
>
> They check, whether all tokens (splitted along comma) end with ".jar"
> and whether there is another ".jar" inside the token.
>
> I don't currently tolerate trailing or leading spaces, because I'm not
> sure, what the current impl does with them. Will check later, but not
> critical now, since our default "jarsTiSkip" value doesn't contain such
> whitespace.
>
Thank you. I like it.
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1146623 - in /tomcat/trunk: conf/catalina.properties
webapps/docs/changelog.xml
Posted by Rainer Jung <ra...@kippdata.de>.
On 14.07.2011 12:08, Konstantin Kolinko wrote:
> 2011/7/14 <kk...@apache.org>:
>> Author: kkolinko
>> Date: Thu Jul 14 09:58:31 2011
>> New Revision: 1146623
>>
>> URL: http://svn.apache.org/viewvc?rev=1146623&view=rev
>> Log:
>> Corrected typo in the value of tomcat.util.scan.DefaultJarScanner.jarsToSkip property
>>
>> Modified:
>> tomcat/trunk/conf/catalina.properties
>> tomcat/trunk/webapps/docs/changelog.xml
>>
>
>
>> tomcat-api.jar,tomcat-util.jar,tomcat-coyote.jar,tomcat-dbcp.jar,\
>> tomcat-i18n-en.jar,tomcat-i18n-es.jar,tomcat-i18n-fr.jar,tomcat-i18n-ja.jar,\
>> tomcat-juli-adapters.jar,catalina-jmx-remote.jar,catalina-ws.jar,\
>> -tomcat-jdbc.jar\
>> +tomcat-jdbc.jar,\
>> commons-beanutils*.jar,commons-codec*.jar,commons-collections*.jar,\
>> commons-dbcp*.jar,commons-digester*.jar,commons-fileupload*.jar,\
>> commons-httpclient*.jar,commons-io*.jar,commons-lang*.jar,commons-logging*.jar,\
>
> It would be nice to add a Test to our testsuite to test that any
> ".jar" in this property value is followed by comma:
> either by (optional spaces and comma) or by (end of line).
I added some test cases in r1148245.
They check, whether all tokens (splitted along comma) end with ".jar"
and whether there is another ".jar" inside the token.
I don't currently tolerate trailing or leading spaces, because I'm not
sure, what the current impl does with them. Will check later, but not
critical now, since our default "jarsTiSkip" value doesn't contain such
whitespace.
Regards,
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1146623 - in /tomcat/trunk: conf/catalina.properties webapps/docs/changelog.xml
Posted by Konstantin Kolinko <kk...@apache.org>.
2011/7/14 <kk...@apache.org>:
> Author: kkolinko
> Date: Thu Jul 14 09:58:31 2011
> New Revision: 1146623
>
> URL: http://svn.apache.org/viewvc?rev=1146623&view=rev
> Log:
> Corrected typo in the value of tomcat.util.scan.DefaultJarScanner.jarsToSkip property
>
> Modified:
> tomcat/trunk/conf/catalina.properties
> tomcat/trunk/webapps/docs/changelog.xml
>
> tomcat-api.jar,tomcat-util.jar,tomcat-coyote.jar,tomcat-dbcp.jar,\
> tomcat-i18n-en.jar,tomcat-i18n-es.jar,tomcat-i18n-fr.jar,tomcat-i18n-ja.jar,\
> tomcat-juli-adapters.jar,catalina-jmx-remote.jar,catalina-ws.jar,\
> -tomcat-jdbc.jar\
> +tomcat-jdbc.jar,\
> commons-beanutils*.jar,commons-codec*.jar,commons-collections*.jar,\
> commons-dbcp*.jar,commons-digester*.jar,commons-fileupload*.jar,\
> commons-httpclient*.jar,commons-io*.jar,commons-lang*.jar,commons-logging*.jar,\
It would be nice to add a Test to our testsuite to test that any
".jar" in this property value is followed by comma:
either by (optional spaces and comma) or by (end of line).
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org