You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@mesos.apache.org by "Gavin (JIRA)" <ji...@apache.org> on 2019/04/29 09:28:13 UTC

[jira] [Issue Comment Deleted] (MESOS-8033) Use more idiomatic CMake for compiler features

     [ https://issues.apache.org/jira/browse/MESOS-8033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gavin updated MESOS-8033:
-------------------------
    Comment: was deleted

(was: www.rtat.net)

> Use more idiomatic CMake for compiler features
> ----------------------------------------------
>
>                 Key: MESOS-8033
>                 URL: https://issues.apache.org/jira/browse/MESOS-8033
>             Project: Mesos
>          Issue Type: Improvement
>          Components: cmake
>            Reporter: Andrew Schwartzmeyer
>            Assignee: Andrew Schwartzmeyer
>            Priority: Minor
>              Labels: cmake
>             Fix For: 1.6.0
>
>
> Specifically, we should replace
> {noformat}
>   string(APPEND CMAKE_CXX_FLAGS " -std=c++11")
> {noformat}
> With {{CMAKE_CXX_STANDARD}}, and use [compile feature requirements|https://cmake.org/cmake/help/latest/manual/cmake-compile-features.7.html#compile-feature-requirements].
> And replace
> {noformat}
>   string(APPEND CMAKE_CXX_FLAGS " -Wformat-security")
> {noformat}
> With compile options instead of appending to {{CMAKE_CXX_FLAGS}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)