[GitHub] [trafficserver] bneradt commented on a diff in pull request #9594: Add support for tunnel route config that has both match group and port variable

["bneradt (via GitHub)" <gi...@apache.org>]

bneradt commented on code in PR #9594:
URL: https://github.com/apache/trafficserver/pull/9594#discussion_r1161857793


##########
iocore/net/P_SNIActionPerformer.h:
##########
@@ -232,8 +241,11 @@ class TunnelDestination : public ActionItem
   YamlSNIConfig::TunnelPreWarm tunnel_prewarm = YamlSNIConfig::TunnelPreWarm::UNSET;
   const std::vector<int> &alpn_ids;
 
-  OpId fnArrIndex{OpId::DEFAULT}; /// On creation, we decide which function needs to be called, set the index and then we
-                                  /// call it with the relevant data
+  // The indexes of the mapping functions that need to be called. On
+  // creation, we decide which functions need to be called, add the
+  // coressponding indexes and then we call those functions with the relevant
+  // data.
+  std::vector<OpId> fnArrIndexes;

Review Comment:
   Let's keep these doxygen strings. I this case, with your expanded comments, I suggest `/** ... */`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org