You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Gary Gregory <ga...@gmail.com> on 2012/08/16 13:37:31 UTC
[Codec] Next Commons-Codec release?
(edited message subject to add "[Codec]" prefix)
Yes, there is a certain amount of rain dancing, keeping of fingers crossed,
and cussing involved when cutting releasing, and it's fallen off my radar
to due other priorities.
Is the ML content by the state of the new Crypt classes in
org.apache.commons.codec.digest?
Gary
On Wed, Aug 15, 2012 at 3:01 PM, Christian Hammers <ch...@lathspell.de> wrote:
> Hello
>
> Still no plans to release Commons Codec 1.7? It's a bit discouraging to
> see my
> patches rot in trunk for months. I assume that doing a release is more
> work than just "mvn release:perform" so is there anything I could help
> with?
>
> bye,
>
> -christian-
>
>
> Am Thu, 24 May 2012 11:00:00 +0200
> schrieb Christian Hammers <ch...@lathspell.de>:
>
> > Hello
> >
> > I've contributed some crypt(3) methods to the Apache Commons Codec
> > (CODEC-133) some time ago. So far there has been no release that
> > included it. Can you say when the next one is scheduled?
> >
> > Not that I'm desperately need it, I'm just wondering :-)
> >
> > tschüss,
> >
> > -christian-
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [Codec] Next Commons-Codec release?
Posted by Gary Gregory <ga...@gmail.com>.
Thank you Christian, I intend to take another look at this and the
code base this coming week and see what shape we are in for a release
candidate. All other eyes welcome to take a look, patch and so on.
Gary
On Aug 25, 2012, at 19:09, Christian Hammers <ch...@lathspell.de> wrote:
> Hello
>
> Am Fri, 24 Aug 2012 09:28:55 -0400
> schrieb Gary Gregory <ga...@gmail.com>:
>
>> On Thu, Aug 23, 2012 at 4:05 PM, Thomas Neidhart
>> <th...@gmail.com>wrote:
>>
>>> On 08/22/2012 01:23 PM, Gary Gregory wrote:
>>>
>>>> I did the SVN update from E and the build from a Win7 command
>>>> line.
>>>
>>> Does it still not work for you?
>>
>>
>> Yes, it still happens, very weird. Are you building on Win? Is this an
>> OS-specific EOL thing? Unix vs. DOS? Arg.
>
> I found the cause of the "Missing a header - not enough
> lines in file." checkstyle errors: the checkstyle.xml says:
>
> <property name="headerFile" value="${checkstyle.header.file}" />
>
> but you define the header as property "headerFile" to the checkstyle
> module and not as POM property. So either remove the above line
> (untested) or apply the following patch (tested):
>
> Index: pom.xml
> ===================================================================
> --- pom.xml (Revision 1377365)
> +++ pom.xml (Arbeitskopie)
> @@ -208,6 +208,7 @@
> <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
> <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
> <commons.encoding>UTF-8</commons.encoding>
> +
> <checkstyle.header.file>${basedir}/LICENSE-header.txt</checkstyle.header.file>
> </properties> <build>
> <pluginManagement>
> @@ -272,7 +273,6 @@
> <configuration>
> <configLocation>${basedir}/checkstyle.xml</configLocation>
> <enableRulesSummary>false</enableRulesSummary>
> - <headerFile>${basedir}/LICENSE-header.txt</headerFile>
> </configuration>
> </plugin>
> <plugin>
>
> bye,
>
> -christian-
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [Codec] Next Commons-Codec release?
Posted by Christian Hammers <ch...@lathspell.de>.
Am Mon, 27 Aug 2012 08:59:52 -0400
schrieb Gary Gregory <ga...@gmail.com>:
> On Sat, Aug 25, 2012 at 7:09 PM, Christian Hammers <ch...@lathspell.de>
> wrote:
>
> > Hello
> >
> > Am Fri, 24 Aug 2012 09:28:55 -0400
> > schrieb Gary Gregory <ga...@gmail.com>:
> >
> > > On Thu, Aug 23, 2012 at 4:05 PM, Thomas Neidhart
> > > <th...@gmail.com>wrote:
> > >
> > > > On 08/22/2012 01:23 PM, Gary Gregory wrote:
> > > >
> > > > > I did the SVN update from E and the build from a Win7 command
> > > > > line.
> > > >
> > > > Does it still not work for you?
> > >
> > >
> > > Yes, it still happens, very weird. Are you building on Win? Is
> > > this an OS-specific EOL thing? Unix vs. DOS? Arg.
> >
> > I found the cause of the "Missing a header - not enough
> > lines in file." checkstyle errors: the checkstyle.xml says:
> >
> > <property name="headerFile" value="${checkstyle.header.file}" />
> >
> > but you define the header as property "headerFile" to the checkstyle
> > module and not as POM property. So either remove the above line
> > (untested) or apply the following patch (tested):
> >
> > Index: pom.xml
> > ===================================================================
> > --- pom.xml (Revision 1377365)
> > +++ pom.xml (Arbeitskopie)
> > @@ -208,6 +208,7 @@
> > <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
> >
> > <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
> > <commons.encoding>UTF-8</commons.encoding>
> > +
> >
> > <checkstyle.header.file>${basedir}/LICENSE-header.txt</checkstyle.header.file>
> > </properties> <build>
> > <pluginManagement>
> > @@ -272,7 +273,6 @@
> > <configuration>
> > <configLocation>${basedir}/checkstyle.xml</configLocation>
> > <enableRulesSummary>false</enableRulesSummary>
> > - <headerFile>${basedir}/LICENSE-header.txt</headerFile>
> > </configuration>
> > </plugin>
> > <plugin>
> >
> >
> Weird, the trunk code is already like that (expect the extra blank
> line).
>
> Gary
You meant "except" instead of "expect", right? The format of the diff
is messed up, the first block does not add a blank line but the
following "<checkstyle.header.file>" line.
At least in the current trunk r1377882 the header file location is
still in the <plugins> and not in the <properties> block.
bye,
-christian-
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [Codec] Next Commons-Codec release?
Posted by Gary Gregory <ga...@gmail.com>.
On Sat, Aug 25, 2012 at 7:09 PM, Christian Hammers <ch...@lathspell.de> wrote:
> Hello
>
> Am Fri, 24 Aug 2012 09:28:55 -0400
> schrieb Gary Gregory <ga...@gmail.com>:
>
> > On Thu, Aug 23, 2012 at 4:05 PM, Thomas Neidhart
> > <th...@gmail.com>wrote:
> >
> > > On 08/22/2012 01:23 PM, Gary Gregory wrote:
> > >
> > > > I did the SVN update from E and the build from a Win7 command
> > > > line.
> > >
> > > Does it still not work for you?
> >
> >
> > Yes, it still happens, very weird. Are you building on Win? Is this an
> > OS-specific EOL thing? Unix vs. DOS? Arg.
>
> I found the cause of the "Missing a header - not enough
> lines in file." checkstyle errors: the checkstyle.xml says:
>
> <property name="headerFile" value="${checkstyle.header.file}" />
>
> but you define the header as property "headerFile" to the checkstyle
> module and not as POM property. So either remove the above line
> (untested) or apply the following patch (tested):
>
> Index: pom.xml
> ===================================================================
> --- pom.xml (Revision 1377365)
> +++ pom.xml (Arbeitskopie)
> @@ -208,6 +208,7 @@
> <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
>
> <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
> <commons.encoding>UTF-8</commons.encoding>
> +
>
> <checkstyle.header.file>${basedir}/LICENSE-header.txt</checkstyle.header.file>
> </properties> <build>
> <pluginManagement>
> @@ -272,7 +273,6 @@
> <configuration>
> <configLocation>${basedir}/checkstyle.xml</configLocation>
> <enableRulesSummary>false</enableRulesSummary>
> - <headerFile>${basedir}/LICENSE-header.txt</headerFile>
> </configuration>
> </plugin>
> <plugin>
>
>
Weird, the trunk code is already like that (expect the extra blank line).
Gary
> bye,
>
> -christian-
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [Codec] Next Commons-Codec release?
Posted by Christian Hammers <ch...@lathspell.de>.
Hello
Am Fri, 24 Aug 2012 09:28:55 -0400
schrieb Gary Gregory <ga...@gmail.com>:
> On Thu, Aug 23, 2012 at 4:05 PM, Thomas Neidhart
> <th...@gmail.com>wrote:
>
> > On 08/22/2012 01:23 PM, Gary Gregory wrote:
> >
> > > I did the SVN update from E and the build from a Win7 command
> > > line.
> >
> > Does it still not work for you?
>
>
> Yes, it still happens, very weird. Are you building on Win? Is this an
> OS-specific EOL thing? Unix vs. DOS? Arg.
I found the cause of the "Missing a header - not enough
lines in file." checkstyle errors: the checkstyle.xml says:
<property name="headerFile" value="${checkstyle.header.file}" />
but you define the header as property "headerFile" to the checkstyle
module and not as POM property. So either remove the above line
(untested) or apply the following patch (tested):
Index: pom.xml
===================================================================
--- pom.xml (Revision 1377365)
+++ pom.xml (Arbeitskopie)
@@ -208,6 +208,7 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<commons.encoding>UTF-8</commons.encoding>
+
<checkstyle.header.file>${basedir}/LICENSE-header.txt</checkstyle.header.file>
</properties> <build>
<pluginManagement>
@@ -272,7 +273,6 @@
<configuration>
<configLocation>${basedir}/checkstyle.xml</configLocation>
<enableRulesSummary>false</enableRulesSummary>
- <headerFile>${basedir}/LICENSE-header.txt</headerFile>
</configuration>
</plugin>
<plugin>
bye,
-christian-
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [Codec] Next Commons-Codec release?
Posted by Gary Gregory <ga...@gmail.com>.
On Thu, Aug 23, 2012 at 4:05 PM, Thomas Neidhart
<th...@gmail.com>wrote:
> On 08/22/2012 01:23 PM, Gary Gregory wrote:
>
> > I did the SVN update from E and the build from a Win7 command line.
>
> Does it still not work for you?
Yes, it still happens, very weird. Are you building on Win? Is this an
OS-specific EOL thing? Unix vs. DOS? Arg.
Gary
> I do not get warning anymore (apart from
> the generics related in StringEncoderComparator), both via the
> checkstyle eclipse plugin and by doing mvn site.
>
> btw. I did some more cleanup on the Beider-Morse code by removing debug
> prints and improving the javadoc.
>
> There are still some System.err.println in case the resource files are
> corrupted, but I think we should throw an IllegalStateException in such
> cases (as it is done already at some occasions). Atm I put FIXME
> comments and commented the System.err lines out.
>
> Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [Codec] Next Commons-Codec release?
Posted by Thomas Neidhart <th...@gmail.com>.
On 08/22/2012 01:23 PM, Gary Gregory wrote:
> I did the SVN update from E and the build from a Win7 command line.
Does it still not work for you? I do not get warning anymore (apart from
the generics related in StringEncoderComparator), both via the
checkstyle eclipse plugin and by doing mvn site.
btw. I did some more cleanup on the Beider-Morse code by removing debug
prints and improving the javadoc.
There are still some System.err.println in case the resource files are
corrupted, but I think we should throw an IllegalStateException in such
cases (as it is done already at some occasions). Atm I put FIXME
comments and commented the System.err lines out.
Thomas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [Codec] Next Commons-Codec release?
Posted by Gary Gregory <ga...@gmail.com>.
On Aug 22, 2012, at 2:23, Thomas Neidhart <th...@gmail.com> wrote:
> On 08/22/2012 02:49 AM, Gary Gregory wrote:
>> On Tue, Aug 21, 2012 at 4:50 PM, Thomas Neidhart
>> <th...@gmail.com>wrote:
>>
>>> On 08/21/2012 03:33 PM, Gary Gregory wrote:
>>>> On Mon, Aug 20, 2012 at 5:36 PM, Thomas Neidhart
>>>> <th...@gmail.com>wrote:
>>>>
>>>>> On 08/20/2012 10:46 PM, Gary Gregory wrote:
>>>>>> TN (or anyone):
>>>>>>
>>>>>> I get a lot of Checstyle errors "Missing a header - not enough lines in
>>>>>> file."
>>>>>>
>>>>>> Do you get those too?
>>>>>
>>>>> Yes, indeed, I get the same errors, but I had the header check disabled
>>>>> locally (I guess for the very same reason).
>>>>>
>>>>
>>>> Arg, we need to fix that then.
>>>
>>> fixed. There were trailing spaces in the template header.
>>>
>>
>> Arg again, I am seeing the same header problems even after an svn update...
>
> in eclipse?
I did the SVN update from E and the build from a Win7 command line.
Gary
>
> I had to restart eclipse otherwise the changes were not taken into account.
>
> Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [Codec] Next Commons-Codec release?
Posted by Thomas Neidhart <th...@gmail.com>.
On 08/22/2012 02:49 AM, Gary Gregory wrote:
> On Tue, Aug 21, 2012 at 4:50 PM, Thomas Neidhart
> <th...@gmail.com>wrote:
>
>> On 08/21/2012 03:33 PM, Gary Gregory wrote:
>>> On Mon, Aug 20, 2012 at 5:36 PM, Thomas Neidhart
>>> <th...@gmail.com>wrote:
>>>
>>>> On 08/20/2012 10:46 PM, Gary Gregory wrote:
>>>>> TN (or anyone):
>>>>>
>>>>> I get a lot of Checstyle errors "Missing a header - not enough lines in
>>>>> file."
>>>>>
>>>>> Do you get those too?
>>>>
>>>> Yes, indeed, I get the same errors, but I had the header check disabled
>>>> locally (I guess for the very same reason).
>>>>
>>>
>>> Arg, we need to fix that then.
>>
>> fixed. There were trailing spaces in the template header.
>>
>
> Arg again, I am seeing the same header problems even after an svn update...
in eclipse?
I had to restart eclipse otherwise the changes were not taken into account.
Thomas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [Codec] Next Commons-Codec release?
Posted by Gary Gregory <ga...@gmail.com>.
On Tue, Aug 21, 2012 at 4:50 PM, Thomas Neidhart
<th...@gmail.com>wrote:
> On 08/21/2012 03:33 PM, Gary Gregory wrote:
> > On Mon, Aug 20, 2012 at 5:36 PM, Thomas Neidhart
> > <th...@gmail.com>wrote:
> >
> >> On 08/20/2012 10:46 PM, Gary Gregory wrote:
> >>> TN (or anyone):
> >>>
> >>> I get a lot of Checstyle errors "Missing a header - not enough lines in
> >>> file."
> >>>
> >>> Do you get those too?
> >>
> >> Yes, indeed, I get the same errors, but I had the header check disabled
> >> locally (I guess for the very same reason).
> >>
> >
> > Arg, we need to fix that then.
>
> fixed. There were trailing spaces in the template header.
>
Arg again, I am seeing the same header problems even after an svn update...
Anyone else?
G
> Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [Codec] Next Commons-Codec release?
Posted by Thomas Neidhart <th...@gmail.com>.
On 08/21/2012 03:33 PM, Gary Gregory wrote:
> On Mon, Aug 20, 2012 at 5:36 PM, Thomas Neidhart
> <th...@gmail.com>wrote:
>
>> On 08/20/2012 10:46 PM, Gary Gregory wrote:
>>> TN (or anyone):
>>>
>>> I get a lot of Checstyle errors "Missing a header - not enough lines in
>>> file."
>>>
>>> Do you get those too?
>>
>> Yes, indeed, I get the same errors, but I had the header check disabled
>> locally (I guess for the very same reason).
>>
>
> Arg, we need to fix that then.
fixed. There were trailing spaces in the template header.
Thomas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [Codec] Next Commons-Codec release?
Posted by Gary Gregory <ga...@gmail.com>.
On Mon, Aug 20, 2012 at 5:36 PM, Thomas Neidhart
<th...@gmail.com>wrote:
> On 08/20/2012 10:46 PM, Gary Gregory wrote:
> > TN (or anyone):
> >
> > I get a lot of Checstyle errors "Missing a header - not enough lines in
> > file."
> >
> > Do you get those too?
>
> Yes, indeed, I get the same errors, but I had the header check disabled
> locally (I guess for the very same reason).
>
Arg, we need to fix that then.
Gary
>
> Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [Codec] Next Commons-Codec release?
Posted by Thomas Neidhart <th...@gmail.com>.
On 08/20/2012 10:46 PM, Gary Gregory wrote:
> TN (or anyone):
>
> I get a lot of Checstyle errors "Missing a header - not enough lines in
> file."
>
> Do you get those too?
Yes, indeed, I get the same errors, but I had the header check disabled
locally (I guess for the very same reason).
Thomas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [Codec] Next Commons-Codec release?
Posted by Gary Gregory <ga...@gmail.com>.
TN (or anyone):
I get a lot of Checstyle errors "Missing a header - not enough lines in
file."
Do you get those too?
Gary
On Mon, Aug 20, 2012 at 4:39 PM, Thomas Neidhart
<th...@gmail.com>wrote:
> On 08/17/2012 09:15 PM, Gary Gregory wrote:
> > On Fri, Aug 17, 2012 at 2:49 PM, Thomas Neidhart
> > <th...@gmail.com>wrote:
> >
> >> On 08/16/2012 01:37 PM, Gary Gregory wrote:
> >>> (edited message subject to add "[Codec]" prefix)
> >>>
> >>> Yes, there is a certain amount of rain dancing, keeping of fingers
> >> crossed,
> >>> and cussing involved when cutting releasing, and it's fallen off my
> radar
> >>> to due other priorities.
> >>>
> >>> Is the ML content by the state of the new Crypt classes in
> >>> org.apache.commons.codec.digest?
> >>
> >> I did some javadoc cleanup of the package.
> >>
> >
> > Thank you TN!
> >
> >
> >>
> >> (btw. I find non-closing <p> tags on a separate line the most readable
> >> solution as outlined in the javadoc tutorial
> >>
> >>
> http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html
> >>
> >> what do other people think about it?)
> >>
> >
> > It is nice and clear. I personally do not use the style but am willing to
> > change ;) Since we all know that Javadoc is [X?]HTML-lite, using "broken"
> > XHTML feels odd (unbalanced tags). I might be speaking from fuzzy memory
> > but I vaguely recall odd things happening in combination with opening,
> > closing and nesting some tags. I guess we could use <p> and deal with
> > special cases when they come up.
> >
> >
> >> What is a bit odd is that the methods throw Exception although it's not
> >> needed at all (e.g. UnixCrypt)
> >
> >
> > I see that with
> org.apache.commons.codec.digest.UnixCrypt.crypt(String)...
> > nasty! Good catch!
> >
> >
> >> or could be constrained to
> >> NoSuchAlgorithmException (e.g. in Md5Crypt).
> >>
> >
> > Yes, more nastiness.
> >
> > The exceptions might have been there with the though of making all of
> these
> > classes implement a common interface. I do not seen the need for that
> ATM.
> > We can always add it later if needed.
> >
> >
> >>
> >> Javadoc does not yet mention the exceptions too (but I can fix that).
> >>
> >
> >
> > Yes, please fix it all up as much as you can.
>
> ok done.
>
> Regarding the TODO in the B64 class:
>
> I do not think that the existing Base64 implementation can be reused, as
> the cipher text encoded by crypt is only "in a form of" Base64.
>
> Actually the encoding alphabet is slightly different ('.' instead of
> '+') and also the encoding itself is not the same.
>
> Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [Codec] Next Commons-Codec release?
Posted by Thomas Neidhart <th...@gmail.com>.
On 08/17/2012 09:15 PM, Gary Gregory wrote:
> On Fri, Aug 17, 2012 at 2:49 PM, Thomas Neidhart
> <th...@gmail.com>wrote:
>
>> On 08/16/2012 01:37 PM, Gary Gregory wrote:
>>> (edited message subject to add "[Codec]" prefix)
>>>
>>> Yes, there is a certain amount of rain dancing, keeping of fingers
>> crossed,
>>> and cussing involved when cutting releasing, and it's fallen off my radar
>>> to due other priorities.
>>>
>>> Is the ML content by the state of the new Crypt classes in
>>> org.apache.commons.codec.digest?
>>
>> I did some javadoc cleanup of the package.
>>
>
> Thank you TN!
>
>
>>
>> (btw. I find non-closing <p> tags on a separate line the most readable
>> solution as outlined in the javadoc tutorial
>>
>> http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html
>>
>> what do other people think about it?)
>>
>
> It is nice and clear. I personally do not use the style but am willing to
> change ;) Since we all know that Javadoc is [X?]HTML-lite, using "broken"
> XHTML feels odd (unbalanced tags). I might be speaking from fuzzy memory
> but I vaguely recall odd things happening in combination with opening,
> closing and nesting some tags. I guess we could use <p> and deal with
> special cases when they come up.
>
>
>> What is a bit odd is that the methods throw Exception although it's not
>> needed at all (e.g. UnixCrypt)
>
>
> I see that with org.apache.commons.codec.digest.UnixCrypt.crypt(String)...
> nasty! Good catch!
>
>
>> or could be constrained to
>> NoSuchAlgorithmException (e.g. in Md5Crypt).
>>
>
> Yes, more nastiness.
>
> The exceptions might have been there with the though of making all of these
> classes implement a common interface. I do not seen the need for that ATM.
> We can always add it later if needed.
>
>
>>
>> Javadoc does not yet mention the exceptions too (but I can fix that).
>>
>
>
> Yes, please fix it all up as much as you can.
ok done.
Regarding the TODO in the B64 class:
I do not think that the existing Base64 implementation can be reused, as
the cipher text encoded by crypt is only "in a form of" Base64.
Actually the encoding alphabet is slightly different ('.' instead of
'+') and also the encoding itself is not the same.
Thomas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [Codec] Next Commons-Codec release?
Posted by Gary Gregory <ga...@gmail.com>.
On Fri, Aug 17, 2012 at 2:49 PM, Thomas Neidhart
<th...@gmail.com>wrote:
> On 08/16/2012 01:37 PM, Gary Gregory wrote:
> > (edited message subject to add "[Codec]" prefix)
> >
> > Yes, there is a certain amount of rain dancing, keeping of fingers
> crossed,
> > and cussing involved when cutting releasing, and it's fallen off my radar
> > to due other priorities.
> >
> > Is the ML content by the state of the new Crypt classes in
> > org.apache.commons.codec.digest?
>
> I did some javadoc cleanup of the package.
>
Thank you TN!
>
> (btw. I find non-closing <p> tags on a separate line the most readable
> solution as outlined in the javadoc tutorial
>
> http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html
>
> what do other people think about it?)
>
It is nice and clear. I personally do not use the style but am willing to
change ;) Since we all know that Javadoc is [X?]HTML-lite, using "broken"
XHTML feels odd (unbalanced tags). I might be speaking from fuzzy memory
but I vaguely recall odd things happening in combination with opening,
closing and nesting some tags. I guess we could use <p> and deal with
special cases when they come up.
> What is a bit odd is that the methods throw Exception although it's not
> needed at all (e.g. UnixCrypt)
I see that with org.apache.commons.codec.digest.UnixCrypt.crypt(String)...
nasty! Good catch!
> or could be constrained to
> NoSuchAlgorithmException (e.g. in Md5Crypt).
>
Yes, more nastiness.
The exceptions might have been there with the though of making all of these
classes implement a common interface. I do not seen the need for that ATM.
We can always add it later if needed.
>
> Javadoc does not yet mention the exceptions too (but I can fix that).
>
Yes, please fix it all up as much as you can.
Thank you,
Gary
>
> Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [Codec] Next Commons-Codec release?
Posted by Thomas Neidhart <th...@gmail.com>.
On 08/16/2012 01:37 PM, Gary Gregory wrote:
> (edited message subject to add "[Codec]" prefix)
>
> Yes, there is a certain amount of rain dancing, keeping of fingers crossed,
> and cussing involved when cutting releasing, and it's fallen off my radar
> to due other priorities.
>
> Is the ML content by the state of the new Crypt classes in
> org.apache.commons.codec.digest?
I did some javadoc cleanup of the package.
(btw. I find non-closing <p> tags on a separate line the most readable
solution as outlined in the javadoc tutorial
http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html
what do other people think about it?)
What is a bit odd is that the methods throw Exception although it's not
needed at all (e.g. UnixCrypt) or could be constrained to
NoSuchAlgorithmException (e.g. in Md5Crypt).
Javadoc does not yet mention the exceptions too (but I can fix that).
Thomas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org