You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Darrel Schneider <ds...@pivotal.io> on 2015/08/19 20:35:17 UTC
Review Request 37619: GEODE-228: fix intermittent failures in
NanoTimer tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37619/
-----------------------------------------------------------
Review request for geode and Kirk Lund.
Bugs: GEODE-228
https://issues.apache.org/jira/browse/GEODE-228
Repository: geode
Description
-------
- NanoTimer2JUnitTest has been removed since it was an old
test that has been replaced by NanoTimerJUnitTest.
- NanoTimer can now be constructed with a TimeService.
This allows unit tests to insert a different clock.
- NanoTimerJUnitTest now uses its own TimeService when
testing NanoTimer which prevents intermittent failures.
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/internal/NanoTimer.java d0055ddb26605391d9d513276e622d753df7b4e6
gemfire-core/src/test/java/com/gemstone/gemfire/internal/NanoTimer2JUnitTest.java fe243fbd1f742e07b1d1f79afcd06ff5346d59ab
gemfire-core/src/test/java/com/gemstone/gemfire/internal/NanoTimerJUnitTest.java 16b423a3a761b53c3434441d302b1e2afdeb5f98
Diff: https://reviews.apache.org/r/37619/diff/
Testing
-------
NanoTImerJUnitTest
Thanks,
Darrel Schneider
Re: Review Request 37619: GEODE-228: fix intermittent failures in
NanoTimer tests
Posted by Ashvin A <aa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37619/#review95878
-----------------------------------------------------------
Ship it!
Ship It!
- Ashvin A
On Aug. 19, 2015, 6:35 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37619/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2015, 6:35 p.m.)
>
>
> Review request for geode and Kirk Lund.
>
>
> Bugs: GEODE-228
> https://issues.apache.org/jira/browse/GEODE-228
>
>
> Repository: geode
>
>
> Description
> -------
>
> - NanoTimer2JUnitTest has been removed since it was an old
> test that has been replaced by NanoTimerJUnitTest.
> - NanoTimer can now be constructed with a TimeService.
> This allows unit tests to insert a different clock.
> - NanoTimerJUnitTest now uses its own TimeService when
> testing NanoTimer which prevents intermittent failures.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/NanoTimer.java d0055ddb26605391d9d513276e622d753df7b4e6
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/NanoTimer2JUnitTest.java fe243fbd1f742e07b1d1f79afcd06ff5346d59ab
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/NanoTimerJUnitTest.java 16b423a3a761b53c3434441d302b1e2afdeb5f98
>
> Diff: https://reviews.apache.org/r/37619/diff/
>
>
> Testing
> -------
>
> NanoTImerJUnitTest
>
>
> Thanks,
>
> Darrel Schneider
>
>