You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "xieyupei (via GitHub)" <gi...@apache.org> on 2023/07/23 15:09:26 UTC
[GitHub] [hbase] xieyupei commented on a diff in pull request #5330: HBASE-27717 Add rsgroup name for dead region servers on master UI
xieyupei commented on code in PR #5330:
URL: https://github.com/apache/hbase/pull/5330#discussion_r1271466543
##########
hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon:
##########
@@ -698,17 +699,37 @@ AssignmentManager assignmentManager = master.getAssignmentManager();
<th></th>
<th>ServerName</th>
<th>Stop time</th>
+ <%if !master.isInMaintenanceMode() && master.getMasterCoprocessorHost() != null %>
+ <%if RSGroupUtil.isRSGroupEnabled(master.getConfiguration()) %>
+ <th>RSGroup</th>
+ </%if>
+ </%if>
</tr>
<%java>
- DeadServer deadServerUtil = master.getServerManager().getDeadServers();
- ServerName [] deadServerNames = deadServers.toArray(new ServerName[deadServers.size()]);
- Arrays.sort(deadServerNames);
- for (ServerName deadServerName: deadServerNames) {
+ RSGroupInfoManager inMgr = null;
+ DeadServer deadServerUtil = master.getServerManager().getDeadServers();
+ ServerName [] deadServerNames = deadServers.toArray(new ServerName[deadServers.size()]);
+ Arrays.sort(deadServerNames);
+ if (!master.isInMaintenanceMode() && master.getMasterCoprocessorHost() != null
+ && RSGroupUtil.isRSGroupEnabled(master.getConfiguration())) {
+ inMgr = master.getRSGroupInfoManager();
+ }
+ for (ServerName deadServerName: deadServerNames) {
+ String rsGroupName = "default";
Review Comment:
great，thank you
##########
hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon:
##########
@@ -698,17 +699,37 @@ AssignmentManager assignmentManager = master.getAssignmentManager();
<th></th>
<th>ServerName</th>
<th>Stop time</th>
+ <%if !master.isInMaintenanceMode() && master.getMasterCoprocessorHost() != null %>
+ <%if RSGroupUtil.isRSGroupEnabled(master.getConfiguration()) %>
+ <th>RSGroup</th>
+ </%if>
+ </%if>
</tr>
<%java>
- DeadServer deadServerUtil = master.getServerManager().getDeadServers();
- ServerName [] deadServerNames = deadServers.toArray(new ServerName[deadServers.size()]);
- Arrays.sort(deadServerNames);
- for (ServerName deadServerName: deadServerNames) {
+ RSGroupInfoManager inMgr = null;
+ DeadServer deadServerUtil = master.getServerManager().getDeadServers();
+ ServerName [] deadServerNames = deadServers.toArray(new ServerName[deadServers.size()]);
+ Arrays.sort(deadServerNames);
+ if (!master.isInMaintenanceMode() && master.getMasterCoprocessorHost() != null
+ && RSGroupUtil.isRSGroupEnabled(master.getConfiguration())) {
+ inMgr = master.getRSGroupInfoManager();
+ }
+ for (ServerName deadServerName: deadServerNames) {
+ String rsGroupName = "default";
Review Comment:
great，thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org