You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "chickenlj (GitHub)" <gi...@apache.org> on 2019/09/24 12:02:42 UTC
[GitHub] [dubbo] chickenlj opened pull request #5110: Add back
try-catch clause deleted in #4899.
## What is the purpose of the change
followup of #4899
## Brief changelog
catch exception around reflect invocation.
[ Full content available at: https://github.com/apache/dubbo/pull/5110 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] codecov-io commented on issue #5110: Add back
try-catch clause deleted in #4899.
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5110?src=pr&el=h1) Report
> Merging [#5110](https://codecov.io/gh/apache/dubbo/pull/5110?src=pr&el=desc) into [2.7.4-release](https://codecov.io/gh/apache/dubbo/commit/13ddecba0e4d7546591b9d93479dc7e58895d2ac?src=pr&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/dubbo/pull/5110?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 2.7.4-release #5110 +/- ##
===================================================
+ Coverage 63.92% 64.01% +0.09%
- Complexity 450 451 +1
===================================================
Files 770 770
Lines 33268 33272 +4
Branches 5236 5250 +14
===================================================
+ Hits 21267 21300 +33
+ Misses 9563 9540 -23
+ Partials 2438 2432 -6
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/5110?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/dubbo/config/AbstractConfig.java](https://codecov.io/gh/apache/dubbo/pull/5110/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdENvbmZpZy5qYXZh) | `79.88% <50%> (-0.65%)` | `0 <0> (ø)` | |
| [...bbo/registry/support/ProviderConsumerRegTable.java](https://codecov.io/gh/apache/dubbo/pull/5110/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L1Byb3ZpZGVyQ29uc3VtZXJSZWdUYWJsZS5qYXZh) | `80.48% <0%> (-4.88%)` | `0% <0%> (ø)` | |
| [...che/dubbo/common/compiler/support/JdkCompiler.java](https://codecov.io/gh/apache/dubbo/pull/5110/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29tcGlsZXIvc3VwcG9ydC9KZGtDb21waWxlci5qYXZh) | `64.54% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [...org/apache/dubbo/registry/redis/RedisRegistry.java](https://codecov.io/gh/apache/dubbo/pull/5110/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktcmVkaXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlZ2lzdHJ5L3JlZGlzL1JlZGlzUmVnaXN0cnkuamF2YQ==) | `48.15% <0%> (+0.28%)` | `31% <0%> (ø)` | :arrow_down: |
| [.../java/org/apache/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/dubbo/pull/5110/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWZlcmVuY2VDb25maWcuamF2YQ==) | `60.94% <0%> (+0.36%)` | `0% <0%> (ø)` | :arrow_down: |
| [...org/apache/dubbo/config/context/ConfigManager.java](https://codecov.io/gh/apache/dubbo/pull/5110/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9jb250ZXh0L0NvbmZpZ01hbmFnZXIuamF2YQ==) | `66.66% <0%> (+0.79%)` | `0% <0%> (ø)` | :arrow_down: |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/dubbo/pull/5110/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `93.75% <0%> (+1.04%)` | `0% <0%> (ø)` | :arrow_down: |
| [...ache/dubbo/common/compiler/support/ClassUtils.java](https://codecov.io/gh/apache/dubbo/pull/5110/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29tcGlsZXIvc3VwcG9ydC9DbGFzc1V0aWxzLmphdmE=) | `50.26% <0%> (+1.04%)` | `0% <0%> (ø)` | :arrow_down: |
| [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/5110/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `55.68% <0%> (+1.13%)` | `20% <0%> (+1%)` | :arrow_up: |
| [...he/dubbo/registry/multicast/MulticastRegistry.java](https://codecov.io/gh/apache/dubbo/pull/5110/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbXVsdGljYXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9tdWx0aWNhc3QvTXVsdGljYXN0UmVnaXN0cnkuamF2YQ==) | `69.68% <0%> (+1.8%)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [9 more](https://codecov.io/gh/apache/dubbo/pull/5110/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/5110?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/5110?src=pr&el=footer). Last update [13ddecb...a110190](https://codecov.io/gh/apache/dubbo/pull/5110?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo/pull/5110 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] cvictory closed pull request #5110: Add back
try-catch clause deleted in #4899.
Posted by "cvictory (GitHub)" <gi...@apache.org>.
[ pull request closed by cvictory ]
[ Full content available at: https://github.com/apache/dubbo/pull/5110 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org