You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fluss.apache.org by "vamossagar12 (via GitHub)" <gi...@apache.org> on 2026/05/17 11:33:53 UTC

[PR] LanceLakeWriter#close does not clear allFragments [fluss]

vamossagar12 opened a new pull request, #3333:
URL: https://github.com/apache/fluss/pull/3333

   <!--
   *Thank you very much for contributing to Fluss - we are happy that you want to help us improve Fluss. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GitHub issue](https://github.com/apache/fluss/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no issue.
   
     - Name the pull request in the format "[component] Title of the pull request", where *[component]* should be replaced by the name of the component being changed. Typically, this corresponds to the component label assigned to the issue (e.g., [kv], [log], [client], [flink]). Skip *[component]* if you are unsure about which is the best component.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
   
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes.
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
   
     - **Generative AI disclosure:** Indicate whether generative AI tools were used in authoring this PR. If yes, specify the tool below.
       - [ ] No generative AI tools used
       - [ ] Yes (please specify the tool below)
   
   **(The sections below can be removed for hotfixes or typos)**
   -->
   
   <!--
   Generated-by: [Tool Name and Version] following [the guidelines](https://github.com/apache/fluss/blob/main/AGENTS.md)
   -->
   
   ### Purpose
   
   <!-- Linking this pull request to the issue -->
   Linked issue: close #3332 
   
   <!-- What is the purpose of the change -->
   
   In [LanceLakeWriter.java#close()](https://github.com/apache/fluss/blob/main/fluss-lake/fluss-lake-lance/src/main/java/org/apache/fluss/lake/lance/tiering/LanceLakeWriter.java#L129-L137), allFragments still holds references to FragmentMetadata objects. If complete() is called after close(), it would return stale fragments. While the lifecycle should prevent this, clearing the list in close() is defensive best practice.
   
   ### Brief change log
   
   The fix is simple, clear `allFramgments` when close() is invoked in LanceLakeWriter.
   
   ### Tests
   
   Added a unit test
   
   ### API and Format
   
   <!-- Does this change affect API or storage format -->
   
   ### Documentation
   
   <!-- Does this change introduce a new feature -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] LanceLakeWriter#close does not clear allFragments [fluss]

Posted by "vamossagar12 (via GitHub)" <gi...@apache.org>.
vamossagar12 closed pull request #3333: LanceLakeWriter#close does not clear allFragments
URL: https://github.com/apache/fluss/pull/3333


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] LanceLakeWriter#close does not clear allFragments [fluss]

Posted by "vamossagar12 (via GitHub)" <gi...@apache.org>.
vamossagar12 commented on PR #3333:
URL: https://github.com/apache/fluss/pull/3333#issuecomment-4470747596

   This looks like a non-issue. Closing for now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] LanceLakeWriter#close does not clear allFragments [fluss]

Posted by "vamossagar12 (via GitHub)" <gi...@apache.org>.
vamossagar12 commented on PR #3333:
URL: https://github.com/apache/fluss/pull/3333#issuecomment-4470585130

   @polyzos can you PTAL at this small PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org