[GitHub] [spark] ueshin commented on a diff in pull request #43137: [SPARK-43662][PS][CONNECT] Support merge_asof in Spark Connect

["ueshin (via GitHub)" <gi...@apache.org>]

ueshin commented on code in PR #43137:
URL: https://github.com/apache/spark/pull/43137#discussion_r1337896004


##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -595,6 +595,47 @@ def join(
 
     join.__doc__ = PySparkDataFrame.join.__doc__
 
+    def _joinAsOf(

Review Comment:
   Because so far this is not public for PySpark's DataFrame, but supposed to be called from pandas API's `merge_asof` only.



##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -595,6 +595,47 @@ def join(
 
     join.__doc__ = PySparkDataFrame.join.__doc__
 
+    def _joinAsOf(

Review Comment:
   Because so far this is not public for PySpark's DataFrame, but supposed to be called from pandas API's `merge_asof` only.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org