[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3185: [KYUUBI #2282] Add lineage records for sql statement execution in Kyuubi engine logs

[GitBox <gi...@apache.org>]

pan3793 commented on code in PR #3185:
URL: https://github.com/apache/incubator-kyuubi/pull/3185#discussion_r940895078


##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/KyuubiSparkUtil.scala:
##########
@@ -90,4 +90,59 @@ object KyuubiSparkUtil extends Logging {
     val runtimeSparkVer = org.apache.spark.SPARK_VERSION
     Utils.majorMinorVersion(runtimeSparkVer)
   }
+
+  /**
+   * Given a Kyuubi/Spark/Hive version string,
+   * return the (major version number, minor version number).
+   * E.g., for 2.0.1-SNAPSHOT, return (2, 0).
+   */
+  def majorMinorVersion(version: String): (Int, Int) = {

Review Comment:
   It can be simplified since https://github.com/apache/incubator-kyuubi/pull/3181 get merged.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org