Versioning in sources

["William L. Thomson Jr." <wl...@gentoo.org>]

I could have swarn this was brought up recently but could not find
mention of it in archives. Guess I should file a bug on it, but it's
kinda a moot issue.

It seems the sources for 6.0.x have not really been versioned. I have
noticed it myself on occasion, but never cared enough to comment or etc.
A user commented recently, which motivated me to act :)

Anyway 6.0.x stuff is all 6.0.0-snapshot. Or something like that.
Looking at latest 5.5.23 sources, they are versioned as 5.5.20 :(

Now I can totally sed this stuff on compile/install/merge but would be
nice if it could be addressed upstream. I am sure others downloading
sources would prefer the default to match the version of the sources :)

Minor issue, but kinda annoying just the same. Thanks much, and let me
know if you would prefer I file a bug.

-- 
William L. Thomson Jr.
Gentoo/Java

Re: Versioning in sources

[Tim Funk <fu...@joedog.org>]

Why not change dist.xml to rewrite ServerInfo.properties (and other 
appropriate files) when creating the distribution src pacakges?

Then the extra commits are avoided.

-Tim

Remy Maucherat wrote:
> Filip Hanik - Dev Lists wrote:
>> aah, that makes sense.
>>
>> Remember that the release manager is carrying his/her own 
>> build.properties, and if you build from source, you should too.
>> in there you override any properties needed. That is why all binary 
>> builds are correct, but your build isn't.
>>
>> what you are asking for is that we update build.properties.default 
>> before tagging a release, correct?
> 
> Obviously, I am purposefully not doing that (I find those stupid 
> commits, well, stupid ...).
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Re: Versioning in sources

[Remy Maucherat <re...@apache.org>]

Filip Hanik - Dev Lists wrote:
> aah, that makes sense.
> 
> Remember that the release manager is carrying his/her own 
> build.properties, and if you build from source, you should too.
> in there you override any properties needed. That is why all binary 
> builds are correct, but your build isn't.
> 
> what you are asking for is that we update build.properties.default 
> before tagging a release, correct?

Obviously, I am purposefully not doing that (I find those stupid 
commits, well, stupid ...).

Rémy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Re: Versioning in sources

["William L. Thomson Jr." <wl...@gentoo.org>]

On Thu, 2007-05-24 at 13:14 +0200, Filip Hanik - Dev Lists wrote:
>
> I'll try to remember to do it for 5.5.x,

Great, pretty sure it was always done in the past. At least till 5.5.23
which was left at 5.5.20.

>  Remy will opt out doing it, so 
> you shouldn't depend on it.

Ok that's to bad. :(

> To Remy's defense, its kind of pain in the butt having a version number 
> in SVN that get's tagged anyway,

Ok, but that tends to differ from most all other open source app, but to
each their own. Usually most FOSS apps releasing tagged sources will
have the version reflected in the sources as well. So once the app is
built, it's version is reflected within the software. Not just on
package sources.

To bad this was done in the past but won't be done in the future. FOSS
projects should care just as much for source releases as binaries. But
that is not always the case :(

> so you might be better off just keeping the version yourself, right now 
> you're only releasing plain vanilla ASF stuff,

Well I would not call it plain. But we prefer to not modify sources as
much as possible. I am patching and modifying the build system. Since we
don't want to download any deps. Much less compile/package stuff already
compiled like servet/jsp api jars and etc.

> but in the future you could add stuff to the release, or modify it, and 
> hence want to also modify the version number when you build

I doubt we will ever modify the version number when we build. Beyond our
-rX for that reflects ebuild revision #.

I will just ad some sed or etc to the ebuild to take the source version
of the tarball and make sure the prop file matches that. :(

-- 
William L. Thomson Jr.
Gentoo/Java

Re: Versioning in sources

[Filip Hanik - Dev Lists <de...@hanik.com>]

William L. Thomson Jr. wrote:
> On Wed, 2007-05-23 at 19:46 +0200, Filip Hanik - Dev Lists wrote:
>   
>> aah, that makes sense.
>>
>> Remember that the release manager is carrying his/her own 
>> build.properties, and if you build from source, you should too.
>> in there you override any properties needed. That is why all binary 
>> builds are correct, but your build isn't.
>>     
>
> Sure, and I can sed this in the build process, but prefer to not modify
> upstreams stuff as much as possible.
>
>   
>> what you are asking for is that we update build.properties.default 
>> before tagging a release, correct?
>>     
>
> Yes, please. So that if one downloads versioned sources, and just builds
> it by invoking ant with all defaults. The resulting build version will
> match the sources it was built from.
>   
I'll try to remember to do it for 5.5.x, Remy will opt out doing it, so 
you shouldn't depend on it.
To Remy's defense, its kind of pain in the butt having a version number 
in SVN that get's tagged anyway,
so you might be better off just keeping the version yourself, right now 
you're only releasing plain vanilla ASF stuff,
but in the future you could add stuff to the release, or modify it, and 
hence want to also modify the version number when you build

Filip


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Re: Versioning in sources

["William L. Thomson Jr." <wl...@gentoo.org>]

On Wed, 2007-05-23 at 19:46 +0200, Filip Hanik - Dev Lists wrote:
> aah, that makes sense.
> 
> Remember that the release manager is carrying his/her own 
> build.properties, and if you build from source, you should too.
> in there you override any properties needed. That is why all binary 
> builds are correct, but your build isn't.

Sure, and I can sed this in the build process, but prefer to not modify
upstreams stuff as much as possible.

> what you are asking for is that we update build.properties.default 
> before tagging a release, correct?

Yes, please. So that if one downloads versioned sources, and just builds
it by invoking ant with all defaults. The resulting build version will
match the sources it was built from.

-- 
William L. Thomson Jr.
Gentoo/Java

Re: Versioning in sources

[Filip Hanik - Dev Lists <de...@hanik.com>]

aah, that makes sense.

Remember that the release manager is carrying his/her own 
build.properties, and if you build from source, you should too.
in there you override any properties needed. That is why all binary 
builds are correct, but your build isn't.

what you are asking for is that we update build.properties.default 
before tagging a release, correct?

Filip

William L. Thomson Jr. wrote:
> Filip,
>
> On Wed, 2007-05-23 at 18:37 +0200, Filip Hanik - Dev Lists wrote:
>   
>> hey William, what are you referring to? any specific .java files that 
>> need a version number?
>>     
>
> Sorry should have been more specific, the problem lies in
> build.properties.default
>
>   
>> I was under the impression that we only tag each build, and then there 
>> is a small sucker in a property file that we swap out.
>>     
>
> It's the prop file being neglected :)
>
>   
>> ie, when you start 5.5.23 then you see
>>
>> May 23, 2007 6:35:55 PM org.apache.catalina.core.StandardEngine start
>> INFO: Starting Servlet Engine: Apache Tomcat/5.5.23
>>     
>
> Not here, with 6.0.13 I get
>
> May 23, 2007 1:15:58 PM org.apache.catalina.core.StandardEngine start
> INFO: Starting Servlet Engine: Apache Tomcat/6.0-snapshot
>
> With 5.5.23, I get
>
> May 23, 2007 1:17:01 PM org.apache.catalina.core.StandardEngine start
> INFO: Starting Servlet Engine: Apache Tomcat/5.5
>
> Not sure what that's about with 5.5.23, since the prop file has 5.5.20,
> so should reflect that version but does not.
>
> 404, and other error pages also reflect the versions as shown in the log
> file and prop file.
>
>
>   


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Re: Versioning in sources

["William L. Thomson Jr." <wl...@gentoo.org>]

Filip,

On Wed, 2007-05-23 at 18:37 +0200, Filip Hanik - Dev Lists wrote:
> hey William, what are you referring to? any specific .java files that 
> need a version number?

Sorry should have been more specific, the problem lies in
build.properties.default

> I was under the impression that we only tag each build, and then there 
> is a small sucker in a property file that we swap out.

It's the prop file being neglected :)

> ie, when you start 5.5.23 then you see
> 
> May 23, 2007 6:35:55 PM org.apache.catalina.core.StandardEngine start
> INFO: Starting Servlet Engine: Apache Tomcat/5.5.23

Not here, with 6.0.13 I get

May 23, 2007 1:15:58 PM org.apache.catalina.core.StandardEngine start
INFO: Starting Servlet Engine: Apache Tomcat/6.0-snapshot

With 5.5.23, I get

May 23, 2007 1:17:01 PM org.apache.catalina.core.StandardEngine start
INFO: Starting Servlet Engine: Apache Tomcat/5.5

Not sure what that's about with 5.5.23, since the prop file has 5.5.20,
so should reflect that version but does not.

404, and other error pages also reflect the versions as shown in the log
file and prop file.


-- 
William L. Thomson Jr.
Gentoo/Java

Re: Versioning in sources

[Filip Hanik - Dev Lists <de...@hanik.com>]

hey William, what are you referring to? any specific .java files that 
need a version number?
I was under the impression that we only tag each build, and then there 
is a small sucker in a property file that we swap out.

ie, when you start 5.5.23 then you see

May 23, 2007 6:35:55 PM org.apache.catalina.core.StandardEngine start
INFO: Starting Servlet Engine: Apache Tomcat/5.5.23

Filip


William L. Thomson Jr. wrote:
> I could have swarn this was brought up recently but could not find
> mention of it in archives. Guess I should file a bug on it, but it's
> kinda a moot issue.
>
> It seems the sources for 6.0.x have not really been versioned. I have
> noticed it myself on occasion, but never cared enough to comment or etc.
> A user commented recently, which motivated me to act :)
>
> Anyway 6.0.x stuff is all 6.0.0-snapshot. Or something like that.
> Looking at latest 5.5.23 sources, they are versioned as 5.5.20 :(
>
> Now I can totally sed this stuff on compile/install/merge but would be
> nice if it could be addressed upstream. I am sure others downloading
> sources would prefer the default to match the version of the sources :)
>
> Minor issue, but kinda annoying just the same. Thanks much, and let me
> know if you would prefer I file a bug.
>
>   


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org