You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Andrew Sterling Hanenkamp <st...@hanenkamp.com> on 2002/08/01 16:40:33 UTC
[PATCH] cocoon.roles is broken
This is a very small update to the cocoon.roles file which has a typo
for the output-modules role. (...input.OutputModuleSelector instead of
...output.OutputModuleSelector).
Regards,
Sterling
Index: cocoon.roles
===================================================================
RCS file:
/home/cvspublic/xml-cocoon2/src/java/org/apache/cocoon/cocoon.roles,v
retrieving revision 1.32
diff -u -r1.32 cocoon.roles
--- cocoon.roles 1 Jul 2002 08:21:09 -0000 1.32
+++ cocoon.roles 1 Aug 2002 14:36:15 -0000
@@ -195,7 +195,7 @@
shorthand="input-modules"
default-class="org.apache.avalon.excalibur.component.ExcaliburComponentSelector"/>
- <role
name="org.apache.cocoon.components.modules.input.OutputModuleSelector"
+ <role
name="org.apache.cocoon.components.modules.output.OutputModuleSelector"
shorthand="output-modules"
default-class="org.apache.avalon.excalibur.component.ExcaliburComponentSelector"/>
--
<>< ><> <>< ><> <>< ><> <>< ><> <>< ><> <>< ><> <>< ><> <>< ><> <>< ><>
<>< ><>
Andrew Sterling Hanenkamp
http://Andrew.Sterling.Hanenkamp.com/
sterling@hanenkamp.com / sterling@cis.ksu.edu
Friends, there comes a time in every man's life where he has to look
the
potato of injustice right in the eye. -- Michael Richards,
UHF
---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org
RE: [PATCH] cocoon.roles is broken
Posted by Giacomo Pati <gi...@apache.org>.
On 1 Aug 2002, Andrew Sterling Hanenkamp wrote:
> So I just noticed a few minutes ago. My apologies for not being more
> thorough. It appears deliberate. Can anyone tell me why one would
> purposely set the role of OutputModule as:
>
> String ROLE = "org.apache.cocoon.components.modules.input.OutputModule";
>
> instead of the more technically correct:
>
> String ROLE = OutputModule.class.getName();
IIRC the method above is the right approach to define a ROLE.
Giacomo
>
> ? Is there any reason for keeping said oddity around?
>
> Regards,
> Sterling
>
> On Thu, 2002-08-01 at 22:14, Vadim Gritsenko wrote:
> > > From: Andrew Sterling Hanenkamp [mailto:sterling@hanenkamp.com]
> > >
> > > This is a very small update to the cocoon.roles file which has a typo
> > > for the output-modules role.
> >
> > Apparently, this typo was done in three other files too.
> >
> > Thanks for noting,
> >
> > Vadim
> >
> >
> > > (...input.OutputModuleSelector instead of
> > > ...output.OutputModuleSelector).
> > >
> > > Regards,
> > > Sterling
> > >
> > > Index: cocoon.roles
> > > ===================================================================
> > > RCS file:
> > > /home/cvspublic/xml-cocoon2/src/java/org/apache/cocoon/cocoon.roles,v
> > > retrieving revision 1.32
> > > diff -u -r1.32 cocoon.roles
> > > --- cocoon.roles 1 Jul 2002 08:21:09 -0000 1.32
> > > +++ cocoon.roles 1 Aug 2002 14:36:15 -0000
> > > @@ -195,7 +195,7 @@
> > > shorthand="input-modules"
> > >
> > > default-
> > >
> > class="org.apache.avalon.excalibur.component.ExcaliburComponentSelector"
> > />
> > >
> > > - <role
> > > name="org.apache.cocoon.components.modules.input.OutputModuleSelector"
> > > + <role
> > >
> > name="org.apache.cocoon.components.modules.output.OutputModuleSelector"
> > > shorthand="output-modules"
> > >
> > > default-
> > >
> > class="org.apache.avalon.excalibur.component.ExcaliburComponentSelector"
> > />
> > >
> > >
> > > --
> > > <>< ><> <>< ><> <>< ><> <>< ><> <>< ><> <>< ><> <>< ><> <>< ><> <><
> > ><>
> > > <>< ><>
> > > Andrew Sterling Hanenkamp
> > > http://Andrew.Sterling.Hanenkamp.com/
> > > sterling@hanenkamp.com / sterling@cis.ksu.edu
> > >
> > > Friends, there comes a time in every man's life where he has to look
> > > the
> > > potato of injustice right in the eye. -- Michael Richards,
> > > UHF
> > >
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> > For additional commands, email: cocoon-dev-help@xml.apache.org
> >
> >
>
---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org
RE: [PATCH] cocoon.roles is broken
Posted by Andrew Sterling Hanenkamp <st...@hanenkamp.com>.
So I just noticed a few minutes ago. My apologies for not being more
thorough. It appears deliberate. Can anyone tell me why one would
purposely set the role of OutputModule as:
String ROLE = "org.apache.cocoon.components.modules.input.OutputModule";
instead of the more technically correct:
String ROLE = OutputModule.class.getName();
? Is there any reason for keeping said oddity around?
Regards,
Sterling
On Thu, 2002-08-01 at 22:14, Vadim Gritsenko wrote:
> > From: Andrew Sterling Hanenkamp [mailto:sterling@hanenkamp.com]
> >
> > This is a very small update to the cocoon.roles file which has a typo
> > for the output-modules role.
>
> Apparently, this typo was done in three other files too.
>
> Thanks for noting,
>
> Vadim
>
>
> > (...input.OutputModuleSelector instead of
> > ...output.OutputModuleSelector).
> >
> > Regards,
> > Sterling
> >
> > Index: cocoon.roles
> > ===================================================================
> > RCS file:
> > /home/cvspublic/xml-cocoon2/src/java/org/apache/cocoon/cocoon.roles,v
> > retrieving revision 1.32
> > diff -u -r1.32 cocoon.roles
> > --- cocoon.roles 1 Jul 2002 08:21:09 -0000 1.32
> > +++ cocoon.roles 1 Aug 2002 14:36:15 -0000
> > @@ -195,7 +195,7 @@
> > shorthand="input-modules"
> >
> > default-
> >
> class="org.apache.avalon.excalibur.component.ExcaliburComponentSelector"
> />
> >
> > - <role
> > name="org.apache.cocoon.components.modules.input.OutputModuleSelector"
> > + <role
> >
> name="org.apache.cocoon.components.modules.output.OutputModuleSelector"
> > shorthand="output-modules"
> >
> > default-
> >
> class="org.apache.avalon.excalibur.component.ExcaliburComponentSelector"
> />
> >
> >
> > --
> > <>< ><> <>< ><> <>< ><> <>< ><> <>< ><> <>< ><> <>< ><> <>< ><> <><
> ><>
> > <>< ><>
> > Andrew Sterling Hanenkamp
> > http://Andrew.Sterling.Hanenkamp.com/
> > sterling@hanenkamp.com / sterling@cis.ksu.edu
> >
> > Friends, there comes a time in every man's life where he has to look
> > the
> > potato of injustice right in the eye. -- Michael Richards,
> > UHF
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> For additional commands, email: cocoon-dev-help@xml.apache.org
>
>
--
<>< ><> <>< ><> <>< ><> <>< ><> <>< ><> <>< ><> <>< ><> <>< ><> <>< ><>
<>< ><>
Andrew Sterling Hanenkamp
http://Andrew.Sterling.Hanenkamp.com/
sterling@hanenkamp.com / sterling@cis.ksu.edu
Friends, there comes a time in every man's life where he has to look
the
potato of injustice right in the eye. -- Michael Richards,
UHF
---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org
RE: [PATCH] cocoon.roles is broken
Posted by Vadim Gritsenko <va...@verizon.net>.
> From: Andrew Sterling Hanenkamp [mailto:sterling@hanenkamp.com]
>
> This is a very small update to the cocoon.roles file which has a typo
> for the output-modules role.
Apparently, this typo was done in three other files too.
Thanks for noting,
Vadim
> (...input.OutputModuleSelector instead of
> ...output.OutputModuleSelector).
>
> Regards,
> Sterling
>
> Index: cocoon.roles
> ===================================================================
> RCS file:
> /home/cvspublic/xml-cocoon2/src/java/org/apache/cocoon/cocoon.roles,v
> retrieving revision 1.32
> diff -u -r1.32 cocoon.roles
> --- cocoon.roles 1 Jul 2002 08:21:09 -0000 1.32
> +++ cocoon.roles 1 Aug 2002 14:36:15 -0000
> @@ -195,7 +195,7 @@
> shorthand="input-modules"
>
> default-
>
class="org.apache.avalon.excalibur.component.ExcaliburComponentSelector"
/>
>
> - <role
> name="org.apache.cocoon.components.modules.input.OutputModuleSelector"
> + <role
>
name="org.apache.cocoon.components.modules.output.OutputModuleSelector"
> shorthand="output-modules"
>
> default-
>
class="org.apache.avalon.excalibur.component.ExcaliburComponentSelector"
/>
>
>
> --
> <>< ><> <>< ><> <>< ><> <>< ><> <>< ><> <>< ><> <>< ><> <>< ><> <><
><>
> <>< ><>
> Andrew Sterling Hanenkamp
> http://Andrew.Sterling.Hanenkamp.com/
> sterling@hanenkamp.com / sterling@cis.ksu.edu
>
> Friends, there comes a time in every man's life where he has to look
> the
> potato of injustice right in the eye. -- Michael Richards,
> UHF
>
---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org