You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/08/20 17:29:57 UTC

[GitHub] [spark] viirya commented on a change in pull request #25499: [SPARK-28774] [SQL] Fix exchange reuse for columnar data

viirya commented on a change in pull request #25499: [SPARK-28774] [SQL] Fix exchange reuse for columnar data
URL: https://github.com/apache/spark/pull/25499#discussion_r315813454
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/execution/ExchangeSuite.scala
 ##########
 @@ -105,6 +120,17 @@ class ExchangeSuite extends SparkPlanTest with SharedSparkSession {
     assert(exchange5 sameResult exchange4)
   }
 
+  test ("Columnar exchange works") {
+    val df = spark.range(10)
+    val plan = df.queryExecution.executedPlan
+    assert(plan sameResult plan)
 
 Review comment:
   looks like a redundant assert?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org