You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by jongyoul <gi...@git.apache.org> on 2017/09/17 12:31:57 UTC
[GitHub] zeppelin pull request #2591: [HOTFIX] Forward compatibility of Note class
GitHub user jongyoul opened a pull request:
https://github.com/apache/zeppelin/pull/2591
[HOTFIX] Forward compatibility of Note class
### What is this PR for?
Solving inconsistency issue of Note's dateformat between branch-0.7 and master. It's related to #2272
### What type of PR is it?
[Hot Fix]
### Todos
* [x] - Support several dateformat for Note class
### What is the Jira issue?
* N/A
### How should this be tested?
* Sync with some remote repository
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jongyoul/zeppelin hotfix/note-json-forward-compatibility
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2591.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2591
----
commit 53add8394817ae3426496df4ebc13a16fdee7565
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2017-09-17T12:27:31Z
Hotfix for forward compatibility of Note.class
----
---
[GitHub] zeppelin issue #2591: [HOTFIX] Forward compatibility of Note class
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2591
@jongyoul Which code path use vanila gson for handling json ?
---
[GitHub] zeppelin issue #2591: [HOTFIX] Forward compatibility of Note class
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2591
@jongyoul I hit this issue before, I think just adding `yyyy-MM-dd HH:mm:ss.SSS` into `NotebookImportDeserializer` should be able to resolve this issue.
---
[GitHub] zeppelin issue #2591: [HOTFIX] Forward compatibility of Note class
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2591
Thanks @jongyoul
---
[GitHub] zeppelin issue #2591: [HOTFIX] Forward compatibility of Note class
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2591
Yes, if we use that gson, it can be solved. But there're several gson instances and used different one. I fixed it in order to use the same one to handle that type.
---
[GitHub] zeppelin issue #2591: [HOTFIX] Forward compatibility of Note class
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2591
@Leemoonsoo This is hotfix. Please test it and leave comments.
---
[GitHub] zeppelin pull request #2591: [HOTFIX] Forward compatibility of Note class
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul closed the pull request at:
https://github.com/apache/zeppelin/pull/2591
---
[GitHub] zeppelin issue #2591: [HOTFIX] Forward compatibility of Note class
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2591
Some code used only vanila gson for handling json.
---
[GitHub] zeppelin issue #2591: [HOTFIX] Forward compatibility of Note class
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2591
Merge if there's no more discussion
---
[GitHub] zeppelin issue #2591: [HOTFIX] Forward compatibility of Note class
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2591
@zjffdu I found S3,VFS,Zeppelinhub repo used different gson from Note. I know it's fixed in master but need to fix them in 0.7.x branch.
---