Re: cvs commit: httpd-2.0/server/mpm/worker fdqueue.c fdqueue.h worker.c

[Aaron Bannert <aa...@clove.org>]

On Thu, Mar 21, 2002 at 07:12:54PM -0000, trawick@apache.org wrote:
> trawick     02/03/21 11:12:54
> 
>   Modified:    .        CHANGES
>                server/mpm/worker fdqueue.c fdqueue.h worker.c
>   Log:
>   Don't drop connections during graceful restart.  Previously, worker
>   threads could exit even though there were connections waiting in the
>   queue.
>   
>   Now, for a graceful restart the worker threads won't exit until they
>   are told that the queue has been drained and no more connections will
>   ever be added.

Awesome!

Is ap_queue_interrupt_all() used anywhere externally anymore? Let's
just get rid of it in lieu of ap_queue_term().

-aaron

Re: cvs commit: httpd-2.0/server/mpm/worker fdqueue.c fdqueue.h worker.c

[Jeff Trawick <tr...@attglobal.net>]

Aaron Bannert <aa...@clove.org> writes:

> Is ap_queue_interrupt_all() used anywhere externally anymore? Let's
> just get rid of it in lieu of ap_queue_term().

That one is still used by worker MPM on the non-graceful shutdown
path.

On my first attempt to get this working I had a parameter to
ap_queue_term() which told it whether or not to nuke the queue before
waking up the threads in ap_queue_pop().  If that were implemented
again then on the non-graceful shutdown path we could call
ap_queue_term(nuke-the-queue) instead of ap_queue_interrupt_all(),
and then we wouldn't need to externalize ap_queue_interrupt_all().

-- 
Jeff Trawick | trawick@attglobal.net
Born in Roswell... married an alien...