You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/19 12:52:05 UTC

[GitHub] [flink] kl0u commented on a change in pull request #10251: [FLINK-14851][FLINK-14850] Implement Executors and wire them to the ContextEnvironment

kl0u commented on a change in pull request #10251: [FLINK-14851][FLINK-14850] Implement Executors and wire them to the ContextEnvironment
URL: https://github.com/apache/flink/pull/10251#discussion_r347904631
 
 

 ##########
 File path: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java
 ##########
 @@ -416,7 +416,9 @@ private void applyDescriptorOptionToConfig(final CommandLine commandLine, final
 		}
 
 		final String dynamicPropertiesEncoded = encodeDynamicProperties(commandLine);
-		configuration.setString(YarnConfigOptionsInternal.DYNAMIC_PROPERTIES, dynamicPropertiesEncoded);
+		if (dynamicPropertiesEncoded != null && !dynamicPropertiesEncoded.isEmpty()) {
 
 Review comment:
   This is not related to this PR, I agree, this is why it is marked as a hotifx.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services