You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/07/24 23:14:22 UTC
[GitHub] [couchdb] ArchangeGabriel opened a new pull request #3681: Fix typo for Spidermonkey 78
ArchangeGabriel opened a new pull request #3681:
URL: https://github.com/apache/couchdb/pull/3681
## Overview
While review current state of Spidermonkey support for packaging purposes, I’ve realized what seems to me like a typo.
## Testing recommendations
Not sure, I don’t exactly know what this code does, but it did not look right.
## Related Issues or Pull Requests
Was added in https://github.com/apache/couchdb/pull/3500
## Checklist
- [ ] Code is written and works correctly
- [ ] Changes are covered by tests
- [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
- [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] ArchangeGabriel commented on pull request #3681: Fix typo for Spidermonkey 78
Posted by GitBox <gi...@apache.org>.
ArchangeGabriel commented on pull request #3681:
URL: https://github.com/apache/couchdb/pull/3681#issuecomment-886123317
OK, thanks and sorry for the disturbance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] wohali closed pull request #3681: Fix typo for Spidermonkey 78
Posted by GitBox <gi...@apache.org>.
wohali closed pull request #3681:
URL: https://github.com/apache/couchdb/pull/3681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] ArchangeGabriel commented on pull request #3681: Fix typo for Spidermonkey 78
Posted by GitBox <gi...@apache.org>.
ArchangeGabriel commented on pull request #3681:
URL: https://github.com/apache/couchdb/pull/3681#issuecomment-886122658
Actually I see the folder does not exist, so maybe not a typo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] wohali commented on pull request #3681: Fix typo for Spidermonkey 78
Posted by GitBox <gi...@apache.org>.
wohali commented on pull request #3681:
URL: https://github.com/apache/couchdb/pull/3681#issuecomment-886123133
Not a typo, intentional - both versions of JS are supported by the same code in the code base.
Good eye, though!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org