You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@yunikorn.apache.org by "Weiwei Yang (Jira)" <ji...@apache.org> on 2021/06/09 04:49:00 UTC

[jira] [Commented] (YUNIKORN-592) Move test code out of utils.go

    [ https://issues.apache.org/jira/browse/YUNIKORN-592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359757#comment-17359757 ] 

Weiwei Yang commented on YUNIKORN-592:
--------------------------------------

hi [~avsamit6600] any updates for this issue?

> Move test code out of utils.go
> ------------------------------
>
>                 Key: YUNIKORN-592
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-592
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>          Components: shim - kubernetes
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Amit Sharma
>            Priority: Major
>              Labels: newbie
>             Fix For: 0.11
>
>
> The utils.go file is a mixture of test and production code. The test code does not belong in the utils file and needs to be factored out into a test file:
>  * K8sResource with NewK8sResourceList
>  * PodForTest
>  * NodeForTest



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org