You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "bhisevishal (via GitHub)" <gi...@apache.org> on 2023/04/18 00:06:52 UTC
[GitHub] [beam] bhisevishal opened a new pull request, #26313: Prevent hashmap growing too large. Improves performance for too many …
bhisevishal opened a new pull request, #26313:
URL: https://github.com/apache/beam/pull/26313
…Unique Keys cases.
Flush all key-values if map size reach to 12K entries + keep using LRU cache
Micro BenchMark Result: 5x to 6x improvement for uniqueKeys PrecombineGroupingTableBenchmark, Minor impact on other
End To End WordCount Pipeline: Approx 25% improvement
Before
Benchmark (distribution) (globallyWindowed) Mode Cnt Score Error Units
PrecombineGroupingTableBenchmark.sumIntegerBinaryCombine uniform true thrpt 15 52.584 ± 5.631 ops/s
PrecombineGroupingTableBenchmark.sumIntegerBinaryCombine uniform false thrpt 15 48.427 ± 4.090 ops/s
PrecombineGroupingTableBenchmark.sumIntegerBinaryCombine normal true thrpt 15 36.470 ± 3.498 ops/s
PrecombineGroupingTableBenchmark.sumIntegerBinaryCombine normal false thrpt 15 35.610 ± 0.940 ops/s
PrecombineGroupingTableBenchmark.sumIntegerBinaryCombine hotKey true thrpt 15 55.111 ± 2.996 ops/s
PrecombineGroupingTableBenchmark.sumIntegerBinaryCombine hotKey false thrpt 15 49.423 ± 2.859 ops/s
PrecombineGroupingTableBenchmark.sumIntegerBinaryCombine uniqueKeys true thrpt 15 5.319 ± 0.655 ops/s
PrecombineGroupingTableBenchmark.sumIntegerBinaryCombine uniqueKeys false thrpt 15 5.094 ± 0.337 ops/s
After
Benchmark (distribution) (globallyWindowed) Mode Cnt Score Error Units
PrecombineGroupingTableBenchmark.sumIntegerBinaryCombine uniform true thrpt 15 52.442 ± 1.937 ops/s
PrecombineGroupingTableBenchmark.sumIntegerBinaryCombine uniform false thrpt 15 44.824 ± 3.504 ops/s
PrecombineGroupingTableBenchmark.sumIntegerBinaryCombine normal true thrpt 15 33.719 ± 2.688 ops/s
PrecombineGroupingTableBenchmark.sumIntegerBinaryCombine normal false thrpt 15 30.081 ± 1.278 ops/s
PrecombineGroupingTableBenchmark.sumIntegerBinaryCombine hotKey true thrpt 15 51.839 ± 3.127 ops/s
PrecombineGroupingTableBenchmark.sumIntegerBinaryCombine hotKey false thrpt 15 46.264 ± 1.691 ops/s
PrecombineGroupingTableBenchmark.sumIntegerBinaryCombine uniqueKeys true thrpt 15 32.422 ± 1.269 ops/s
PrecombineGroupingTableBenchmark.sumIntegerBinaryCombine uniqueKeys false thrpt 15 29.210 ± 1.757 ops/s
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bhisevishal commented on pull request #26313: Prevent hashmap growing too large. Improves performance for too many …
Posted by "bhisevishal (via GitHub)" <gi...@apache.org>.
bhisevishal commented on PR #26313:
URL: https://github.com/apache/beam/pull/26313#issuecomment-1512264091
@kennknowles will you please review this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles merged pull request #26313: Prevent hashmap growing too large. Improves performance for too many Unique Keys cases.
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles merged PR #26313:
URL: https://github.com/apache/beam/pull/26313
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26313: Prevent hashmap growing too large. Improves performance for too many Unique Keys cases.
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26313:
URL: https://github.com/apache/beam/pull/26313#issuecomment-1515345794
I imagine later this value may be better dynamic, but this is a good improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26313: Prevent hashmap growing too large. Improves performance for too many Unique Keys cases.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26313:
URL: https://github.com/apache/beam/pull/26313#issuecomment-1512285537
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @Abacn for label java.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bhisevishal commented on pull request #26313: Prevent hashmap growing too large. Improves performance for too many …
Posted by "bhisevishal (via GitHub)" <gi...@apache.org>.
bhisevishal commented on PR #26313:
URL: https://github.com/apache/beam/pull/26313#issuecomment-1512264671
@robertwb Will you please review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org