You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Mike Percy <mp...@apache.org> on 2013/01/04 10:51:34 UTC
Review Request: FLUME-1820 - Should not be possible for RPC client to block
indefinitely on close()
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8814/
-----------------------------------------------------------
Review request for Flume.
Description
-------
Two-phase shutdown for RPC client thread pool instead of indefinite looping awaitShutdown calls.
This addresses bug FLUME-1820.
https://issues.apache.org/jira/browse/FLUME-1820
Diffs
-----
flume-ng-sdk/src/main/java/org/apache/flume/api/NettyAvroRpcClient.java bd116ff
Diff: https://reviews.apache.org/r/8814/diff/
Testing
-------
Unit tests pass.
Thanks,
Mike Percy
Re: Review Request: FLUME-1820 - Should not be possible for RPC client to
block indefinitely on close()
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8814/#review15082
-----------------------------------------------------------
Ship it!
Ship It!
- Hari Shreedharan
On Jan. 4, 2013, 10 a.m., Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8814/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2013, 10 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Two-phase shutdown for RPC client thread pool instead of indefinite looping awaitShutdown calls.
>
>
> This addresses bug FLUME-1820.
> https://issues.apache.org/jira/browse/FLUME-1820
>
>
> Diffs
> -----
>
> flume-ng-sdk/src/main/java/org/apache/flume/api/NettyAvroRpcClient.java bd116ff
>
> Diff: https://reviews.apache.org/r/8814/diff/
>
>
> Testing
> -------
>
> Unit tests pass.
>
>
> Thanks,
>
> Mike Percy
>
>
Re: Review Request: FLUME-1820 - Should not be possible for RPC client to
block indefinitely on close()
Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8814/
-----------------------------------------------------------
(Updated Jan. 4, 2013, 10 a.m.)
Review request for Flume.
Changes
-------
Small improvement to logging
Description
-------
Two-phase shutdown for RPC client thread pool instead of indefinite looping awaitShutdown calls.
This addresses bug FLUME-1820.
https://issues.apache.org/jira/browse/FLUME-1820
Diffs (updated)
-----
flume-ng-sdk/src/main/java/org/apache/flume/api/NettyAvroRpcClient.java bd116ff
Diff: https://reviews.apache.org/r/8814/diff/
Testing
-------
Unit tests pass.
Thanks,
Mike Percy