You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@stanbol.apache.org by "Olivier Grisel (JIRA)" <ji...@apache.org> on 2011/04/06 11:01:07 UTC
[jira] [Created] (STANBOL-147)
NamedEntityExtractionEnhancementEngine is not thread safe
NamedEntityExtractionEnhancementEngine is not thread safe
---------------------------------------------------------
Key: STANBOL-147
URL: https://issues.apache.org/jira/browse/STANBOL-147
Project: Stanbol
Issue Type: Bug
Reporter: Olivier Grisel
Assignee: Olivier Grisel
Under high concurrency, using the same mode instances in several threads can trigger NPEs. One should put the models into thread locals instead.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (STANBOL-147)
NamedEntityExtractionEnhancementEngine throws NPEs under high concurrency
load
Posted by "Olivier Grisel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/STANBOL-147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Grisel resolved STANBOL-147.
------------------------------------
Resolution: Fixed
fixed after upgrading to opennlp 1.5.1-incubating
> NamedEntityExtractionEnhancementEngine throws NPEs under high concurrency load
> ------------------------------------------------------------------------------
>
> Key: STANBOL-147
> URL: https://issues.apache.org/jira/browse/STANBOL-147
> Project: Stanbol
> Issue Type: Bug
> Reporter: Olivier Grisel
> Assignee: Olivier Grisel
> Attachments: STANBOL-147.diff
>
>
> Under high concurrency, using the same mode instances in several threads can trigger NPEs. One should put the models into thread locals instead.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (STANBOL-147)
NamedEntityExtractionEnhancementEngine is not thread safe
Posted by "Olivier Grisel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/STANBOL-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016312#comment-13016312 ]
Olivier Grisel commented on STANBOL-147:
----------------------------------------
Here is the stack trace:
org.apache.stanbol.enhancer.servicesapi.EngineException: 'NamedEntityExtractionEnhancementEngine' failed to process content item 'urn:content-item-sha1-f02f7417dc27e8ee38a2ae950b3d50523db2e5e6' with type 'text/plain': null
at org.apache.stanbol.enhancer.engines.opennlp.impl.NamedEntityExtractionEnhancementEngine.computeEnhancements(NamedEntityExtractionEnhancementEngine.java:180)
at org.apache.stanbol.enhancer.jobmanager.impl.InMemoryJobManager.enhanceContent(InMemoryJobManager.java:62)
at org.apache.stanbol.enhancer.jersey.resource.EnginesRootResource.enhanceAndBuildResponse(EnginesRootResource.java:163)
at org.apache.stanbol.enhancer.jersey.resource.EnginesRootResource.enhanceFromData(EnginesRootResource.java:155)
at sun.reflect.GeneratedMethodAccessor5.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:172)
at com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:67)
at com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:265)
at com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:83)
at com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:133)
at com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:71)
at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:996)
at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:947)
at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:938)
at com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:399)
at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:478)
at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:663)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
at org.apache.felix.http.base.internal.handler.ServletHandler.doHandle(ServletHandler.java:96)
at org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:79)
at org.apache.felix.http.base.internal.dispatch.ServletPipeline.handle(ServletPipeline.java:42)
at org.apache.felix.http.base.internal.dispatch.InvocationFilterChain.doFilter(InvocationFilterChain.java:49)
at org.apache.felix.http.base.internal.dispatch.HttpFilterChain.doFilter(HttpFilterChain.java:33)
at org.apache.felix.http.base.internal.dispatch.FilterPipeline.dispatch(FilterPipeline.java:48)
at org.apache.felix.http.base.internal.dispatch.Dispatcher.dispatch(Dispatcher.java:39)
at org.apache.felix.http.base.internal.DispatcherServlet.service(DispatcherServlet.java:67)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:390)
at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:765)
at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
at org.mortbay.jetty.Server.handle(Server.java:326)
at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
at org.mortbay.jetty.HttpConnection$RequestHandler.content(HttpConnection.java:943)
at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:756)
at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:218)
at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
at org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:410)
at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582)
Caused by: java.lang.NullPointerException
at opennlp.tools.util.Cache.put(Cache.java:134)
at opennlp.tools.util.featuregen.CachedFeatureGenerator.createFeatures(CachedFeatureGenerator.java:71)
at opennlp.tools.namefind.DefaultNameContextGenerator.getContext(DefaultNameContextGenerator.java:116)
at opennlp.tools.namefind.DefaultNameContextGenerator.getContext(DefaultNameContextGenerator.java:39)
at opennlp.tools.util.BeamSearch.bestSequences(BeamSearch.java:125)
at opennlp.tools.util.BeamSearch.bestSequence(BeamSearch.java:198)
at opennlp.tools.namefind.NameFinderME.find(NameFinderME.java:214)
at opennlp.tools.namefind.NameFinderME.find(NameFinderME.java:198)
at org.apache.stanbol.enhancer.engines.opennlp.impl.NamedEntityExtractionEnhancementEngine.extractNameOccurrences(NamedEntityExtractionEnhancementEngine.java:318)
at org.apache.stanbol.enhancer.engines.opennlp.impl.NamedEntityExtractionEnhancementEngine.findNamedEntities(NamedEntityExtractionEnhancementEngine.java:199)
at org.apache.stanbol.enhancer.engines.opennlp.impl.NamedEntityExtractionEnhancementEngine.computeEnhancements(NamedEntityExtractionEnhancementEngine.java:177)
... 41 more
> NamedEntityExtractionEnhancementEngine is not thread safe
> ---------------------------------------------------------
>
> Key: STANBOL-147
> URL: https://issues.apache.org/jira/browse/STANBOL-147
> Project: Stanbol
> Issue Type: Bug
> Reporter: Olivier Grisel
> Assignee: Olivier Grisel
>
> Under high concurrency, using the same mode instances in several threads can trigger NPEs. One should put the models into thread locals instead.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (STANBOL-147)
NamedEntityExtractionEnhancementEngine is not thread safe
Posted by "Olivier Grisel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/STANBOL-147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Grisel updated STANBOL-147:
-----------------------------------
Attachment: STANBOL-147.diff
For reference, here is the patch I used to test with the development version of OpenNLP
> NamedEntityExtractionEnhancementEngine is not thread safe
> ---------------------------------------------------------
>
> Key: STANBOL-147
> URL: https://issues.apache.org/jira/browse/STANBOL-147
> Project: Stanbol
> Issue Type: Bug
> Reporter: Olivier Grisel
> Assignee: Olivier Grisel
> Attachments: STANBOL-147.diff
>
>
> Under high concurrency, using the same mode instances in several threads can trigger NPEs. One should put the models into thread locals instead.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (STANBOL-147)
NamedEntityExtractionEnhancementEngine is not thread safe
Posted by "Olivier Grisel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/STANBOL-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016313#comment-13016313 ]
Olivier Grisel commented on STANBOL-147:
----------------------------------------
Actually I am not 100% sure this is a thread safeness issue since the NameFinderME instances are distinct for each thread.
> NamedEntityExtractionEnhancementEngine is not thread safe
> ---------------------------------------------------------
>
> Key: STANBOL-147
> URL: https://issues.apache.org/jira/browse/STANBOL-147
> Project: Stanbol
> Issue Type: Bug
> Reporter: Olivier Grisel
> Assignee: Olivier Grisel
>
> Under high concurrency, using the same mode instances in several threads can trigger NPEs. One should put the models into thread locals instead.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (STANBOL-147)
NamedEntityExtractionEnhancementEngine throws NPEs under high concurrency
load
Posted by "Olivier Grisel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/STANBOL-147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Grisel updated STANBOL-147:
-----------------------------------
Summary: NamedEntityExtractionEnhancementEngine throws NPEs under high concurrency load (was: NamedEntityExtractionEnhancementEngine is not thread safe)
> NamedEntityExtractionEnhancementEngine throws NPEs under high concurrency load
> ------------------------------------------------------------------------------
>
> Key: STANBOL-147
> URL: https://issues.apache.org/jira/browse/STANBOL-147
> Project: Stanbol
> Issue Type: Bug
> Reporter: Olivier Grisel
> Assignee: Olivier Grisel
> Attachments: STANBOL-147.diff
>
>
> Under high concurrency, using the same mode instances in several threads can trigger NPEs. One should put the models into thread locals instead.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (STANBOL-147)
NamedEntityExtractionEnhancementEngine is not thread safe
Posted by "Olivier Grisel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/STANBOL-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017035#comment-13017035 ]
Olivier Grisel commented on STANBOL-147:
----------------------------------------
By upgrading Stanbol to use the current trunk of OpenNLP the issue disappears. As soon as OpenNLP 1.5.1 is out we should upgrade.
> NamedEntityExtractionEnhancementEngine is not thread safe
> ---------------------------------------------------------
>
> Key: STANBOL-147
> URL: https://issues.apache.org/jira/browse/STANBOL-147
> Project: Stanbol
> Issue Type: Bug
> Reporter: Olivier Grisel
> Assignee: Olivier Grisel
> Attachments: STANBOL-147.diff
>
>
> Under high concurrency, using the same mode instances in several threads can trigger NPEs. One should put the models into thread locals instead.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira