You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hivemall.apache.org by aajisaka <gi...@git.apache.org> on 2017/12/26 21:10:22 UTC
[GitHub] incubator-hivemall pull request #128: [HIVEMALL-164] Include the LICENSE and...
GitHub user aajisaka opened a pull request:
https://github.com/apache/incubator-hivemall/pull/128
[HIVEMALL-164] Include the LICENSE and NOTICE files of Apache Hivemall project into the jar files
## What changes were proposed in this pull request?
* Before: `mvn install` automatically creates LICENSE and NOTICE files and bundles them into jar files
* After: `mvn install` automatically bundles the project's own LICENSE and NOTICES files into jar files
## What type of PR is it?
Improvement
## What is the Jira issue?
https://issues.apache.org/jira/browse/HIVEMALL-164
## How was this patch tested?
Manually tested
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aajisaka/incubator-hivemall HIVEMALL-164
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hivemall/pull/128.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #128
----
commit d6f099b88834c8203989188492613f758ec6ca5e
Author: Akira Ajisaka <aa...@...>
Date: 2017-12-26T21:00:35Z
[HIVEMALL-164] Include the LICENSE and NOTICE files of Apache Hivemall project into the jar files.
----
---
[GitHub] incubator-hivemall issue #128: [HIVEMALL-164] Include the LICENSE and NOTICE...
Posted by aajisaka <gi...@git.apache.org>.
Github user aajisaka commented on the issue:
https://github.com/apache/incubator-hivemall/pull/128
build failure:
```
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-remote-resources-plugin:1.5:process (process-resource-bundles) on project hivemall: Execution process-resource-bundles of goal org.apache.maven.plugins:maven-remote-resources-plugin:1.5:process failed: Plugin org.apache.maven.plugins:maven-remote-resources-plugin:1.5 or one of its dependencies could not be resolved: Failure to find org.apache.hivemall:hivemall-build-tools:jar:0.5.0-incubating-SNAPSHOT in http://repository.apache.org/snapshots was cached in the local repository, resolution will not be reattempted until the update interval of apache.snapshots has elapsed or updates are forced -> [Help 1]
```
This error occurred because hivemall-build-tools is used in the root module before compiling hivemall-build-tools. To fix this, creating an intermediate module (which is called hadoop-project module in Apache Hadoop) to use hivemall-build-tool via maven-remote-resources-plugin and move the modules under the intermediate module as follows:
```
hivemall module
|- hivemall-build-tools modules
\- *intermediate module*
|- hivemall-core module
|- hivemall-xgboost module
\- and so on...
```
If it is okay to move the existing modules, I'll update the PR.
---
[GitHub] incubator-hivemall pull request #128: [HIVEMALL-164] Include the LICENSE and...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-hivemall/pull/128
---
[GitHub] incubator-hivemall issue #128: [HIVEMALL-164] Include the LICENSE and NOTICE...
Posted by myui <gi...@git.apache.org>.
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/128
@aajisaka here is my solution. DEPENDENCIES file created by maven-remote-resources-plugin is missing though.
https://gist.github.com/myui/94af9ed1ca334422aa5fd078f60a673c
---
[GitHub] incubator-hivemall issue #128: [HIVEMALL-164] Include the LICENSE and NOTICE...
Posted by myui <gi...@git.apache.org>.
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/128
Another approach is use https://maven.apache.org/plugins/maven-resources-plugin/examples/copy-resources.html to copy NOTICE, LICENSE, DISCLAIMER to `target/classes/META-INF` for each module in/before compile phase.
---