You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/12 02:21:52 UTC
[GitHub] [incubator-nuttx] no1wudi opened a new pull request #5209: arch/risc-v: Refine riscv_vectors.S
no1wudi opened a new pull request #5209:
URL: https://github.com/apache/incubator-nuttx/pull/5209
## Summary
Remove duplicated file
## Impact
Refactor only
## Testing
CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5209: arch/risc-v: Refine riscv_vectors.S
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5209:
URL: https://github.com/apache/incubator-nuttx/pull/5209#discussion_r782842508
##########
File path: arch/risc-v/src/common/riscv_vectors.S
##########
@@ -23,15 +23,15 @@
****************************************************************************/
.section .text.vec
- .global __reset_vec
.global __trap_vec
+ .global __reset_vec
Review comment:
```suggestion
.section .text.vec
.global __reset_vec
.global __trap_vec
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5209: arch/risc-v: Refine riscv_vectors.S
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5209:
URL: https://github.com/apache/incubator-nuttx/pull/5209#discussion_r782841061
##########
File path: arch/risc-v/src/common/riscv_vectors.S
##########
@@ -23,15 +23,15 @@
****************************************************************************/
.section .text.vec
- .global __reset_vec
.global __trap_vec
+ .global __reset_vec
/****************************************************************************
* Name: __reset_vec
****************************************************************************/
-__reset_vec:
- jal __start
+ __reset_vec:
Review comment:
```suggestion
__reset_vec:
```
##########
File path: arch/risc-v/src/common/riscv_vectors.S
##########
@@ -23,15 +23,15 @@
****************************************************************************/
.section .text.vec
- .global __reset_vec
.global __trap_vec
+ .global __reset_vec
/****************************************************************************
* Name: __reset_vec
****************************************************************************/
-__reset_vec:
- jal __start
+ __reset_vec:
+ jal __start
Review comment:
```suggestion
jal __start
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #5209: arch/risc-v: Refine riscv_vectors.S
Posted by GitBox <gi...@apache.org>.
no1wudi commented on a change in pull request #5209:
URL: https://github.com/apache/incubator-nuttx/pull/5209#discussion_r782850525
##########
File path: arch/risc-v/src/common/riscv_vectors.S
##########
@@ -1,5 +1,5 @@
/****************************************************************************
- * arch/risc-v/src/fe310/fe310_vectors.S
+ * arch/risc-v/src/common/riscv_vectors.S
Review comment:
Oh , __reset_vec is used to keep the entry at start position at the flash, let's adjust the HEAD_ASRC to remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5209: arch/risc-v: Refine riscv_vectors.S
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5209:
URL: https://github.com/apache/incubator-nuttx/pull/5209#discussion_r782876157
##########
File path: arch/risc-v/src/rv32m1/Make.defs
##########
@@ -20,10 +20,10 @@
# Specify our HEAD assembly file. This will be linked as
# the first object file, so it will appear at address 0
-HEAD_ASRC = rv32m1_vectors.S
+HEAD_ASRC = rv32m1_head.S
# Specify our general Assembly files
-CHIP_ASRCS = rv32m1_head.S
+CMN_ASRCS = riscv_vectors.S
# Specify C code within the common directory to be included
CMN_CSRCS += riscv_initialize.c riscv_swint.c
Review comment:
Please remove extra space
##########
File path: arch/risc-v/src/fe310/Make.defs
##########
@@ -20,12 +20,10 @@
# Specify our HEAD assembly file. This will be linked as
# the first object file, so it will appear at address 0
-HEAD_ASRC = fe310_vectors.S
+HEAD_ASRC = fe310_head.S
# Specify our general Assembly files
-CHIP_ASRCS = fe310_head.S
-
-CMN_ASRCS += riscv_testset.S
+CMN_ASRCS += riscv_vectors.S riscv_testset.S
# Specify C code within the common directory to be included
CMN_CSRCS += riscv_initialize.c riscv_swint.c
Review comment:
Please remove extra space
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5209: arch/risc-v: Refine riscv_vectors.S
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5209:
URL: https://github.com/apache/incubator-nuttx/pull/5209#discussion_r782862452
##########
File path: arch/risc-v/src/common/riscv_vectors.S
##########
@@ -1,5 +1,5 @@
/****************************************************************************
- * arch/risc-v/src/fe310/fe310_vectors.S
+ * arch/risc-v/src/common/riscv_vectors.S
Review comment:
I'm asking because I saw
```
.section .vectors, "ax"
.option norvc
j exception_common /* 0 */
j exception_common /* 1 */
j exception_common /* 2 */
j exception_common /* 3 */
...
```
in `rv32m1_vectors.S`. Also `KEEP(*(.vectors))` is available in `boards/risc-v/rv32m1/rv32m1-vega/scripts/ld.script`, but I do not see where `.section .text.vec` is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #5209: arch/risc-v: Refine riscv_vectors.S
Posted by GitBox <gi...@apache.org>.
no1wudi commented on a change in pull request #5209:
URL: https://github.com/apache/incubator-nuttx/pull/5209#discussion_r782850525
##########
File path: arch/risc-v/src/common/riscv_vectors.S
##########
@@ -1,5 +1,5 @@
/****************************************************************************
- * arch/risc-v/src/fe310/fe310_vectors.S
+ * arch/risc-v/src/common/riscv_vectors.S
Review comment:
Oh , __reset_vec is used to keep the entry at start position in flash, let's adjust the HEAD_ASRC to remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #5209: arch/risc-v: Refine riscv_vectors.S
Posted by GitBox <gi...@apache.org>.
no1wudi commented on a change in pull request #5209:
URL: https://github.com/apache/incubator-nuttx/pull/5209#discussion_r782873166
##########
File path: arch/risc-v/src/common/riscv_vectors.S
##########
@@ -1,5 +1,5 @@
/****************************************************************************
- * arch/risc-v/src/fe310/fe310_vectors.S
+ * arch/risc-v/src/common/riscv_vectors.S
Review comment:
Yes, the `.vec` seems unused and can be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi commented on pull request #5209: arch/risc-v: Refine riscv_vectors.S
Posted by GitBox <gi...@apache.org>.
no1wudi commented on pull request #5209:
URL: https://github.com/apache/incubator-nuttx/pull/5209#issuecomment-1010616723
Force push to trigger CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5209: arch/risc-v: Refine riscv_vectors.S
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5209:
URL: https://github.com/apache/incubator-nuttx/pull/5209#discussion_r782843305
##########
File path: arch/risc-v/src/common/riscv_vectors.S
##########
@@ -1,5 +1,5 @@
/****************************************************************************
- * arch/risc-v/src/fe310/fe310_vectors.S
+ * arch/risc-v/src/common/riscv_vectors.S
Review comment:
I'm not sure if that matters, but just saw that some files had it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5209: arch/risc-v: Refine riscv_vectors.S
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5209:
URL: https://github.com/apache/incubator-nuttx/pull/5209#discussion_r782857761
##########
File path: arch/risc-v/src/c906/Make.defs
##########
@@ -20,12 +20,10 @@
# Specify our HEAD assembly file. This will be linked as
# the first object file, so it will appear at address 0
-HEAD_ASRC = c906_vectors.S
+HEAD_ASRC = c906_head.S
# Specify our general Assembly files
-CHIP_ASRCS = c906_head.S
-
-CMN_ASRCS += riscv_testset.S
+CMN_ASRCS += riscv_vectors.S riscv_testset.S
# Specify C code within the common directory to be included
CMN_CSRCS += riscv_initialize.c riscv_swint.c
Review comment:
Please remove extra space in this block as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5209: arch/risc-v: Refine riscv_vectors.S
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5209:
URL: https://github.com/apache/incubator-nuttx/pull/5209#discussion_r782858171
##########
File path: arch/risc-v/src/qemu-rv32/Make.defs
##########
@@ -23,9 +23,7 @@
HEAD_ASRC = qemu_rv32_head.S
# Specify our general Assembly files
-CHIP_ASRCS = qemu_rv32_vectors.S
-
-CMN_ASRCS += riscv_testset.S
+CMN_ASRCS += riscv_vectors.S riscv_testset.S
# Specify C code within the common directory to be included
CMN_CSRCS += riscv_initialize.c riscv_swint.c
Review comment:
Please remove extra space in this block as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5209: arch/risc-v: Refine riscv_vectors.S
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5209:
URL: https://github.com/apache/incubator-nuttx/pull/5209#discussion_r782865221
##########
File path: arch/risc-v/src/common/riscv_vectors.S
##########
@@ -23,15 +23,15 @@
****************************************************************************/
.section .text.vec
- .global __reset_vec
.global __trap_vec
+ .global __reset_vec
/****************************************************************************
* Name: __reset_vec
****************************************************************************/
-__reset_vec:
- jal __start
+ __reset_vec:
+ jal __start
Review comment:
is missing again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5209: arch/risc-v: Refine riscv_vectors.S
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5209:
URL: https://github.com/apache/incubator-nuttx/pull/5209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5209: arch/risc-v: Refine riscv_vectors.S
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5209:
URL: https://github.com/apache/incubator-nuttx/pull/5209#discussion_r782800139
##########
File path: arch/risc-v/src/common/riscv_vectors.S
##########
@@ -1,5 +1,5 @@
/****************************************************************************
- * arch/risc-v/src/fe310/fe310_vectors.S
+ * arch/risc-v/src/common/riscv_vectors.S
Review comment:
Why `.global __reset_vec` and `__reset_vec` implementation is removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5209: arch/risc-v: Refine riscv_vectors.S
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5209:
URL: https://github.com/apache/incubator-nuttx/pull/5209#discussion_r782800139
##########
File path: arch/risc-v/src/common/riscv_vectors.S
##########
@@ -1,5 +1,5 @@
/****************************************************************************
- * arch/risc-v/src/fe310/fe310_vectors.S
+ * arch/risc-v/src/common/riscv_vectors.S
Review comment:
Why we do not have `.global __reset_vec` and `__reset_vec` implementation is removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5209: arch/risc-v: Refine riscv_vectors.S
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5209:
URL: https://github.com/apache/incubator-nuttx/pull/5209#discussion_r782881076
##########
File path: arch/risc-v/src/common/riscv_vectors.S
##########
@@ -1,5 +1,5 @@
/****************************************************************************
- * arch/risc-v/src/fe310/fe310_vectors.S
+ * arch/risc-v/src/common/riscv_vectors.S
Review comment:
Probably will need to clean-up linker scripts for corresponding boards as well in a separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org