[GitHub] gaborgsomogyi edited a comment on issue #23735: [SPARK-26801][SQL] Read avro types other than record

[GitBox <gi...@apache.org>]

gaborgsomogyi edited a comment on issue #23735: [SPARK-26801][SQL] Read avro types other than record
URL: https://github.com/apache/spark/pull/23735#issuecomment-463178312
 
 
   My comment is more like targeting the tests. Let's say something is changing in the format. There are existing tests which use old binary avro files. Someone should sit down and from old files get the json format, reconvert with the new one and commit things again. The more I'm thinking about it the more I think it would end up more robust tests when generating these data.
   
   I've just checked the json part and agree with @HyukjinKwon, it's weird. What would be the use-case end-to-end from user perspective?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org