You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/11 09:58:07 UTC
[GitHub] [skywalking-python] cooolr opened a new pull request #150: [plugin] pymongo compatible with mongodb cluster
cooolr opened a new pull request #150:
URL: https://github.com/apache/skywalking-python/pull/150
replace the `this.collection.database.client.address` with the `this.collection.database.client.nodes` to be compatible with the mongodb cluster
<!-- Uncomment the following checklist WHEN AND ONLY WHEN you're adding a new plugin -->
<!--
- [ ] Add a test case for the new plugin
- [ ] Add a component id in [the main repo](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml#L415)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
- [ ] Rebuild the `requirements.txt` by running `tools/env/build_requirements_(linux|windows).sh`
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Humbertzhang commented on a change in pull request #150: [plugin] pymongo compatible with mongodb cluster
Posted by GitBox <gi...@apache.org>.
Humbertzhang commented on a change in pull request #150:
URL: https://github.com/apache/skywalking-python/pull/150#discussion_r686990163
##########
File path: skywalking/plugins/sw_pymongo.py
##########
@@ -101,8 +101,8 @@ def inject_bulk_write(_Bulk, bulk_op_map):
_execute = _Bulk.execute
def _sw_execute(this: _Bulk, *args, **kwargs):
- address = this.collection.database.client.address
- peer = "%s:%s" % address
+ nodes = this.collection.database.client.nodes
Review comment:
I looked at it and the answer is yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 commented on a change in pull request #150: [plugin] pymongo compatible with mongodb cluster
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #150:
URL: https://github.com/apache/skywalking-python/pull/150#discussion_r686688922
##########
File path: skywalking/plugins/sw_pymongo.py
##########
@@ -101,8 +101,8 @@ def inject_bulk_write(_Bulk, bulk_op_map):
_execute = _Bulk.execute
def _sw_execute(this: _Bulk, *args, **kwargs):
- address = this.collection.database.client.address
- peer = "%s:%s" % address
+ nodes = this.collection.database.client.nodes
Review comment:
So when the MongoDB is in single-node mode, the `this.collection.database.client.nodes` will also contain one element?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 merged pull request #150: [plugin] pymongo compatible with mongodb cluster
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #150:
URL: https://github.com/apache/skywalking-python/pull/150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org