You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/05/24 09:03:00 UTC
[GitHub] [incubator-inlong] GanfengTan opened a new pull request, #4348: [INLONG-4346][Sort] Enhance upsert capability for SqlServer
GanfengTan opened a new pull request, #4348:
URL: https://github.com/apache/incubator-inlong/pull/4348
Enhance upsert capability for SqlServer
Fixes #4346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] EMsnap commented on a diff in pull request #4348: [INLONG-4346][Sort] Enhance upsert capability for SqlServer
Posted by GitBox <gi...@apache.org>.
EMsnap commented on code in PR #4348:
URL: https://github.com/apache/incubator-inlong/pull/4348#discussion_r880460380
##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/node/load/SqlServerLoadNode.java:
##########
@@ -46,20 +46,23 @@ public class SqlServerLoadNode extends LoadNode implements Serializable {
private static final long serialVersionUID = 3083735489161823965L;
/**
- * jdbc:sqlserver://host:port
+ * jdbc:sqlserver://host:port;databaseName=database
Review Comment:
why ; here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] EMsnap merged pull request #4348: [INLONG-4346][Sort] Enhance upsert capability for SqlServer
Posted by GitBox <gi...@apache.org>.
EMsnap merged PR #4348:
URL: https://github.com/apache/incubator-inlong/pull/4348
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org