You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/05/11 00:36:55 UTC
[GitHub] [incubator-pinot] codecov-io commented on issue #4198: Enhance the
support for BYTES data type
codecov-io commented on issue #4198: Enhance the support for BYTES data type
URL: https://github.com/apache/incubator-pinot/pull/4198#issuecomment-491464486
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4198?src=pr&el=h1) Report
> Merging [#4198](https://codecov.io/gh/apache/incubator-pinot/pull/4198?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/18d628b8fda8cf27c58854b64b8d4ee177c5334b?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `64.16%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4198?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4198 +/- ##
============================================
+ Coverage 67.16% 67.19% +0.02%
Complexity 20 20
============================================
Files 1034 1035 +1
Lines 51491 51395 -96
Branches 7214 7194 -20
============================================
- Hits 34585 34535 -50
+ Misses 14520 14498 -22
+ Partials 2386 2362 -24
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4198?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...re/realtime/impl/dictionary/MutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4198/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...e/impl/dictionary/BaseOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4198/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvQmFzZU9uSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `90.9% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../impl/dictionary/BaseOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4198/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvQmFzZU9mZkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `83.92% <ø> (+2.89%)` | `0 <0> (ø)` | :arrow_down: |
| [...not/core/segment/index/readers/BaseDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4198/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L3JlYWRlcnMvQmFzZURpY3Rpb25hcnkuamF2YQ==) | `53.12% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ection/iterator/StringSelectionColumnIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4198/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9zZWxlY3Rpb24vaXRlcmF0b3IvU3RyaW5nU2VsZWN0aW9uQ29sdW1uSXRlcmF0b3IuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...che/pinot/core/util/FixedIntArrayOffHeapIdMap.java](https://codecov.io/gh/apache/incubator-pinot/pull/4198/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS91dGlsL0ZpeGVkSW50QXJyYXlPZmZIZWFwSWRNYXAuamF2YQ==) | `79.48% <0%> (-2.1%)` | `0 <0> (ø)` | |
| [...or/SelectionSingleValueColumnWithDictIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4198/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9zZWxlY3Rpb24vaXRlcmF0b3IvU2VsZWN0aW9uU2luZ2xlVmFsdWVDb2x1bW5XaXRoRGljdEl0ZXJhdG9yLmphdmE=) | `77.77% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...e/impl/dictionary/LongOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4198/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvTG9uZ09uSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `91.3% <100%> (+2.41%)` | `0 <0> (ø)` | :arrow_down: |
| [...apache/pinot/common/utils/primitive/ByteArray.java](https://codecov.io/gh/apache/incubator-pinot/pull/4198/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvcHJpbWl0aXZlL0J5dGVBcnJheS5qYXZh) | `76.92% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...tion/groupby/DictionaryBasedGroupKeyGenerator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4198/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9ncm91cGJ5L0RpY3Rpb25hcnlCYXNlZEdyb3VwS2V5R2VuZXJhdG9yLmphdmE=) | `96.84% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| ... and [55 more](https://codecov.io/gh/apache/incubator-pinot/pull/4198/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4198?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4198?src=pr&el=footer). Last update [18d628b...791f804](https://codecov.io/gh/apache/incubator-pinot/pull/4198?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org