You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2017/03/23 00:31:32 UTC

[Impala-ASF-CR] IMPALA-4859: Push down IS NULL / IS NOT NULL to Kudu

Joe McDonnell has posted comments on this change.

Change subject: IMPALA-4859: Push down IS NULL / IS NOT NULL to Kudu
......................................................................


Patch Set 2:

(1 comment)

Added end-to-end tests

http://gerrit.cloudera.org:8080/#/c/5958/2/testdata/workloads/functional-planner/queries/PlannerTest/kudu-selectivity.test
File testdata/workloads/functional-planner/queries/PlannerTest/kudu-selectivity.test:

Line 152:      predicates: CAST(date_string_col AS TINYINT) IS NULL
> can move this into the query above, so we have one query with all the cases
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c96fec8d41f77222879c0ffdd6940b168e47e65
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-HasComments: Yes