You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/04/23 08:53:04 UTC

[GitHub] [flink] carryxyh opened a new pull request #8243: [FLINK-12299] ExecutionConfig#setAutoWatermarkInterval should check param(interval should not less than zero)

carryxyh opened a new pull request #8243: [FLINK-12299] ExecutionConfig#setAutoWatermarkInterval should check param(interval should not less than zero)
URL: https://github.com/apache/flink/pull/8243
 
 
   ## What is the purpose of the change
   We should check autowatermarkinterval field.
   
   In any scenario, `autoWatermarkInterval` should not be less than or equal to zero.
   
   First of all, this does not correspond to the meaning of `autoWatermarkInterval`.
   
   Second, in the case where `autoWatermarkInterval` is less than 0, we will not be able to register ourselves in `TimestampsAndPeriodicWatermarksOperator#open`, which will result in the water level of this stream being kept at the lowest level.
   
   
   ## Brief change log
   add check to ExecutionConfig#setAutoWatermarkInterval's param
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
   no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? ( no)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services