You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/06/21 05:50:01 UTC

[GitHub] [incubator-yunikorn-web] yangwwei commented on a change in pull request #40: YUNIKORN-233: Change default pagesize of datatable in yunikorn-web to 10

yangwwei commented on a change in pull request #40:
URL: https://github.com/apache/incubator-yunikorn-web/pull/40#discussion_r443184487



##########
File path: src/app/components/nodes-view/nodes-view.component.ts
##########
@@ -111,7 +111,7 @@ export class NodesViewComponent implements OnInit {
     }
   }
 
-  onPaginatorChanged(page: PageEvent) {
+  onPaginatorChanged() {

Review comment:
       hi @akhilpb001 
   
   The rest of the changes are straightforward, but for this one. I just want to make sure this is intentional, is it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org