You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "ChengJie1053 (via GitHub)" <gi...@apache.org> on 2023/11/13 12:48:06 UTC
[PR] [benchmark] CpuMetric code optimization [incubator-paimon]
ChengJie1053 opened a new pull request, #2308:
URL: https://github.com/apache/incubator-paimon/pull/2308
`host` is of type string, replacing `Objects.equals` with `StringUtils.equals`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [benchmark] benchmark module code optimization [incubator-paimon]
Posted by "ChengJie1053 (via GitHub)" <gi...@apache.org>.
ChengJie1053 commented on PR #2308:
URL: https://github.com/apache/incubator-paimon/pull/2308#issuecomment-1815736630
> Can you just keep
> 3. Removes excess ExecutionException
> 4. Extract the closeReader
Ok, thanks for reviewing the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [benchmark] benchmark module code optimization [incubator-paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #2308:
URL: https://github.com/apache/incubator-paimon/pull/2308#issuecomment-1815694396
Can you just keep
3. Removes excess ExecutionException
4. Extract the closeReader
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [benchmark] benchmark module code optimization [incubator-paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #2308:
URL: https://github.com/apache/incubator-paimon/pull/2308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org