You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/05/28 06:33:36 UTC
[GitHub] [hbase] bsglz opened a new pull request #1797: HBASE-24451 Remove the HasThread because the related bug had been fix…
bsglz opened a new pull request #1797:
URL: https://github.com/apache/hbase/pull/1797
…ed since jdk7
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani merged pull request #1797: HBASE-24451 Remove the HasThread because the related bug had been fix…
Posted by GitBox <gi...@apache.org>.
virajjasani merged pull request #1797:
URL: https://github.com/apache/hbase/pull/1797
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #1797: HBASE-24451 Remove the HasThread because the related bug had been fix…
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1797:
URL: https://github.com/apache/hbase/pull/1797#discussion_r432283958
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
##########
@@ -122,9 +121,9 @@ public SplitLogManager(MasterServices master, Configuration conf)
throws IOException {
this.server = master;
this.conf = conf;
- // Get Server Thread name. Sometimes the Server is mocked so may not implement HasThread.
+ // Get Server Thread name. Sometimes the Server is mocked so may not implement Thread.
// For example, in tests.
- String name = master instanceof HasThread? ((HasThread)master).getName():
+ String name = master instanceof Thread? ((Thread)master).getName():
Review comment:
We should not worry about mocked objects. Ideally, we can provide `getName()` default implementation in `MasterServices` and `HMaster` specifically can implement `getName()` as `Thread.getName()`, that way here the caller will just call: `String name = master.getName();`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bsglz commented on pull request #1797: HBASE-24451 Remove the HasThread because the related bug had been fix…
Posted by GitBox <gi...@apache.org>.
bsglz commented on pull request #1797:
URL: https://github.com/apache/hbase/pull/1797#issuecomment-635785499
The last ut failture seems not related to this PR, could anyone help to merge it?
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #1797: HBASE-24451 Remove the HasThread because the related bug had been fix…
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1797:
URL: https://github.com/apache/hbase/pull/1797#discussion_r431674845
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
##########
@@ -1472,7 +1470,7 @@ private void waitOnAllRegionsToClose(final boolean abort) {
}
}
- private static boolean sleep(long millis) {
+ private static boolean sleeps(long millis) {
Review comment:
`sleep` is good enough right? why `sleeps`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #1797: HBASE-24451 Remove the HasThread because the related bug had been fix…
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1797:
URL: https://github.com/apache/hbase/pull/1797#discussion_r432290954
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
##########
@@ -122,9 +121,9 @@ public SplitLogManager(MasterServices master, Configuration conf)
throws IOException {
this.server = master;
this.conf = conf;
- // Get Server Thread name. Sometimes the Server is mocked so may not implement HasThread.
+ // Get Server Thread name. Sometimes the Server is mocked so may not implement Thread.
// For example, in tests.
- String name = master instanceof HasThread? ((HasThread)master).getName():
+ String name = master instanceof Thread? ((Thread)master).getName():
Review comment:
Thanks @bsglz
I just triggered one build. Let it go through and one result is out, will merge the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bsglz commented on a change in pull request #1797: HBASE-24451 Remove the HasThread because the related bug had been fix…
Posted by GitBox <gi...@apache.org>.
bsglz commented on a change in pull request #1797:
URL: https://github.com/apache/hbase/pull/1797#discussion_r432238002
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
##########
@@ -122,9 +121,9 @@ public SplitLogManager(MasterServices master, Configuration conf)
throws IOException {
this.server = master;
this.conf = conf;
- // Get Server Thread name. Sometimes the Server is mocked so may not implement HasThread.
+ // Get Server Thread name. Sometimes the Server is mocked so may not implement Thread.
// For example, in tests.
- String name = master instanceof HasThread? ((HasThread)master).getName():
+ String name = master instanceof Thread? ((Thread)master).getName():
Review comment:
Seems still needed, since the master here maybe a mocked one.
eg: DummyMasterServices in TestSplitLogManager, it extends MockNoopMasterServices which implement MasterServices, but does not extends Thread.
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1797: HBASE-24451 Remove the HasThread because the related bug had been fix…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1797:
URL: https://github.com/apache/hbase/pull/1797#issuecomment-635415873
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 54s | Docker mode activated. |
| -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 42s | master passed |
| +1 :green_heart: | compile | 1m 46s | master passed |
| +1 :green_heart: | shadedjars | 6m 57s | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 17s | hbase-common in master failed. |
| -0 :warning: | javadoc | 0m 45s | hbase-server in master failed. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 46s | the patch passed |
| +1 :green_heart: | compile | 1m 45s | the patch passed |
| +1 :green_heart: | javac | 1m 45s | the patch passed |
| +1 :green_heart: | shadedjars | 6m 58s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 18s | hbase-common in the patch failed. |
| -0 :warning: | javadoc | 0m 47s | hbase-server in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 47s | hbase-common in the patch passed. |
| -1 :x: | unit | 137m 26s | hbase-server in the patch failed. |
| | | 172m 2s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1797 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux fa19b9b68ccb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 79d56499ca |
| Default Java | 2020-01-14 |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/3/testReport/ |
| Max. process+thread count | 3686 (vs. ulimit of 12500) |
| modules | C: hbase-common hbase-server U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/3/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1797: HBASE-24451 Remove the HasThread because the related bug had been fix…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1797:
URL: https://github.com/apache/hbase/pull/1797#issuecomment-635157894
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 5s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 54s | master passed |
| +1 :green_heart: | checkstyle | 1m 40s | master passed |
| +1 :green_heart: | spotbugs | 2m 50s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 39s | the patch passed |
| -0 :warning: | checkstyle | 1m 15s | hbase-server: The patch generated 1 new + 252 unchanged - 1 fixed = 253 total (was 253) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 12m 6s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. |
| -1 :x: | spotbugs | 2m 17s | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 21s | The patch does not generate ASF License warnings. |
| | | 38m 43s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:hbase-server |
| | new org.apache.hadoop.hbase.io.hfile.LruBlockCache(long, long, boolean, int, float, int, float, float, float, float, float, float, boolean, long) invokes org.apache.hadoop.hbase.io.hfile.LruBlockCache$EvictionThread.start() At LruBlockCache.java:float, int, float, float, float, float, float, float, boolean, long) invokes org.apache.hadoop.hbase.io.hfile.LruBlockCache$EvictionThread.start() At LruBlockCache.java:[line 336] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1797 |
| Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle |
| uname | Linux 1bcb7061ced9 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 79d56499ca |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| spotbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/1/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html |
| Max. process+thread count | 84 (vs. ulimit of 12500) |
| modules | C: hbase-common hbase-server U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/1/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1797: HBASE-24451 Remove the HasThread because the related bug had been fix…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1797:
URL: https://github.com/apache/hbase/pull/1797#issuecomment-635813135
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 37s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 11s | master passed |
| +1 :green_heart: | checkstyle | 1m 35s | master passed |
| +1 :green_heart: | spotbugs | 2m 44s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 28s | the patch passed |
| -0 :warning: | checkstyle | 1m 11s | hbase-server: The patch generated 1 new + 252 unchanged - 1 fixed = 253 total (was 253) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | hadoopcheck | 11m 27s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. |
| +1 :green_heart: | spotbugs | 2m 59s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. |
| | | 37m 6s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.10 Server=19.03.10 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/5/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1797 |
| Optional Tests | dupname asflicense spotbugs xml hadoopcheck hbaseanti checkstyle |
| uname | Linux 95eea9ab9595 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / fe1fc25fba |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| Max. process+thread count | 94 (vs. ulimit of 12500) |
| modules | C: hbase-common hbase-server U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/5/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bsglz commented on a change in pull request #1797: HBASE-24451 Remove the HasThread because the related bug had been fix…
Posted by GitBox <gi...@apache.org>.
bsglz commented on a change in pull request #1797:
URL: https://github.com/apache/hbase/pull/1797#discussion_r432408736
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
##########
@@ -122,9 +121,9 @@ public SplitLogManager(MasterServices master, Configuration conf)
throws IOException {
this.server = master;
this.conf = conf;
- // Get Server Thread name. Sometimes the Server is mocked so may not implement HasThread.
+ // Get Server Thread name. Sometimes the Server is mocked so may not implement Thread.
// For example, in tests.
- String name = master instanceof HasThread? ((HasThread)master).getName():
+ String name = master instanceof Thread? ((Thread)master).getName():
Review comment:
Not exactly.
- getName returns master/xxx:16000
- master.getServerName().toShortString() returns xxx:16000
So, will do it later.
Thanks.
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
##########
@@ -122,9 +121,9 @@ public SplitLogManager(MasterServices master, Configuration conf)
throws IOException {
this.server = master;
this.conf = conf;
- // Get Server Thread name. Sometimes the Server is mocked so may not implement HasThread.
+ // Get Server Thread name. Sometimes the Server is mocked so may not implement Thread.
// For example, in tests.
- String name = master instanceof HasThread? ((HasThread)master).getName():
+ String name = master instanceof Thread? ((Thread)master).getName():
Review comment:
Not exactly.
- getName returns master/xxx:16000
- master.getServerName().toShortString() returns xxx:16000
So, will do it later.
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #1797: HBASE-24451 Remove the HasThread because the related bug had been fix…
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1797:
URL: https://github.com/apache/hbase/pull/1797#discussion_r432284673
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
##########
@@ -122,9 +121,9 @@ public SplitLogManager(MasterServices master, Configuration conf)
throws IOException {
this.server = master;
this.conf = conf;
- // Get Server Thread name. Sometimes the Server is mocked so may not implement HasThread.
+ // Get Server Thread name. Sometimes the Server is mocked so may not implement Thread.
// For example, in tests.
- String name = master instanceof HasThread? ((HasThread)master).getName():
+ String name = master instanceof Thread? ((Thread)master).getName():
Review comment:
However, there is no harm w/o this change as Stack said. Maybe good to take this clean-up in separate Jira if you would like.
Will merge this PR in a while.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bsglz commented on a change in pull request #1797: HBASE-24451 Remove the HasThread because the related bug had been fix…
Posted by GitBox <gi...@apache.org>.
bsglz commented on a change in pull request #1797:
URL: https://github.com/apache/hbase/pull/1797#discussion_r432238067
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
##########
@@ -1908,9 +1907,9 @@ protected void queueAssign(final RegionStateNode regionNode) {
}
private void startAssignmentThread() {
- // Get Server Thread name. Sometimes the Server is mocked so may not implement HasThread.
+ // Get Server Thread name. Sometimes the Server is mocked so may not implement Thread.
// For example, in tests.
- String name = master instanceof HasThread? ((HasThread)master).getName():
+ String name = master instanceof Thread? ((Thread)master).getName():
Review comment:
Ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1797: HBASE-24451 Remove the HasThread because the related bug had been fix…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1797:
URL: https://github.com/apache/hbase/pull/1797#issuecomment-635228202
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 30s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 11s | master passed |
| +1 :green_heart: | compile | 1m 28s | master passed |
| +1 :green_heart: | shadedjars | 5m 41s | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 19s | hbase-common in master failed. |
| -0 :warning: | javadoc | 0m 39s | hbase-server in master failed. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 59s | the patch passed |
| +1 :green_heart: | compile | 1m 31s | the patch passed |
| +1 :green_heart: | javac | 1m 31s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 46s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 18s | hbase-common in the patch failed. |
| -0 :warning: | javadoc | 0m 38s | hbase-server in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 23s | hbase-common in the patch passed. |
| -1 :x: | unit | 138m 9s | hbase-server in the patch failed. |
| | | 167m 19s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1797 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux f8990bcf065a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 79d56499ca |
| Default Java | 2020-01-14 |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/1/testReport/ |
| Max. process+thread count | 4234 (vs. ulimit of 12500) |
| modules | C: hbase-common hbase-server U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/1/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1797: HBASE-24451 Remove the HasThread because the related bug had been fix…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1797:
URL: https://github.com/apache/hbase/pull/1797#issuecomment-635917759
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 35s | Docker mode activated. |
| -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 15s | master passed |
| +1 :green_heart: | compile | 1m 25s | master passed |
| +1 :green_heart: | shadedjars | 6m 19s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 56s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 2s | the patch passed |
| +1 :green_heart: | compile | 1m 24s | the patch passed |
| +1 :green_heart: | javac | 1m 24s | the patch passed |
| +1 :green_heart: | shadedjars | 6m 29s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 58s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 35s | hbase-common in the patch passed. |
| -1 :x: | unit | 226m 40s | hbase-server in the patch failed. |
| | | 258m 22s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.10 Server=19.03.10 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1797 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux f0148a2f7dac 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / fe1fc25fba |
| Default Java | 1.8.0_232 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/5/testReport/ |
| Max. process+thread count | 2968 (vs. ulimit of 12500) |
| modules | C: hbase-common hbase-server U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/5/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #1797: HBASE-24451 Remove the HasThread because the related bug had been fix…
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1797:
URL: https://github.com/apache/hbase/pull/1797#discussion_r432402520
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
##########
@@ -122,9 +121,9 @@ public SplitLogManager(MasterServices master, Configuration conf)
throws IOException {
this.server = master;
this.conf = conf;
- // Get Server Thread name. Sometimes the Server is mocked so may not implement HasThread.
+ // Get Server Thread name. Sometimes the Server is mocked so may not implement Thread.
// For example, in tests.
- String name = master instanceof HasThread? ((HasThread)master).getName():
+ String name = master instanceof Thread? ((Thread)master).getName():
Review comment:
Yes, is should be fine. Does it match with `((Thread)master).getName()` exactly? If so, let's do it now, else later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1797: HBASE-24451 Remove the HasThread because the related bug had been fix…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1797:
URL: https://github.com/apache/hbase/pull/1797#issuecomment-635914266
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 35s | Docker mode activated. |
| -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 44s | master passed |
| +1 :green_heart: | compile | 1m 44s | master passed |
| +1 :green_heart: | shadedjars | 6m 35s | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 18s | hbase-common in master failed. |
| -0 :warning: | javadoc | 0m 48s | hbase-server in master failed. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 8s | the patch passed |
| +1 :green_heart: | compile | 2m 4s | the patch passed |
| +1 :green_heart: | javac | 2m 4s | the patch passed |
| +1 :green_heart: | shadedjars | 6m 58s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 17s | hbase-common in the patch failed. |
| -0 :warning: | javadoc | 0m 50s | hbase-server in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 17s | hbase-common in the patch passed. |
| -1 :x: | unit | 213m 13s | hbase-server in the patch failed. |
| | | 249m 17s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.10 Server=19.03.10 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1797 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 267040b46844 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / fe1fc25fba |
| Default Java | 2020-01-14 |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/5/testReport/ |
| Max. process+thread count | 2810 (vs. ulimit of 12500) |
| modules | C: hbase-common hbase-server U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/5/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bsglz commented on a change in pull request #1797: HBASE-24451 Remove the HasThread because the related bug had been fix…
Posted by GitBox <gi...@apache.org>.
bsglz commented on a change in pull request #1797:
URL: https://github.com/apache/hbase/pull/1797#discussion_r431687846
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
##########
@@ -1472,7 +1470,7 @@ private void waitOnAllRegionsToClose(final boolean abort) {
}
}
- private static boolean sleep(long millis) {
+ private static boolean sleeps(long millis) {
Review comment:
sleep is clash with Thread.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1797: HBASE-24451 Remove the HasThread because the related bug had been fix…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1797:
URL: https://github.com/apache/hbase/pull/1797#issuecomment-635224762
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 31s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 35s | master passed |
| +1 :green_heart: | compile | 1m 17s | master passed |
| +1 :green_heart: | shadedjars | 5m 29s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 59s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 25s | the patch passed |
| +1 :green_heart: | compile | 1m 17s | the patch passed |
| +1 :green_heart: | javac | 1m 17s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 35s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 58s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 24s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 132m 59s | hbase-server in the patch passed. |
| | | 160m 19s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1797 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 66c733f0bcfa 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 79d56499ca |
| Default Java | 1.8.0_232 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/1/testReport/ |
| Max. process+thread count | 4135 (vs. ulimit of 12500) |
| modules | C: hbase-common hbase-server U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1797/1/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bsglz commented on pull request #1797: HBASE-24451 Remove the HasThread because the related bug had been fix…
Posted by GitBox <gi...@apache.org>.
bsglz commented on pull request #1797:
URL: https://github.com/apache/hbase/pull/1797#issuecomment-635934393
Seems ut failture due to time out. Comment in LargeTests.java:
> ideally, the whole large test-suite/class, no matter how many or how few test methods it has, will run in last less than three minutes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bsglz commented on a change in pull request #1797: HBASE-24451 Remove the HasThread because the related bug had been fix…
Posted by GitBox <gi...@apache.org>.
bsglz commented on a change in pull request #1797:
URL: https://github.com/apache/hbase/pull/1797#discussion_r432293341
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
##########
@@ -122,9 +121,9 @@ public SplitLogManager(MasterServices master, Configuration conf)
throws IOException {
this.server = master;
this.conf = conf;
- // Get Server Thread name. Sometimes the Server is mocked so may not implement HasThread.
+ // Get Server Thread name. Sometimes the Server is mocked so may not implement Thread.
// For example, in tests.
- String name = master instanceof HasThread? ((HasThread)master).getName():
+ String name = master instanceof Thread? ((Thread)master).getName():
Review comment:
In addition, maybe we can just always use master.getServerName().toShortString() as name here, WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bsglz commented on pull request #1797: HBASE-24451 Remove the HasThread because the related bug had been fix…
Posted by GitBox <gi...@apache.org>.
bsglz commented on pull request #1797:
URL: https://github.com/apache/hbase/pull/1797#issuecomment-635940919
Thanks a lot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bsglz commented on a change in pull request #1797: HBASE-24451 Remove the HasThread because the related bug had been fix…
Posted by GitBox <gi...@apache.org>.
bsglz commented on a change in pull request #1797:
URL: https://github.com/apache/hbase/pull/1797#discussion_r432286574
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
##########
@@ -122,9 +121,9 @@ public SplitLogManager(MasterServices master, Configuration conf)
throws IOException {
this.server = master;
this.conf = conf;
- // Get Server Thread name. Sometimes the Server is mocked so may not implement HasThread.
+ // Get Server Thread name. Sometimes the Server is mocked so may not implement Thread.
// For example, in tests.
- String name = master instanceof HasThread? ((HasThread)master).getName():
+ String name = master instanceof Thread? ((Thread)master).getName():
Review comment:
Good idea, will fix it in separate jira.
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] saintstack commented on a change in pull request #1797: HBASE-24451 Remove the HasThread because the related bug had been fix…
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1797:
URL: https://github.com/apache/hbase/pull/1797#discussion_r432095352
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
##########
@@ -122,9 +121,9 @@ public SplitLogManager(MasterServices master, Configuration conf)
throws IOException {
this.server = master;
this.conf = conf;
- // Get Server Thread name. Sometimes the Server is mocked so may not implement HasThread.
+ // Get Server Thread name. Sometimes the Server is mocked so may not implement Thread.
// For example, in tests.
- String name = master instanceof HasThread? ((HasThread)master).getName():
+ String name = master instanceof Thread? ((Thread)master).getName():
Review comment:
This is not needed w/ this patch?
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
##########
@@ -1908,9 +1907,9 @@ protected void queueAssign(final RegionStateNode regionNode) {
}
private void startAssignmentThread() {
- // Get Server Thread name. Sometimes the Server is mocked so may not implement HasThread.
+ // Get Server Thread name. Sometimes the Server is mocked so may not implement Thread.
// For example, in tests.
- String name = master instanceof HasThread? ((HasThread)master).getName():
+ String name = master instanceof Thread? ((Thread)master).getName():
Review comment:
Ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org