You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/12/04 08:56:00 UTC
[GitHub] [ozone] sky76093016 opened a new pull request #1657: HDDS-4546. Change ozone.datanode.pipeline.limit to 3 by default
sky76093016 opened a new pull request #1657:
URL: https://github.com/apache/ozone/pull/1657
## What changes were proposed in this pull request?
modify "ozone.datanode.pipeline.limit" to 3
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4546
## How was this patch tested?
no test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sky76093016 commented on pull request #1657: HDDS-4546. Change ozone.datanode.pipeline.limit to 3 by default
Posted by GitBox <gi...@apache.org>.
sky76093016 commented on pull request #1657:
URL: https://github.com/apache/ozone/pull/1657#issuecomment-747283672
I tried to make changes but test failures still appear. Do @adoroszlai have any comments?Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #1657: HDDS-4546. Change ozone.datanode.pipeline.limit to 3 by default
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1657:
URL: https://github.com/apache/ozone/pull/1657#issuecomment-742698266
@sky76093016 Thanks for working on this. Test failures seem related to the change in config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant closed pull request #1657: HDDS-4546. Change ozone.datanode.pipeline.limit to 3 by default
Posted by GitBox <gi...@apache.org>.
bshashikant closed pull request #1657:
URL: https://github.com/apache/ozone/pull/1657
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sky76093016 commented on pull request #1657: HDDS-4546. Change ozone.datanode.pipeline.limit to 3 by default
Posted by GitBox <gi...@apache.org>.
sky76093016 commented on pull request #1657:
URL: https://github.com/apache/ozone/pull/1657#issuecomment-754502444
Thanks to @adoroszlai for the suggestion, green build has been completed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant commented on pull request #1657: HDDS-4546. Change ozone.datanode.pipeline.limit to 3 by default
Posted by GitBox <gi...@apache.org>.
bshashikant commented on pull request #1657:
URL: https://github.com/apache/ozone/pull/1657#issuecomment-749959865
This will be addressed with https://github.com/apache/ozone/pull/1717 with some additional changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant commented on pull request #1657: HDDS-4546. Change ozone.datanode.pipeline.limit to 3 by default
Posted by GitBox <gi...@apache.org>.
bshashikant commented on pull request #1657:
URL: https://github.com/apache/ozone/pull/1657#issuecomment-760875603
Closing this as this has been addressed with https://github.com/apache/ozone/pull/1717.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #1657: HDDS-4546. Change ozone.datanode.pipeline.limit to 3 by default
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1657:
URL: https://github.com/apache/ozone/pull/1657#issuecomment-754511702
Thanks @sky76093016 for fixing the tests.
If I understand correctly, @bshashikant's comment says that this change is superseded by #1717 and the PR can be closed without merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #1657: HDDS-4546. Change ozone.datanode.pipeline.limit to 3 by default
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1657:
URL: https://github.com/apache/ozone/pull/1657#issuecomment-748931579
Acceptance test fails because Recon test expects 4 pipelines:
https://github.com/apache/ozone/blob/039d74a69e091b2307c3569b87ea9a3b9e7b4632/hadoop-ozone/dist/src/main/smoketest/recon/recon-api.robot#L63
but now with the increased limit it finds 5:
```
Check if Recon picks up DN heartbeats | FAIL |
'{"pipelines":5,"totalDatanodes":3,"healthyDatanodes":3,"storageReport":{"capacity":267934076928,"used":24576,"remaining":56696799232},"containers":5,"volumes":23,"buckets":87,"keys":171}' does not contain '"pipelines":4'
```
https://github.com/apache/ozone/pull/1657/checks?check_run_id=1555607541#step:7:1684
I think this can be fixed simply by changing the expectation to 5.
Failing integration tests could probably be fixed by manually configuring `....pipeline.limit` to its previous default value of 2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org