You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Martin Koci (JIRA)" <de...@myfaces.apache.org> on 2007/05/22 13:51:16 UTC
[jira] Created: (TRINIDAD-28) MessageFactory.BindingFacesMessage
resolves parameters only once
MessageFactory.BindingFacesMessage resolves parameters only once
----------------------------------------------------------------
Key: TRINIDAD-28
URL: https://issues.apache.org/jira/browse/TRINIDAD-28
Project: MyFaces Trinidad
Issue Type: Improvement
Components: Components
Affects Versions: 1.0.1-incubating-core-SNAPSHOT
Reporter: Martin Koci
Priority: Minor
I probably found a problem with BindingFacesMessage class. If calling getMessage() it resolves value binding only once and then cache it.
I think values should be resolved every time as normal ValueBinding or ValueExpressing does - calling getValue(context) creates a new value every time; but BindingFacesMessage returns still same value (which can be pretty old and unactual).
I fixed it locally with:
private void _resolveBindings()
{
//if (_resolvedParameters == null)
//{
_resolvedParameters = _getProcessedBindings(null, _parameters);
//}
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-28) MessageFactory.BindingFacesMessage
resolves parameters only once
Posted by "Adam Winer (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Winer updated TRINIDAD-28:
-------------------------------
Resolution: Fixed
Fix Version/s: 1.0.1-core
Status: Resolved (was: Patch Available)
Checked in patch.
> MessageFactory.BindingFacesMessage resolves parameters only once
> ----------------------------------------------------------------
>
> Key: TRINIDAD-28
> URL: https://issues.apache.org/jira/browse/TRINIDAD-28
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Components: Components
> Affects Versions: 1.0.1-core
> Reporter: Martin Koci
> Assigned To: Adam Winer
> Priority: Minor
> Fix For: 1.0.1-core
>
> Attachments: MessageFactory.java.patch
>
>
> I probably found a problem with BindingFacesMessage class. If calling getMessage() it resolves value binding only once and then cache it.
> I think values should be resolved every time as normal ValueBinding or ValueExpressing does - calling getValue(context) creates a new value every time; but BindingFacesMessage returns still same value (which can be pretty old and unactual).
> I fixed it locally with:
> private void _resolveBindings()
> {
> //if (_resolvedParameters == null)
> //{
> _resolvedParameters = _getProcessedBindings(null, _parameters);
> //}
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-28) MessageFactory.BindingFacesMessage
resolves parameters only once
Posted by "Martin Koci (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Koci updated TRINIDAD-28:
--------------------------------
Status: Patch Available (was: Open)
> MessageFactory.BindingFacesMessage resolves parameters only once
> ----------------------------------------------------------------
>
> Key: TRINIDAD-28
> URL: https://issues.apache.org/jira/browse/TRINIDAD-28
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Components: Components
> Affects Versions: 1.0.1-incubating-core-SNAPSHOT
> Reporter: Martin Koci
> Priority: Minor
> Attachments: MessageFactory.java.patch
>
>
> I probably found a problem with BindingFacesMessage class. If calling getMessage() it resolves value binding only once and then cache it.
> I think values should be resolved every time as normal ValueBinding or ValueExpressing does - calling getValue(context) creates a new value every time; but BindingFacesMessage returns still same value (which can be pretty old and unactual).
> I fixed it locally with:
> private void _resolveBindings()
> {
> //if (_resolvedParameters == null)
> //{
> _resolvedParameters = _getProcessedBindings(null, _parameters);
> //}
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.