You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Martijn van Groningen (Created) (JIRA)" <ji...@apache.org> on 2012/04/19 17:22:40 UTC
[jira] [Created] (LUCENE-4001) Grouping module shouldn't depend on
queries module
Grouping module shouldn't depend on queries module
--------------------------------------------------
Key: LUCENE-4001
URL: https://issues.apache.org/jira/browse/LUCENE-4001
Project: Lucene - Java
Issue Type: Task
Reporter: Martijn van Groningen
Spin off from LUCENE-3997. Basically move FunctionValues and ValueSource to core.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4001) Grouping module shouldn't depend
on queries module
Posted by "Martijn van Groningen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258817#comment-13258817 ]
Martijn van Groningen commented on LUCENE-4001:
-----------------------------------------------
In think that there are other features that might want to use functions. Faceting by function or joining by function seem like things that could be added in the future. Question is does this make functions a core concept? After some thinking it seems to me that functions are not a core concept.
What I think is a core concept is the abstraction of a where a values comes from (output of a function, int from FC or double from doc values). Perhaps this concept should be in core. The grouping module can use this concept instead of the function concept. This way the grouping module doesn't need to depend on the queries module. MutableValue is already in core, which is good. I think for this to happen we need to change FunctionValues.ValueFiller into MutableValueSource that has the following method:
{code}
public interface MutableValueSource {
public MutableValue getValue(int doc, MutableValue reuse){
...
}
}
{code}
This also looks similar to how we use FieldCache or DocValues.Source.
> Grouping module shouldn't depend on queries module
> --------------------------------------------------
>
> Key: LUCENE-4001
> URL: https://issues.apache.org/jira/browse/LUCENE-4001
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Martijn van Groningen
>
> Spin off from LUCENE-3997. Basically move FunctionValues and ValueSource to core.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4001) Grouping module shouldn't depend
on queries module
Posted by "Chris Male (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257945#comment-13257945 ]
Chris Male commented on LUCENE-4001:
------------------------------------
I have real reservations about doing this. In LUCENE-3997 I explained that I feel we should only move classes into core if they are part of core APIs / concepts. I don't think FunctionValues and ValueSource are in that boat. To me they seem tightly bound to FunctionQuery and the implementations in the queries module. Yes the grouping module uses them, but that doesn't immediately make them core. I also feel that in 99% of cases, people who want to group by function will be using the impls in the queries module, so why remove the dependency?
> Grouping module shouldn't depend on queries module
> --------------------------------------------------
>
> Key: LUCENE-4001
> URL: https://issues.apache.org/jira/browse/LUCENE-4001
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Martijn van Groningen
>
> Spin off from LUCENE-3997. Basically move FunctionValues and ValueSource to core.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4001) Grouping module shouldn't depend
on queries module
Posted by "Martijn van Groningen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257547#comment-13257547 ]
Martijn van Groningen commented on LUCENE-4001:
-----------------------------------------------
It turns out that three files need to be moved:
{noformat}
svn mv lucene/queries/src/java/org/apache/lucene/queries/function/FunctionValues.java lucene/core/src/java/org/apache/lucene/search/
svn mv lucene/queries/src/java/org/apache/lucene/queries/function/ValueSource.java lucene/core/src/java/org/apache/lucene/search/
svn mv lucene/queries/src/java/org/apache/lucene/queries/function/ValueSourceScorer.java lucene/core/src/java/org/apache/lucene/search/
{noformat}
> Grouping module shouldn't depend on queries module
> --------------------------------------------------
>
> Key: LUCENE-4001
> URL: https://issues.apache.org/jira/browse/LUCENE-4001
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Martijn van Groningen
>
> Spin off from LUCENE-3997. Basically move FunctionValues and ValueSource to core.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org