[jira] [Comment Edited] (MESOS-3787) As a developer, I'd like to be able to expand environment variables through the Docker executor.

["haosdent (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-3787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975486#comment-14975486 ] 

haosdent edited comment on MESOS-3787 at 10/27/15 1:28 AM:
-----------------------------------------------------------

I think we just need run it use the shell way, not need extra variables before start.
{code}
diff --git a/src/docker/docker.cpp b/src/docker/docker.cpp
index 56d63dc..71327bd 100755
--- a/src/docker/docker.cpp
+++ b/src/docker/docker.cpp
@@ -583,8 +583,7 @@ Future<Nothing> Docker::run(
   }

   Try<Subprocess> s = subprocess(
-      path,
-      argv,
+      cmd,
       Subprocess::PATH("/dev/null"),
       stdoutIo,
       stderrIo,
{code}

According my test example in https://reviews.apache.org/r/39387/ . Pass "$xxx" would replace to environment variables when running.


was (Author: haosdent@gmail.com):
I think we just need run it use the shell way, not need extra variables before start.
{node}
diff --git a/src/docker/docker.cpp b/src/docker/docker.cpp
index 56d63dc..71327bd 100755
--- a/src/docker/docker.cpp
+++ b/src/docker/docker.cpp
@@ -583,8 +583,7 @@ Future<Nothing> Docker::run(
   }

   Try<Subprocess> s = subprocess(
-      path,
-      argv,
+      cmd,
       Subprocess::PATH("/dev/null"),
       stdoutIo,
       stderrIo,
{node}

According my test example in https://reviews.apache.org/r/39387/ . Pass "$xxx" would replace to environment variables when running.

> As a developer, I'd like to be able to expand environment variables through the Docker executor.
> ------------------------------------------------------------------------------------------------
>
>                 Key: MESOS-3787
>                 URL: https://issues.apache.org/jira/browse/MESOS-3787
>             Project: Mesos
>          Issue Type: Wish
>            Reporter: John Garcia
>              Labels: mesosphere
>         Attachments: mesos.patch, test-example.json
>
>
> We'd like to have expanded variables usable in [the json files used to create a Marathon app, hence] the Task's CommandInfo, so that the executor is able to detect the correct values at runtime.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)