You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/12/01 06:11:26 UTC

[GitHub] [maven-jlink-plugin] sparsick edited a comment on pull request #20: (build) Add Java8 + Toolchain tests

sparsick edited a comment on pull request #20:
URL: https://github.com/apache/maven-jlink-plugin/pull/20#issuecomment-736246183


   @bmarwell I could fix the build on my machine when I set following property in `invoker.properties`
   
   ```properties
   invoker.goals = clean install -t <path to it-toolchains.xml>
   ```
   On the commandline I had to run `mvn verfiy -t it-toolchains.xml` otherwise Maven skipped the tests. 
   
   Maybe it is a bug in invoker plugin that it ignores `-t ` flag?
   
   Other thing that I notice, in the pom of MJLINK-36_toolchainjdk8 `compiler.target` and `compiler.source` are set to `1.9`. Is this correct? I have expected `1.8`.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org