You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@iotdb.apache.org by Julian Feinauer <j....@pragmaticminds.de> on 2019/07/16 08:19:51 UTC
Cherry-picking without PR
Hi,
as I'm working through the rel/0.8 branch I observed Tests that failed for me.
This is due to minor issues with the Locale.
I changed it already in the rel branch but is everybody okay to cherry-pick this to master directly or do you prefer a PR for everything?
In other projects we handle it that way:
- if the change is very minor and committer feels its okay to do it in develop / master directly then he does it
- If change is major or important than we make a PR and ask for review
How do you / should we handle this?
Julian
Re: Rename modules
Posted by Julian Feinauer <j....@pragmaticminds.de>.
No objections from my side, at least : )
Am 22.07.19, 15:15 schrieb "Xiangdong Huang" <sa...@gmail.com>:
Hi,
If there is no more comments, shall we merge the PR (#289)?
Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
Julian Feinauer <j....@pragmaticminds.de> 于2019年7月22日周一 下午8:58写道：
> Hi,
>
> +1 from me.
> Regarding merge-hell...if we use git mv it should work out of the box with
> very few issues.... I think __
>
> Julian
>
> Am 22.07.19, 14:40 schrieb "Xiangdong Huang" <sa...@gmail.com>:
>
> Well, the structure looks fine... I pray for those existing opened
> PRs
> because the confliction...
> Best,
> -----------------------------------
> Xiangdong Huang
> School of Software, Tsinghua University
>
> 黄向东
> 清华大学 软件学院
>
>
> Jialin Qiao <qj...@mails.tsinghua.edu.cn> 于2019年7月22日周一 下午8:22写道：
>
> > Hi,
> >
> > This idea is excellent! So, the target folders and artifactIds can
> be as
> > follows:
> >
> > tsfile : tsfile
> > service-rpc : service-rpc
> > jdbc : iotdb-jdbc
> > client : iotdb-client
> > server: iotdb-server
> > example : iotdb-examples
> > grafana : iotdb-grafana
> > spark-tsfile : spark-tsfile (we may add spark-iotdb-connector
> module in
> > the future, so it could be distinguished from spark-tsfile)
> >
> > If this structure is ok, I will resubmit this PR :)
> >
> > Best,
> > --
> > Jialin Qiao
> > School of Software, Tsinghua University
> >
> > 乔嘉林
> > 清华大学 软件学院
> >
> > > -----原始邮件-----
> > > 发件人: "Julian Feinauer" <j....@pragmaticminds.de>
> > > 发送时间: 2019-07-22 20:09:36 (星期一)
> > > 收件人: "dev@iotdb.apache.org" <de...@iotdb.apache.org>
> > > 抄送:
> > > 主题: Re: Rename modules
> > >
> > > Hey,
> > >
> > > logically the PR iss mall but many changed files : )
> > >
> > > The only thing I would take to consider is whether we really do
> want
> > those names for folders.
> > > In other projects you usually make the short name for the folder
> and
> > longer for the artifact, this means folders would be like
> > >
> > > For example the "server" module would be in the folder
> "iotdb/server"
> > but with artifactId "iotdb-server".
> > > I like those shorter folder names when navigating with the cmd.
> > >
> > > So I suggest to rename iotdb to "server" but artifactId to
> > "iotdb-server".
> > >
> > > What do others think?
> > >
> > > Julian
> > >
> > > PS.: Oh and I saw that Travis fails.. so does that imply any
> > build-breaking adjustments that we need to do?
> > >
> > >
> > >
> > > Am 22.07.19, 14:03 schrieb "Xiangdong Huang" <sa...@gmail.com>:
> > >
> > > Hi,
> > >
> > > It is a big change because at least 2/3 files are renamed...
> > >
> > > Best.
> > > -----------------------------------
> > > Xiangdong Huang
> > > School of Software, Tsinghua University
> > >
> > > 黄向东
> > > 清华大学 软件学院
> > >
> > >
> > > Jialin Qiao <qj...@mails.tsinghua.edu.cn> 于2019年7月22日周一
> 下午7:43写道：
> > >
> > > > Hi all,
> > > >
> > > > IoTDB project has the following modules: tsfile, service-rpc,
> > jdbc, iotdb,
> > > > grafana, service-rpc, iotdb-cli, example and spark, in which
> > "iotdb" and
> > > > "spark" look strange.
> > > >
> > > > Therefore, I rename iotdb to iotdb-server and spark to
> > spark-tsfile by
> > > > "git mv" for retaining the commit history and submit a PR (
> > > > https://github.com/apache/incubator-iotdb/pull/287) to
> rel/0.8.
> > > >
> > > > I believe this makes the modules clearer... What do you
> think?
> > > >
> > > > Best,
> > > > --
> > > > Jialin Qiao
> > > > School of Software, Tsinghua University
> > > >
> > > > 乔嘉林
> > > > 清华大学 软件学院
> > > >
> > >
> > >
> >
>
>
>
Re: Rename modules
Posted by Xiangdong Huang <sa...@gmail.com>.
Hi,
If there is no more comments, shall we merge the PR (#289)?
Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
Julian Feinauer <j....@pragmaticminds.de> 于2019年7月22日周一 下午8:58写道：
> Hi,
>
> +1 from me.
> Regarding merge-hell...if we use git mv it should work out of the box with
> very few issues.... I think __
>
> Julian
>
> Am 22.07.19, 14:40 schrieb "Xiangdong Huang" <sa...@gmail.com>:
>
> Well, the structure looks fine... I pray for those existing opened
> PRs
> because the confliction...
> Best,
> -----------------------------------
> Xiangdong Huang
> School of Software, Tsinghua University
>
> 黄向东
> 清华大学 软件学院
>
>
> Jialin Qiao <qj...@mails.tsinghua.edu.cn> 于2019年7月22日周一 下午8:22写道：
>
> > Hi,
> >
> > This idea is excellent! So, the target folders and artifactIds can
> be as
> > follows:
> >
> > tsfile : tsfile
> > service-rpc : service-rpc
> > jdbc : iotdb-jdbc
> > client : iotdb-client
> > server: iotdb-server
> > example : iotdb-examples
> > grafana : iotdb-grafana
> > spark-tsfile : spark-tsfile (we may add spark-iotdb-connector
> module in
> > the future, so it could be distinguished from spark-tsfile)
> >
> > If this structure is ok, I will resubmit this PR :)
> >
> > Best,
> > --
> > Jialin Qiao
> > School of Software, Tsinghua University
> >
> > 乔嘉林
> > 清华大学 软件学院
> >
> > > -----原始邮件-----
> > > 发件人: "Julian Feinauer" <j....@pragmaticminds.de>
> > > 发送时间: 2019-07-22 20:09:36 (星期一)
> > > 收件人: "dev@iotdb.apache.org" <de...@iotdb.apache.org>
> > > 抄送:
> > > 主题: Re: Rename modules
> > >
> > > Hey,
> > >
> > > logically the PR iss mall but many changed files : )
> > >
> > > The only thing I would take to consider is whether we really do
> want
> > those names for folders.
> > > In other projects you usually make the short name for the folder
> and
> > longer for the artifact, this means folders would be like
> > >
> > > For example the "server" module would be in the folder
> "iotdb/server"
> > but with artifactId "iotdb-server".
> > > I like those shorter folder names when navigating with the cmd.
> > >
> > > So I suggest to rename iotdb to "server" but artifactId to
> > "iotdb-server".
> > >
> > > What do others think?
> > >
> > > Julian
> > >
> > > PS.: Oh and I saw that Travis fails.. so does that imply any
> > build-breaking adjustments that we need to do?
> > >
> > >
> > >
> > > Am 22.07.19, 14:03 schrieb "Xiangdong Huang" <sa...@gmail.com>:
> > >
> > > Hi,
> > >
> > > It is a big change because at least 2/3 files are renamed...
> > >
> > > Best.
> > > -----------------------------------
> > > Xiangdong Huang
> > > School of Software, Tsinghua University
> > >
> > > 黄向东
> > > 清华大学 软件学院
> > >
> > >
> > > Jialin Qiao <qj...@mails.tsinghua.edu.cn> 于2019年7月22日周一
> 下午7:43写道：
> > >
> > > > Hi all,
> > > >
> > > > IoTDB project has the following modules: tsfile, service-rpc,
> > jdbc, iotdb,
> > > > grafana, service-rpc, iotdb-cli, example and spark, in which
> > "iotdb" and
> > > > "spark" look strange.
> > > >
> > > > Therefore, I rename iotdb to iotdb-server and spark to
> > spark-tsfile by
> > > > "git mv" for retaining the commit history and submit a PR (
> > > > https://github.com/apache/incubator-iotdb/pull/287) to
> rel/0.8.
> > > >
> > > > I believe this makes the modules clearer... What do you
> think?
> > > >
> > > > Best,
> > > > --
> > > > Jialin Qiao
> > > > School of Software, Tsinghua University
> > > >
> > > > 乔嘉林
> > > > 清华大学 软件学院
> > > >
> > >
> > >
> >
>
>
>
Re: Rename modules
Posted by Julian Feinauer <j....@pragmaticminds.de>.
Hi,
+1 from me.
Regarding merge-hell...if we use git mv it should work out of the box with very few issues.... I think __
Julian
Am 22.07.19, 14:40 schrieb "Xiangdong Huang" <sa...@gmail.com>:
Well, the structure looks fine... I pray for those existing opened PRs
because the confliction...
Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
Jialin Qiao <qj...@mails.tsinghua.edu.cn> 于2019年7月22日周一 下午8:22写道：
> Hi,
>
> This idea is excellent! So, the target folders and artifactIds can be as
> follows:
>
> tsfile : tsfile
> service-rpc : service-rpc
> jdbc : iotdb-jdbc
> client : iotdb-client
> server: iotdb-server
> example : iotdb-examples
> grafana : iotdb-grafana
> spark-tsfile : spark-tsfile (we may add spark-iotdb-connector module in
> the future, so it could be distinguished from spark-tsfile)
>
> If this structure is ok, I will resubmit this PR :)
>
> Best,
> --
> Jialin Qiao
> School of Software, Tsinghua University
>
> 乔嘉林
> 清华大学 软件学院
>
> > -----原始邮件-----
> > 发件人: "Julian Feinauer" <j....@pragmaticminds.de>
> > 发送时间: 2019-07-22 20:09:36 (星期一)
> > 收件人: "dev@iotdb.apache.org" <de...@iotdb.apache.org>
> > 抄送:
> > 主题: Re: Rename modules
> >
> > Hey,
> >
> > logically the PR iss mall but many changed files : )
> >
> > The only thing I would take to consider is whether we really do want
> those names for folders.
> > In other projects you usually make the short name for the folder and
> longer for the artifact, this means folders would be like
> >
> > For example the "server" module would be in the folder "iotdb/server"
> but with artifactId "iotdb-server".
> > I like those shorter folder names when navigating with the cmd.
> >
> > So I suggest to rename iotdb to "server" but artifactId to
> "iotdb-server".
> >
> > What do others think?
> >
> > Julian
> >
> > PS.: Oh and I saw that Travis fails.. so does that imply any
> build-breaking adjustments that we need to do?
> >
> >
> >
> > Am 22.07.19, 14:03 schrieb "Xiangdong Huang" <sa...@gmail.com>:
> >
> > Hi,
> >
> > It is a big change because at least 2/3 files are renamed...
> >
> > Best.
> > -----------------------------------
> > Xiangdong Huang
> > School of Software, Tsinghua University
> >
> > 黄向东
> > 清华大学 软件学院
> >
> >
> > Jialin Qiao <qj...@mails.tsinghua.edu.cn> 于2019年7月22日周一 下午7:43写道：
> >
> > > Hi all,
> > >
> > > IoTDB project has the following modules: tsfile, service-rpc,
> jdbc, iotdb,
> > > grafana, service-rpc, iotdb-cli, example and spark, in which
> "iotdb" and
> > > "spark" look strange.
> > >
> > > Therefore, I rename iotdb to iotdb-server and spark to
> spark-tsfile by
> > > "git mv" for retaining the commit history and submit a PR (
> > > https://github.com/apache/incubator-iotdb/pull/287) to rel/0.8.
> > >
> > > I believe this makes the modules clearer... What do you think?
> > >
> > > Best,
> > > --
> > > Jialin Qiao
> > > School of Software, Tsinghua University
> > >
> > > 乔嘉林
> > > 清华大学 软件学院
> > >
> >
> >
>
Re: Rename modules
Posted by Xiangdong Huang <sa...@gmail.com>.
Well, the structure looks fine... I pray for those existing opened PRs
because the confliction...
Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
Jialin Qiao <qj...@mails.tsinghua.edu.cn> 于2019年7月22日周一 下午8:22写道：
> Hi,
>
> This idea is excellent! So, the target folders and artifactIds can be as
> follows:
>
> tsfile : tsfile
> service-rpc : service-rpc
> jdbc : iotdb-jdbc
> client : iotdb-client
> server: iotdb-server
> example : iotdb-examples
> grafana : iotdb-grafana
> spark-tsfile : spark-tsfile (we may add spark-iotdb-connector module in
> the future, so it could be distinguished from spark-tsfile)
>
> If this structure is ok, I will resubmit this PR :)
>
> Best,
> --
> Jialin Qiao
> School of Software, Tsinghua University
>
> 乔嘉林
> 清华大学 软件学院
>
> > -----原始邮件-----
> > 发件人: "Julian Feinauer" <j....@pragmaticminds.de>
> > 发送时间: 2019-07-22 20:09:36 (星期一)
> > 收件人: "dev@iotdb.apache.org" <de...@iotdb.apache.org>
> > 抄送:
> > 主题: Re: Rename modules
> >
> > Hey,
> >
> > logically the PR iss mall but many changed files : )
> >
> > The only thing I would take to consider is whether we really do want
> those names for folders.
> > In other projects you usually make the short name for the folder and
> longer for the artifact, this means folders would be like
> >
> > For example the "server" module would be in the folder "iotdb/server"
> but with artifactId "iotdb-server".
> > I like those shorter folder names when navigating with the cmd.
> >
> > So I suggest to rename iotdb to "server" but artifactId to
> "iotdb-server".
> >
> > What do others think?
> >
> > Julian
> >
> > PS.: Oh and I saw that Travis fails.. so does that imply any
> build-breaking adjustments that we need to do?
> >
> >
> >
> > Am 22.07.19, 14:03 schrieb "Xiangdong Huang" <sa...@gmail.com>:
> >
> > Hi,
> >
> > It is a big change because at least 2/3 files are renamed...
> >
> > Best.
> > -----------------------------------
> > Xiangdong Huang
> > School of Software, Tsinghua University
> >
> > 黄向东
> > 清华大学 软件学院
> >
> >
> > Jialin Qiao <qj...@mails.tsinghua.edu.cn> 于2019年7月22日周一 下午7:43写道：
> >
> > > Hi all,
> > >
> > > IoTDB project has the following modules: tsfile, service-rpc,
> jdbc, iotdb,
> > > grafana, service-rpc, iotdb-cli, example and spark, in which
> "iotdb" and
> > > "spark" look strange.
> > >
> > > Therefore, I rename iotdb to iotdb-server and spark to
> spark-tsfile by
> > > "git mv" for retaining the commit history and submit a PR (
> > > https://github.com/apache/incubator-iotdb/pull/287) to rel/0.8.
> > >
> > > I believe this makes the modules clearer... What do you think?
> > >
> > > Best,
> > > --
> > > Jialin Qiao
> > > School of Software, Tsinghua University
> > >
> > > 乔嘉林
> > > 清华大学 软件学院
> > >
> >
> >
>
Re: Rename modules
Posted by Jialin Qiao <qj...@mails.tsinghua.edu.cn>.
Hi,
This idea is excellent! So, the target folders and artifactIds can be as follows:
tsfile : tsfile
service-rpc : service-rpc
jdbc : iotdb-jdbc
client : iotdb-client
server: iotdb-server
example : iotdb-examples
grafana : iotdb-grafana
spark-tsfile : spark-tsfile (we may add spark-iotdb-connector module in the future, so it could be distinguished from spark-tsfile)
If this structure is ok, I will resubmit this PR :)
Best,
--
Jialin Qiao
School of Software, Tsinghua University
乔嘉林
清华大学 软件学院
> -----原始邮件-----
> 发件人: "Julian Feinauer" <j....@pragmaticminds.de>
> 发送时间: 2019-07-22 20:09:36 (星期一)
> 收件人: "dev@iotdb.apache.org" <de...@iotdb.apache.org>
> 抄送:
> 主题: Re: Rename modules
>
> Hey,
>
> logically the PR iss mall but many changed files : )
>
> The only thing I would take to consider is whether we really do want those names for folders.
> In other projects you usually make the short name for the folder and longer for the artifact, this means folders would be like
>
> For example the "server" module would be in the folder "iotdb/server" but with artifactId "iotdb-server".
> I like those shorter folder names when navigating with the cmd.
>
> So I suggest to rename iotdb to "server" but artifactId to "iotdb-server".
>
> What do others think?
>
> Julian
>
> PS.: Oh and I saw that Travis fails.. so does that imply any build-breaking adjustments that we need to do?
>
>
>
> Am 22.07.19, 14:03 schrieb "Xiangdong Huang" <sa...@gmail.com>:
>
> Hi,
>
> It is a big change because at least 2/3 files are renamed...
>
> Best.
> -----------------------------------
> Xiangdong Huang
> School of Software, Tsinghua University
>
> 黄向东
> 清华大学 软件学院
>
>
> Jialin Qiao <qj...@mails.tsinghua.edu.cn> 于2019年7月22日周一 下午7:43写道：
>
> > Hi all,
> >
> > IoTDB project has the following modules: tsfile, service-rpc, jdbc, iotdb,
> > grafana, service-rpc, iotdb-cli, example and spark, in which "iotdb" and
> > "spark" look strange.
> >
> > Therefore, I rename iotdb to iotdb-server and spark to spark-tsfile by
> > "git mv" for retaining the commit history and submit a PR (
> > https://github.com/apache/incubator-iotdb/pull/287) to rel/0.8.
> >
> > I believe this makes the modules clearer... What do you think?
> >
> > Best,
> > --
> > Jialin Qiao
> > School of Software, Tsinghua University
> >
> > 乔嘉林
> > 清华大学 软件学院
> >
>
>
Re: Rename modules
Posted by Julian Feinauer <j....@pragmaticminds.de>.
Hey,
logically the PR iss mall but many changed files : )
The only thing I would take to consider is whether we really do want those names for folders.
In other projects you usually make the short name for the folder and longer for the artifact, this means folders would be like
For example the "server" module would be in the folder "iotdb/server" but with artifactId "iotdb-server".
I like those shorter folder names when navigating with the cmd.
So I suggest to rename iotdb to "server" but artifactId to "iotdb-server".
What do others think?
Julian
PS.: Oh and I saw that Travis fails.. so does that imply any build-breaking adjustments that we need to do?
Am 22.07.19, 14:03 schrieb "Xiangdong Huang" <sa...@gmail.com>:
Hi,
It is a big change because at least 2/3 files are renamed...
Best.
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
Jialin Qiao <qj...@mails.tsinghua.edu.cn> 于2019年7月22日周一 下午7:43写道：
> Hi all,
>
> IoTDB project has the following modules: tsfile, service-rpc, jdbc, iotdb,
> grafana, service-rpc, iotdb-cli, example and spark, in which "iotdb" and
> "spark" look strange.
>
> Therefore, I rename iotdb to iotdb-server and spark to spark-tsfile by
> "git mv" for retaining the commit history and submit a PR (
> https://github.com/apache/incubator-iotdb/pull/287) to rel/0.8.
>
> I believe this makes the modules clearer... What do you think?
>
> Best,
> --
> Jialin Qiao
> School of Software, Tsinghua University
>
> 乔嘉林
> 清华大学 软件学院
>
Re: Rename modules
Posted by Xiangdong Huang <sa...@gmail.com>.
Hi,
It is a big change because at least 2/3 files are renamed...
Best.
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
Jialin Qiao <qj...@mails.tsinghua.edu.cn> 于2019年7月22日周一 下午7:43写道：
> Hi all,
>
> IoTDB project has the following modules: tsfile, service-rpc, jdbc, iotdb,
> grafana, service-rpc, iotdb-cli, example and spark, in which "iotdb" and
> "spark" look strange.
>
> Therefore, I rename iotdb to iotdb-server and spark to spark-tsfile by
> "git mv" for retaining the commit history and submit a PR (
> https://github.com/apache/incubator-iotdb/pull/287) to rel/0.8.
>
> I believe this makes the modules clearer... What do you think?
>
> Best,
> --
> Jialin Qiao
> School of Software, Tsinghua University
>
> 乔嘉林
> 清华大学 软件学院
>
Rename modules
Posted by Jialin Qiao <qj...@mails.tsinghua.edu.cn>.
Hi all,
IoTDB project has the following modules: tsfile, service-rpc, jdbc, iotdb, grafana, service-rpc, iotdb-cli, example and spark, in which "iotdb" and "spark" look strange.
Therefore, I rename iotdb to iotdb-server and spark to spark-tsfile by "git mv" for retaining the commit history and submit a PR (https://github.com/apache/incubator-iotdb/pull/287) to rel/0.8.
I believe this makes the modules clearer... What do you think?
Best,
--
Jialin Qiao
School of Software, Tsinghua University
乔嘉林
清华大学 软件学院
Re: Cherry-picking without PR
Posted by Xiangdong Huang <sa...@gmail.com>.
Hi,
> - if the change is very minor and committer feels its okay to do it in
develop / master directly then he does it
> - If change is major or important than we make a PR and ask for review
Or I think we need record which PR has been cherry-picked at least. Like
[1].
[1] https://github.com/apache/incubator-iotdb/pull/275
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
Xiangdong Huang <sa...@gmail.com> 于2019年7月19日周五 下午6:21写道：
> Hi,
>
> > - if the change is very minor and committer feels its okay to do it in
> develop / master directly then he does it
> > - If change is major or important than we make a PR and ask for review
>
> I'd like another PR (and attached the related approved PR URL on the other
> branch), so that some other committers can approve it quickly and it is
> easy to let others know that there is a changes on the master/developer
> branch.
>
> Best.
> -----------------------------------
> Xiangdong Huang
> School of Software, Tsinghua University
>
> 黄向东
> 清华大学 软件学院
>
>
> Julian Feinauer <j....@pragmaticminds.de> 于2019年7月19日周五 下午4:34写道：
>
>> Hi,
>>
>> I got no opinions yet but would like to get some before simply doing it
>> (or forgetting it).
>>
>> Thanks!
>> Julian
>>
>> Am 16.07.19, 10:20 schrieb "Julian Feinauer" <
>> j.feinauer@pragmaticminds.de>:
>>
>> Hi,
>>
>> as I'm working through the rel/0.8 branch I observed Tests that
>> failed for me.
>> This is due to minor issues with the Locale.
>> I changed it already in the rel branch but is everybody okay to
>> cherry-pick this to master directly or do you prefer a PR for everything?
>>
>> In other projects we handle it that way:
>> - if the change is very minor and committer feels its okay to do it
>> in develop / master directly then he does it
>> - If change is major or important than we make a PR and ask for review
>>
>> How do you / should we handle this?
>>
>> Julian
>>
>>
>>
>>
Re: Cherry-picking without PR
Posted by Xiangdong Huang <sa...@gmail.com>.
Hi,
> - if the change is very minor and committer feels its okay to do it in
develop / master directly then he does it
> - If change is major or important than we make a PR and ask for review
I'd like another PR (and attached the related approved PR URL on the other
branch), so that some other committers can approve it quickly and it is
easy to let others know that there is a changes on the master/developer
branch.
Best.
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
Julian Feinauer <j....@pragmaticminds.de> 于2019年7月19日周五 下午4:34写道：
> Hi,
>
> I got no opinions yet but would like to get some before simply doing it
> (or forgetting it).
>
> Thanks!
> Julian
>
> Am 16.07.19, 10:20 schrieb "Julian Feinauer" <
> j.feinauer@pragmaticminds.de>:
>
> Hi,
>
> as I'm working through the rel/0.8 branch I observed Tests that failed
> for me.
> This is due to minor issues with the Locale.
> I changed it already in the rel branch but is everybody okay to
> cherry-pick this to master directly or do you prefer a PR for everything?
>
> In other projects we handle it that way:
> - if the change is very minor and committer feels its okay to do it in
> develop / master directly then he does it
> - If change is major or important than we make a PR and ask for review
>
> How do you / should we handle this?
>
> Julian
>
>
>
>
Re: Cherry-picking without PR
Posted by Julian Feinauer <j....@pragmaticminds.de>.
Hi,
I got no opinions yet but would like to get some before simply doing it (or forgetting it).
Thanks!
Julian
Am 16.07.19, 10:20 schrieb "Julian Feinauer" <j....@pragmaticminds.de>:
Hi,
as I'm working through the rel/0.8 branch I observed Tests that failed for me.
This is due to minor issues with the Locale.
I changed it already in the rel branch but is everybody okay to cherry-pick this to master directly or do you prefer a PR for everything?
In other projects we handle it that way:
- if the change is very minor and committer feels its okay to do it in develop / master directly then he does it
- If change is major or important than we make a PR and ask for review
How do you / should we handle this?
Julian