You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by ji...@apache.org on 2026/01/19 14:46:52 UTC

(nuttx-apps) branch master updated: usrsocktest: fix TEST_ASSERT_EQUAL fail for POLLIN

This is an automated email from the ASF dual-hosted git repository.

jiuzhudong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git


The following commit(s) were added to refs/heads/master by this push:
     new a75fa3709 usrsocktest: fix TEST_ASSERT_EQUAL fail for POLLIN
a75fa3709 is described below

commit a75fa37090aaeda1fd95477e8fe74e6675384580
Author: guanyi3 <gu...@xiaomi.com>
AuthorDate: Fri Oct 10 11:45:45 2025 +0800

    usrsocktest: fix TEST_ASSERT_EQUAL fail for POLLIN
    
    This assertion should be removed because the POLLIN event is now only
    raised when there is data pending to be received. Previously, POLLIN
    was incorrectly set as soon as the connection was established, even
    when no data was available, which was not consistent with the expected
    behavior.
    
    Signed-off-by: guanyi3 <gu...@xiaomi.com>
---
 examples/usrsocktest/usrsocktest_remote_disconnect.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/examples/usrsocktest/usrsocktest_remote_disconnect.c b/examples/usrsocktest/usrsocktest_remote_disconnect.c
index 1e3681f9d..79ccbfefb 100644
--- a/examples/usrsocktest/usrsocktest_remote_disconnect.c
+++ b/examples/usrsocktest/usrsocktest_remote_disconnect.c
@@ -871,7 +871,6 @@ static void remote_disconnect_poll2(struct usrsocktest_daemon_conf_s *dconf)
       TEST_ASSERT_EQUAL(1, ret);
       TEST_ASSERT_EQUAL(0, pfd.revents & POLLERR);
       TEST_ASSERT_EQUAL(POLLHUP, pfd.revents & POLLHUP);
-      TEST_ASSERT_EQUAL(*events & POLLIN, pfd.revents & POLLIN);
       TEST_ASSERT_EQUAL(0, pfd.revents & POLLOUT);
       TEST_ASSERT_EQUAL(1, usrsocktest_daemon_get_num_active_sockets());
       TEST_ASSERT_EQUAL(0, usrsocktest_daemon_get_num_connected_sockets());