You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/01/18 10:58:16 UTC

[GitHub] markusthoemmes commented on a change in pull request #3198: move network + dns container args to pureconfig

markusthoemmes commented on a change in pull request #3198: move network + dns container args to pureconfig
URL: https://github.com/apache/incubator-openwhisk/pull/3198#discussion_r162308782
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/core/containerpool/ContainerFactory.scala
 ##########
 @@ -18,15 +18,23 @@
 package whisk.core.containerpool
 
 import akka.actor.ActorSystem
+import com.typesafe.config.ConfigFactory
+import java.util.ArrayList
+import pureconfig.ConfigReader
+import pureconfig.loadConfigOrThrow
 
 Review comment:
   You want to import `pureconfig._` here to get all the implicits.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services