[GitHub] [storm] bipinprasad commented on a change in pull request #3332: STORM-3696 don't ignore InterruptedException

[GitBox <gi...@apache.org>]

bipinprasad commented on a change in pull request #3332:
URL: https://github.com/apache/storm/pull/3332#discussion_r485171932



##########
File path: storm-client/src/jvm/org/apache/storm/daemon/supervisor/ClientSupervisorUtils.java
##########
@@ -71,7 +71,9 @@ public static int processLauncherAndWait(Map<String, Object> conf, String user,
         try {
             process.waitFor();
         } catch (InterruptedException e) {
-            LOG.info("{} interrupted.", logPreFix);
+            LOG.warn("{} interrupted.", logPreFix);
+            Thread.currentThread().interrupt();
+            throw new IOException(logPreFix + " interrupted", e);

Review comment:
       Need a process.destroy() here before throwing the IOException, so the cleanup can happen.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org