You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/12/18 19:34:36 UTC
[Impala-ASF-CR] Fix bug in report benchmark results.py
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14925
Change subject: Fix bug in report_benchmark_results.py
......................................................................
Fix bug in report_benchmark_results.py
This was introduced by IMPALA-4618.
Exception was:
Traceback (most recent call last):
File "tests/benchmark/report_benchmark_results.py", line 1135, in <module>
report = Report(grouped, ref_grouped)
File "tests/benchmark/report_benchmark_results.py", line 494, in __init__
self.__analyze()
File "tests/benchmark/report_benchmark_results.py", line 517, in __analyze
query_variability_row = Report.QueryVariabilityRow(results, ref_results)
File "tests/benchmark/report_benchmark_results.py", line 480, in __init__
results, ref_results, for_variability = True)
File "tests/benchmark/report_benchmark_results.py", line 1095, in build_exec_summary_str
return str(comparison) + '\n'
File "tests/benchmark/report_benchmark_results.py", line 844, in __str__
return str(self.__build_table_variability())
File "tests/benchmark/report_benchmark_results.py", line 891, in __build_table_variability
output += str(self.combined_summary) + '\n'
File "tests/benchmark/report_benchmark_results.py", line 713, in __str__
table.add_row(table_row)
File "/home/tarmstrong/Impala/incubator-impala/infra/python/env/local/lib/python2.7/site-packages/prettytable.py", line 818, in add_row
raise Exception("Row has incorrect number of values, (actual) %d!=%d (expected)" %(len(row),len(self._field_names)))
Exception: Row has incorrect number of values, (actual) 8!=7 (expected)
Change-Id: I6a163e74fefc896464e35a6a1b91ce57de592f1a
---
M tests/benchmark/report_benchmark_results.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/14925/1
--
To view, visit http://gerrit.cloudera.org:8080/14925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6a163e74fefc896464e35a6a1b91ce57de592f1a
Gerrit-Change-Number: 14925
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Fix bug in report benchmark results.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14925 )
Change subject: Fix bug in report_benchmark_results.py
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a163e74fefc896464e35a6a1b91ce57de592f1a
Gerrit-Change-Number: 14925
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Dec 2019 17:02:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fix bug in report benchmark results.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14925 )
Change subject: Fix bug in report_benchmark_results.py
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5360/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a163e74fefc896464e35a6a1b91ce57de592f1a
Gerrit-Change-Number: 14925
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Dec 2019 12:32:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fix bug in report benchmark results.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14925 )
Change subject: Fix bug in report_benchmark_results.py
......................................................................
Fix bug in report_benchmark_results.py
This was introduced by IMPALA-4618.
Exception was:
Traceback (most recent call last):
File "tests/benchmark/report_benchmark_results.py", line 1135, in <module>
report = Report(grouped, ref_grouped)
File "tests/benchmark/report_benchmark_results.py", line 494, in __init__
self.__analyze()
File "tests/benchmark/report_benchmark_results.py", line 517, in __analyze
query_variability_row = Report.QueryVariabilityRow(results, ref_results)
File "tests/benchmark/report_benchmark_results.py", line 480, in __init__
results, ref_results, for_variability = True)
File "tests/benchmark/report_benchmark_results.py", line 1095, in build_exec_summary_str
return str(comparison) + '\n'
File "tests/benchmark/report_benchmark_results.py", line 844, in __str__
return str(self.__build_table_variability())
File "tests/benchmark/report_benchmark_results.py", line 891, in __build_table_variability
output += str(self.combined_summary) + '\n'
File "tests/benchmark/report_benchmark_results.py", line 713, in __str__
table.add_row(table_row)
File "/home/tarmstrong/Impala/incubator-impala/infra/python/env/local/lib/python2.7/site-packages/prettytable.py", line 818, in add_row
raise Exception("Row has incorrect number of values, (actual) %d!=%d (expected)" %(len(row),len(self._field_names)))
Exception: Row has incorrect number of values, (actual) 8!=7 (expected)
Change-Id: I6a163e74fefc896464e35a6a1b91ce57de592f1a
Reviewed-on: http://gerrit.cloudera.org:8080/14925
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/benchmark/report_benchmark_results.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6a163e74fefc896464e35a6a1b91ce57de592f1a
Gerrit-Change-Number: 14925
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
[Impala-ASF-CR] Fix bug in report benchmark results.py
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14925 )
Change subject: Fix bug in report_benchmark_results.py
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a163e74fefc896464e35a6a1b91ce57de592f1a
Gerrit-Change-Number: 14925
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Dec 2019 12:32:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fix bug in report benchmark results.py
Posted by "Norbert Luksa (Code Review)" <ge...@cloudera.org>.
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14925 )
Change subject: Fix bug in report_benchmark_results.py
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/14925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a163e74fefc896464e35a6a1b91ce57de592f1a
Gerrit-Change-Number: 14925
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Dec 2019 08:35:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fix bug in report benchmark results.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14925 )
Change subject: Fix bug in report_benchmark_results.py
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a163e74fefc896464e35a6a1b91ce57de592f1a
Gerrit-Change-Number: 14925
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Dec 2019 12:32:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fix bug in report benchmark results.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14925 )
Change subject: Fix bug in report_benchmark_results.py
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5310/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a163e74fefc896464e35a6a1b91ce57de592f1a
Gerrit-Change-Number: 14925
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Dec 2019 20:05:19 +0000
Gerrit-HasComments: No