You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/16 08:42:54 UTC

[GitHub] [flink] zinking opened a new pull request, #20288: [FLINK-28575] [connectors/hbase] support hbase connector 2.2 write to 2.4.9

zinking opened a new pull request, #20288:
URL: https://github.com/apache/flink/pull/20288

   support hbase connector 2.2 to write to hbase 2.4.9
   
   ### What is the purpose of the change
   hbase does version checks when creating configurations by default
   so this prevents using connector2.2 to write to like hbase 2.4.9. however this restriction is not necessary.
   
   ### Brief change log
   add the hbase configuration to skip the version check
   
   ### Verifying this change
   This change can be verified as follows:
   hbase-2.2 connector writes normally to hbase 2.4.9 in my local integration
   
   ### Does this pull request potentially affect one of the following parts:
   Dependencies (does it add or upgrade a dependency): no
   The public API, i.e., is any changed class annotated with @Public(Evolving): no
   The serializers: no
   The runtime per-record code paths (performance sensitive): no
   Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
   The S3 file system connector: no
   
   ### Documentation
   Does this pull request introduce a new feature? no
   If yes, how is the feature documented?
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #20288: [FLINK-28575] [connectors/hbase] support hbase connector 2.2 write to 2.4.9

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20288:
URL: https://github.com/apache/flink/pull/20288#issuecomment-1186123124

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a2c8c43c00ebb7122a02504caf8b199857e6977e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a2c8c43c00ebb7122a02504caf8b199857e6977e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a2c8c43c00ebb7122a02504caf8b199857e6977e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zinking commented on pull request #20288: [FLINK-28575] [connectors/hbase] support hbase connector 2.2 write to 2.4.9

Posted by GitBox <gi...@apache.org>.
zinking commented on PR #20288:
URL: https://github.com/apache/flink/pull/20288#issuecomment-1187038457

   well, if the hbase public APIs are relatively stable (which I believe is the case within minor releases). then I guess there are no reasons down stream will be impacted.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on pull request #20288: [FLINK-28575] [connectors/hbase] support hbase connector 2.2 write to 2.4.9

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #20288:
URL: https://github.com/apache/flink/pull/20288#issuecomment-1187042126

   Without testing, you don't know. Yet, when it's broken, people will look at Flink as being the one that's broken. 
   
   I'm fully onboard with adding support for other versions of HBase, but not like this. I would even prefer to first externalize the HBase connector (like we're doing with all of them) before adding more features to the connector bundled with Flink. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org