You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/03/01 07:35:32 UTC

[GitHub] [shardingsphere] jingshanglu opened a new pull request #9540: Improve parser exception handling

jingshanglu opened a new pull request #9540:
URL: https://github.com/apache/shardingsphere/pull/9540


   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io commented on pull request #9540: Improve parser exception handling

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9540:
URL: https://github.com/apache/shardingsphere/pull/9540#issuecomment-787782014


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9540?src=pr&el=h1) Report
   > Merging [#9540](https://codecov.io/gh/apache/shardingsphere/pull/9540?src=pr&el=desc) (5072dae) into [master](https://codecov.io/gh/apache/shardingsphere/commit/72c87452092e5072ab4d0e3c67320fd93ba478a6?el=desc) (72c8745) will **decrease** coverage by `0.00%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/9540/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/9540?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #9540      +/-   ##
   ============================================
   - Coverage     68.17%   68.16%   -0.01%     
     Complexity      669      669              
   ============================================
     Files          1660     1660              
     Lines         27415    27419       +4     
     Branches       4826     4826              
   ============================================
     Hits          18689    18689              
   - Misses         7373     7377       +4     
     Partials       1353     1353              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/9540?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...stsql/parser/api/DistSQLStatementParserEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/9540/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXIvc2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXItZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL3BhcnNlci9hcGkvRGlzdFNRTFN0YXRlbWVudFBhcnNlckVuZ2luZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...here/sql/parser/core/parser/SQLParserExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/9540/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL3BhcnNlci9TUUxQYXJzZXJFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9540?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9540?src=pr&el=footer). Last update [72c8745...5072dae](https://codecov.io/gh/apache/shardingsphere/pull/9540?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] jingshanglu commented on pull request #9540: Improve parser exception handling

Posted by GitBox <gi...@apache.org>.
jingshanglu commented on pull request #9540:
URL: https://github.com/apache/shardingsphere/pull/9540#issuecomment-787758498


   > Please add test cases
   
   Ok.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #9540: Improve parser exception handling

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #9540:
URL: https://github.com/apache/shardingsphere/pull/9540


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org