You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/12/01 05:23:56 UTC

[GitHub] [incubator-mxnet] TaoLv commented on issue #16891: Upgrading MKLDNN to 1.0 causes performance regression.

TaoLv commented on issue #16891: Upgrading MKLDNN to 1.0 causes performance regression.
URL: https://github.com/apache/incubator-mxnet/issues/16891#issuecomment-560058223
 
 
   @oorqueda @samskalicky @leleamol As mentioned in https://github.com/apache/incubator-mxnet/issues/16891#issuecomment-557760466, I suspect that the regression is caused by the removal of libiomp5.so. To verify, please try to apply the below patch to `make/pip_linux_mkl.mk`:
   
   ```
   diff --git a/make/pip/pip_linux_mkl.mk b/make/pip/pip_linux_mkl.mk
   index 1cf389ae4..dd23434fa 100644
   --- a/make/pip/pip_linux_mkl.mk
   +++ b/make/pip/pip_linux_mkl.mk
   @@ -49,7 +49,7 @@ ADD_CFLAGS += -I$(DEPS_PATH)/include -ffunction-sections -fdata-sections
    # choose the version of blas you want to use
    # can be: mkl, blas, atlas, openblas
    # in default use atlas for linux while apple for osx
   -USE_BLAS=openblas
   +USE_BLAS=mkl
   
    # whether use opencv during compilation
    # you can disable it, however, you will not able to use
   @@ -98,7 +98,7 @@ USE_LAPACK_PATH = $(DEPS_PATH)/lib
   
    # add path to intel library, you may need it for MKL, if you did not add the path
    # to environment variable
   -USE_INTEL_PATH = NONE
   +USE_INTEL_PATH = /opt/intel/
   ```
   And then build MXNet with:
   ```
   tools/staticbuild/build.sh mkl pip
   ```
   If it's true, I don't think we have any choice to avoid the regression in pip packages as removing libiomp5.so is a requirement from Apache. Please refer to https://github.com/apache/incubator-mxnet/issues/15544. Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services