[jira] [Commented] (HIVE-548) Code cleanup: refactor the 4 methods like SemanticAnalyzer.genGroupByPlanGroupByOperator

["Ashutosh Chauhan (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138549#comment-13138549 ] 

Ashutosh Chauhan commented on HIVE-548:
---------------------------------------

Is there any interest in this work? I am asking because such refactoring patches go stale pretty quickly and its hard to maintain them. If there is an interest, let me know and I will come up with another patch. If there is no interest feel free to resolve this as "Won't fix"
                
> Code cleanup: refactor the 4 methods like SemanticAnalyzer.genGroupByPlanGroupByOperator
> ----------------------------------------------------------------------------------------
>
>                 Key: HIVE-548
>                 URL: https://issues.apache.org/jira/browse/HIVE-548
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Zheng Shao
>            Assignee: Ashutosh Chauhan
>         Attachments: hive-548.patch
>
>
> We have 4 methods to generate the GroupByOperators in the SemanticAnalyzer:
> {code}
>   SemanticAnalyzer.genGroupByPlanGroupByOperator
>   SemanticAnalyzer.genGroupByPlanMapGroupByOperator
>   SemanticAnalyzer.genGroupByPlanGroupByOperator1
>   SemanticAnalyzer.genGroupByPlanGroupByOperator2
> {code}
> While they are all different, a substantial portion of them are the same. We should factor out all the common functionality into shared functions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira