You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/05/21 00:09:37 UTC

Review Request: Removed unnecessary TestingIsolators.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11276/
-----------------------------------------------------------

Review request for mesos and Thomas Marshall.


Description
-------

Given that the tests did 'WillRepeatedly' for the isolator I didn't see any value of using them, so I simplified. ;)


Diffs
-----

  src/tests/allocator_tests.cpp 540c05afa54caafea7c0b49773cf2613c87d1ba5 

Diff: https://reviews.apache.org/r/11276/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman

Re: Review Request: Removed unnecessary TestingIsolators.

Posted by Thomas Marshall <tw...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11276/#review20803
-----------------------------------------------------------

Ship it!


Ship It!

- Thomas Marshall


On May 20, 2013, 10:09 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11276/
> -----------------------------------------------------------
> 
> (Updated May 20, 2013, 10:09 p.m.)
> 
> 
> Review request for mesos and Thomas Marshall.
> 
> 
> Description
> -------
> 
> Given that the tests did 'WillRepeatedly' for the isolator I didn't see any value of using them, so I simplified. ;)
> 
> 
> Diffs
> -----
> 
>   src/tests/allocator_tests.cpp 540c05afa54caafea7c0b49773cf2613c87d1ba5 
> 
> Diff: https://reviews.apache.org/r/11276/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>