You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "martinzink (via GitHub)" <gi...@apache.org> on 2023/03/09 12:56:31 UTC
[GitHub] [nifi-minifi-cpp] martinzink opened a new pull request, #1528: MINIFICPP-2063 RFC3339 parsing with expression language
martinzink opened a new pull request, #1528:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1528
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file?
- [x] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1528: MINIFICPP-2063 RFC3339 parsing with expression language
Posted by "martinzink (via GitHub)" <gi...@apache.org>.
martinzink commented on code in PR #1528:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1528#discussion_r1151630587
##########
extensions/expression-language/Expression.cpp:
##########
@@ -633,35 +633,46 @@ Value expr_escapeCsv(const std::vector<Value> &args) {
}
Value expr_format(const std::vector<Value> &args) {
- std::chrono::milliseconds dur(args[0].asUnsignedLong());
- std::chrono::system_clock::time_point dt(dur);
- auto zone = date::current_zone();
- if (args.size() > 2) {
- zone = date::locate_zone(args[2].asString());
- }
- auto t = date::make_zoned(zone, dt);
- std::stringstream result_s;
- result_s << date::format(args[1].asString(), t);
- return Value(result_s.str());
+ using std::chrono::milliseconds;
+
+ date::sys_time<milliseconds> utc_time_point{milliseconds(args[0].asUnsignedLong())};
Review Comment:
yes this uses [std::chrono::system_clock](https://en.cppreference.com/w/cpp/chrono/system_clock) which is a UTC clock, for localtime you would need date::local_time instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1528: MINIFICPP-2063 RFC3339 parsing with expression language
Posted by "szaszm (via GitHub)" <gi...@apache.org>.
szaszm closed pull request #1528: MINIFICPP-2063 RFC3339 parsing with expression language
URL: https://github.com/apache/nifi-minifi-cpp/pull/1528
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1528: MINIFICPP-2063 RFC3339 parsing with expression language
Posted by "szaszm (via GitHub)" <gi...@apache.org>.
szaszm commented on code in PR #1528:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1528#discussion_r1150138533
##########
extensions/expression-language/Expression.cpp:
##########
@@ -633,35 +633,46 @@ Value expr_escapeCsv(const std::vector<Value> &args) {
}
Value expr_format(const std::vector<Value> &args) {
- std::chrono::milliseconds dur(args[0].asUnsignedLong());
- std::chrono::system_clock::time_point dt(dur);
- auto zone = date::current_zone();
- if (args.size() > 2) {
- zone = date::locate_zone(args[2].asString());
- }
- auto t = date::make_zoned(zone, dt);
- std::stringstream result_s;
- result_s << date::format(args[1].asString(), t);
- return Value(result_s.str());
+ using std::chrono::milliseconds;
+
+ date::sys_time<milliseconds> utc_time_point{milliseconds(args[0].asUnsignedLong())};
Review Comment:
Is this really UTC? I thought sys_time is using the local timezone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org