[GitHub] [hudi] yihua commented on a change in pull request #5181: [HUDI-3664] Fixing Column Stats Index composition

[GitBox <gi...@apache.org>]

yihua commented on a change in pull request #5181:
URL: https://github.com/apache/hudi/pull/5181#discussion_r840124713



##########
File path: hudi-common/src/main/avro/HoodieMetadata.avsc
##########
@@ -121,16 +121,192 @@
                             "doc": "Minimum value in the range. Based on user data table schema, we can convert this to appropriate type",
                             "name": "minValue",
                             "type": [
+                                // Those types should be aligned with Parquet `Statistics` impl
+                                // making sure that we implement semantic consistent across file formats
+                                //
+                                // NOTE: Other logical types (decimal, date, timestamp, etc) will be converted
+                                //       into one of the following types, making sure that their corresponding
+                                //       ordering is preserved
                                 "null",
-                                "string"
+                                {

Review comment:
       Per discussion, this is not a problem for public releases, so it's okay to remove it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org